From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995E9C432BE for ; Wed, 25 Aug 2021 18:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83E77610F9 for ; Wed, 25 Aug 2021 18:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242384AbhHYSAp (ORCPT ); Wed, 25 Aug 2021 14:00:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:59132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234684AbhHYSAo (ORCPT ); Wed, 25 Aug 2021 14:00:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F4EF60F35; Wed, 25 Aug 2021 17:59:56 +0000 (UTC) Date: Wed, 25 Aug 2021 18:59:53 +0100 From: Catalin Marinas To: Kefeng Wang Cc: will@kernel.org, ryabinin.a.a@gmail.com, andreyknvl@gmail.com, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, elver@google.com Subject: Re: [PATCH v3 1/3] vmalloc: Choose a better start address in vm_area_register_early() Message-ID: <20210825175953.GI3420@arm.com> References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809093750.131091-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 09, 2021 at 05:37:48PM +0800, Kefeng Wang wrote: > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d5cd52805149..1e8fe08725b8 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2238,11 +2238,17 @@ void __init vm_area_add_early(struct vm_struct *vm) > */ > void __init vm_area_register_early(struct vm_struct *vm, size_t align) > { > - static size_t vm_init_off __initdata; > - unsigned long addr; > - > - addr = ALIGN(VMALLOC_START + vm_init_off, align); > - vm_init_off = PFN_ALIGN(addr + vm->size) - VMALLOC_START; > + struct vm_struct *head = vmlist, *curr, *next; > + unsigned long addr = ALIGN(VMALLOC_START, align); > + > + while (head != NULL) { Nitpick: I'd use the same pattern as in vm_area_add_early(), i.e. a 'for' loop. You might as well insert it directly than calling the add function and going through the loop again. Not a strong preference either way. > + next = head->next; > + curr = head; > + head = next; > + addr = ALIGN((unsigned long)curr->addr + curr->size, align); > + if (next && (unsigned long)next->addr - addr > vm->size) Is greater or equal sufficient? > + break; > + } > > vm->addr = (void *)addr; Another nitpick: it's very unlikely on a 64-bit architecture but not impossible on 32-bit to hit VMALLOC_END here. Maybe some BUG_ON. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C872EC4320E for ; Wed, 25 Aug 2021 18:02:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9594760F91 for ; Wed, 25 Aug 2021 18:02:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9594760F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hFZkW5jq8mvmysYpHVNQyTl0qEm1ul0PJXugY4UMysI=; b=wWrfHUYZL5Ynr6 uez3PmR3ieyLR1xat8RKaeSGcts05k8lS7AYs1Z7LoSCOKb7YcaOzpz/OoEMV+HjK5CqeJ7qZPgkQ u30L4JfHbY4j1xqqnGLxx1XbV1GWkxuD01+e9vbdzdLEc6vKj+4MnajLy+N1TJWvMkCiKPqQINmUc D6rX2t9Zxl9n/oR7qUHlsgDs6Xl5MDGBilwSES0dN+xpxiSdR3mKsE/6VcTZ/egpNaqJJNwU84jXx qJiicbyHrCYl0eKWqU8fA3Hkfk0uB/+/rfidwhZIz4uXDsXy6y+90lr1ulWz9ZyjzfpqYF+ozQUeP bMkRwIgJTpYuTA1rSIKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIxC2-008ADB-2p; Wed, 25 Aug 2021 18:00:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIxBv-008AB1-1b for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 18:00:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F4EF60F35; Wed, 25 Aug 2021 17:59:56 +0000 (UTC) Date: Wed, 25 Aug 2021 18:59:53 +0100 From: Catalin Marinas To: Kefeng Wang Cc: will@kernel.org, ryabinin.a.a@gmail.com, andreyknvl@gmail.com, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, elver@google.com Subject: Re: [PATCH v3 1/3] vmalloc: Choose a better start address in vm_area_register_early() Message-ID: <20210825175953.GI3420@arm.com> References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <20210809093750.131091-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210809093750.131091-2-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_105959_147217_B7AC8EEB X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 09, 2021 at 05:37:48PM +0800, Kefeng Wang wrote: > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d5cd52805149..1e8fe08725b8 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2238,11 +2238,17 @@ void __init vm_area_add_early(struct vm_struct *vm) > */ > void __init vm_area_register_early(struct vm_struct *vm, size_t align) > { > - static size_t vm_init_off __initdata; > - unsigned long addr; > - > - addr = ALIGN(VMALLOC_START + vm_init_off, align); > - vm_init_off = PFN_ALIGN(addr + vm->size) - VMALLOC_START; > + struct vm_struct *head = vmlist, *curr, *next; > + unsigned long addr = ALIGN(VMALLOC_START, align); > + > + while (head != NULL) { Nitpick: I'd use the same pattern as in vm_area_add_early(), i.e. a 'for' loop. You might as well insert it directly than calling the add function and going through the loop again. Not a strong preference either way. > + next = head->next; > + curr = head; > + head = next; > + addr = ALIGN((unsigned long)curr->addr + curr->size, align); > + if (next && (unsigned long)next->addr - addr > vm->size) Is greater or equal sufficient? > + break; > + } > > vm->addr = (void *)addr; Another nitpick: it's very unlikely on a 64-bit architecture but not impossible on 32-bit to hit VMALLOC_END here. Maybe some BUG_ON. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel