All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] can: usb: esd_usb2: Fix the interchange of CAN TX and RX error counters
@ 2021-08-25 21:52 Stefan Mätje
  2021-08-25 21:52 ` [PATCH 1/1] can: usb: esd_usb2: Fix the interchange of the CAN RX and TX " Stefan Mätje
  2021-08-26  6:43 ` [PATCH 0/1] can: usb: esd_usb2: Fix the interchange of CAN TX and RX " Marc Kleine-Budde
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Mätje @ 2021-08-25 21:52 UTC (permalink / raw)
  To: linux-can, Marc Kleine-Budde
  Cc: Wolfgang Grandegger, netdev, Stefan Mätje

In the driver for the esd CAN-USB/2 the CAN RX and TX error counters
were fetched interchanged from the ESD_EV_CAN_ERROR_EXT message and
therefore delivered wrong to the user.

To verify the now correct behavior call the candump tool to print CAN
error frames with extra infos (including CAN RX and TX error counters)
like "candump -e -x can4,0:0,#fffffffff".
Then send a CAN frame to the open (no other node) but terminated CAN
bus. The TX error counter must increase by 8 for each transmit attempt
until CAN_STATE_ERROR_PASSIVE is reached.

Stefan Mätje (1):
  can: usb: esd_usb2: Fix the interchange of the CAN RX and TX error
    counters.

 drivers/net/can/usb/esd_usb2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: cbe8cd7d83e251bff134a57ea4b6378db992ad82
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-26  6:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 21:52 [PATCH 0/1] can: usb: esd_usb2: Fix the interchange of CAN TX and RX error counters Stefan Mätje
2021-08-25 21:52 ` [PATCH 1/1] can: usb: esd_usb2: Fix the interchange of the CAN RX and TX " Stefan Mätje
2021-08-26  6:43 ` [PATCH 0/1] can: usb: esd_usb2: Fix the interchange of CAN TX and RX " Marc Kleine-Budde

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.