From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F11C432BE for ; Thu, 26 Aug 2021 10:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA79C6023E for ; Thu, 26 Aug 2021 10:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241584AbhHZKm2 (ORCPT ); Thu, 26 Aug 2021 06:42:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55970 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241692AbhHZKm1 (ORCPT ); Thu, 26 Aug 2021 06:42:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629974499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WUSm/I+IuKQjkjPbmUi8oDeiiUHMswrLJ2gKcEGs3AM=; b=a8dyIuJOw4rL8vmo6E6ikZGMwjFJeJpbEZRHkS1ueW7fUtmqHpsrt+S4kP9+u6BAEY4YoK kz4DCiS7sUar4TusebSRG8x4VaBP+u7uCbLUvhv9AKhWgBV6xIztFPkZ46Zgx2vkYiF82W vsa/XwpXlmUbiB6BdOswCiXjiPsLduY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-5eWfWPlyNSmcwndz2142DA-1; Thu, 26 Aug 2021 06:41:38 -0400 X-MC-Unique: 5eWfWPlyNSmcwndz2142DA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90114100806A; Thu, 26 Aug 2021 10:41:36 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 651D25C1D5; Thu, 26 Aug 2021 10:41:31 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D420818003AA; Thu, 26 Aug 2021 12:41:29 +0200 (CEST) Date: Thu, 26 Aug 2021 12:41:29 +0200 From: Gerd Hoffmann To: isaku.yamahata@gmail.com Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, alistair@alistair23.me, ehabkost@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, cohuck@redhat.com, mtosatti@redhat.com, xiaoyao.li@intel.com, seanjc@google.com, erdemaktas@google.com, kvm@vger.kernel.org, isaku.yamahata@intel.com, Sean Christopherson Subject: Re: [RFC PATCH v2 15/44] i386/tdx: Add hook to require generic device loader Message-ID: <20210826104129.ukhut4lnttybf3sy@sirius.home.kraxel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > + /* > + * Sanitiy check for tdx: > + * TDX uses generic loader to load bios instead of pflash. > + */ > + for (i = 0; i < ARRAY_SIZE(pcms->flash); i++) { > + if (drive_get(IF_PFLASH, 0, i)) { > + error_report("pflash not supported by VM type, " > + "use -device loader,file="); > + exit(1); > + } I suspect that catches only "-drive if=pflash,..." but not "-machine pflash0=..." Also: why does tdx not support flash? Should be explained in the commit message. thanks, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6029BC432BE for ; Thu, 26 Aug 2021 10:43:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2CCA6023E for ; Thu, 26 Aug 2021 10:43:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2CCA6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJCql-0005VQ-V5 for qemu-devel@archiver.kernel.org; Thu, 26 Aug 2021 06:43:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJCpP-0004np-OS for qemu-devel@nongnu.org; Thu, 26 Aug 2021 06:41:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJCpL-0005hy-Aj for qemu-devel@nongnu.org; Thu, 26 Aug 2021 06:41:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629974501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WUSm/I+IuKQjkjPbmUi8oDeiiUHMswrLJ2gKcEGs3AM=; b=RgxCqg7O/9a4PevcYNvErW8joAObf8LCP64HiUBB7seruEL4S9gPzrgTmxz3pFJ2M1jnCu YdRd/kMKJm0k86bLOgfZSuW9E50vg4VN6ZnroLxryYai4wPPUeL97NpsTyLbVxYoRmV4gE aU82KHrIShFozVl0qH5e9eYAyYcHHLI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-5eWfWPlyNSmcwndz2142DA-1; Thu, 26 Aug 2021 06:41:38 -0400 X-MC-Unique: 5eWfWPlyNSmcwndz2142DA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90114100806A; Thu, 26 Aug 2021 10:41:36 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 651D25C1D5; Thu, 26 Aug 2021 10:41:31 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D420818003AA; Thu, 26 Aug 2021 12:41:29 +0200 (CEST) Date: Thu, 26 Aug 2021 12:41:29 +0200 From: Gerd Hoffmann To: isaku.yamahata@gmail.com Subject: Re: [RFC PATCH v2 15/44] i386/tdx: Add hook to require generic device loader Message-ID: <20210826104129.ukhut4lnttybf3sy@sirius.home.kraxel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.745, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: isaku.yamahata@intel.com, cohuck@redhat.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, seanjc@google.com, alistair@alistair23.me, xiaoyao.li@intel.com, qemu-devel@nongnu.org, Sean Christopherson , mtosatti@redhat.com, erdemaktas@google.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > + /* > + * Sanitiy check for tdx: > + * TDX uses generic loader to load bios instead of pflash. > + */ > + for (i = 0; i < ARRAY_SIZE(pcms->flash); i++) { > + if (drive_get(IF_PFLASH, 0, i)) { > + error_report("pflash not supported by VM type, " > + "use -device loader,file="); > + exit(1); > + } I suspect that catches only "-drive if=pflash,..." but not "-machine pflash0=..." Also: why does tdx not support flash? Should be explained in the commit message. thanks, Gerd