From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 892FDC4320E for ; Thu, 26 Aug 2021 11:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AA5F61002 for ; Thu, 26 Aug 2021 11:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242311AbhHZLvF (ORCPT ); Thu, 26 Aug 2021 07:51:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58451 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242114AbhHZLvE (ORCPT ); Thu, 26 Aug 2021 07:51:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629978616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6f+SFpkHjRPtkesxRZFEuliH8AuQ4OkeQD6uS5L8N9M=; b=Vyp9dVlA3cjIrIMrKrvVXq7K2qItvMMvMLY7YmfaI0HBsb/yWl8mBXx4zewa++R4XWRrbN 7+7xtzv8Q7CKDTc/HxthgJvZFPFK5L8vuv7R/aBYwXOEi66TCAs0JH3P/rQBXZOWJWnmXc pgMgY77REFpG9rdLw7B/Jw+Mh9NYgIE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-EyeuOODBNGmRSevJcsn_dw-1; Thu, 26 Aug 2021 07:50:12 -0400 X-MC-Unique: EyeuOODBNGmRSevJcsn_dw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B96A94DD4; Thu, 26 Aug 2021 11:50:11 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B337E60871; Thu, 26 Aug 2021 11:50:07 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 14A4918003AA; Thu, 26 Aug 2021 13:50:06 +0200 (CEST) Date: Thu, 26 Aug 2021 13:50:06 +0200 From: Gerd Hoffmann To: isaku.yamahata@gmail.com Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, alistair@alistair23.me, ehabkost@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, cohuck@redhat.com, mtosatti@redhat.com, xiaoyao.li@intel.com, seanjc@google.com, erdemaktas@google.com, kvm@vger.kernel.org, isaku.yamahata@intel.com, Sean Christopherson Subject: Re: [RFC PATCH v2 29/44] target/i386: Add machine option to disable PIC/8259 Message-ID: <20210826115006.vjmtdubyac5mppou@sirius.home.kraxel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, > + object_class_property_add_bool(oc, PC_MACHINE_PIC, > + pc_machine_get_pic, pc_machine_set_pic); microvm already has such an option. We should move it from microvm to the common x86 base type so pc can use it too. > #define PC_MACHINE_PIT "pit" > +#define PC_MACHINE_PIC "pic" Oh, same for pit. Instead of both pc and microvm having that it likewise should be a property of the common x86 base machine type. take care, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A133C432BE for ; Thu, 26 Aug 2021 11:51:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9DF561002 for ; Thu, 26 Aug 2021 11:51:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A9DF561002 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJDuT-0004Lc-MO for qemu-devel@archiver.kernel.org; Thu, 26 Aug 2021 07:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJDtg-0003b6-W4 for qemu-devel@nongnu.org; Thu, 26 Aug 2021 07:50:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJDtf-0002lJ-2M for qemu-devel@nongnu.org; Thu, 26 Aug 2021 07:50:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629978614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6f+SFpkHjRPtkesxRZFEuliH8AuQ4OkeQD6uS5L8N9M=; b=E+W8CL1PnUz3PAPkxRpPAFC3/e1m4Ob9b2VKlzxTe++RhFRXwd1leSSFR5IUKe7tH04guf kmYGvsjLdt39ejLSEbc5RdsdzOvLZdsKEsmpXT5WYylv8Gw+5cE8KkxOEjsC6VxNmoU4Iw 4fcImlZVoU4xjMF62uqT43ilUBKFxVg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-EyeuOODBNGmRSevJcsn_dw-1; Thu, 26 Aug 2021 07:50:12 -0400 X-MC-Unique: EyeuOODBNGmRSevJcsn_dw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B96A94DD4; Thu, 26 Aug 2021 11:50:11 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B337E60871; Thu, 26 Aug 2021 11:50:07 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 14A4918003AA; Thu, 26 Aug 2021 13:50:06 +0200 (CEST) Date: Thu, 26 Aug 2021 13:50:06 +0200 From: Gerd Hoffmann To: isaku.yamahata@gmail.com Subject: Re: [RFC PATCH v2 29/44] target/i386: Add machine option to disable PIC/8259 Message-ID: <20210826115006.vjmtdubyac5mppou@sirius.home.kraxel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: isaku.yamahata@intel.com, cohuck@redhat.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, seanjc@google.com, alistair@alistair23.me, xiaoyao.li@intel.com, qemu-devel@nongnu.org, Sean Christopherson , mtosatti@redhat.com, erdemaktas@google.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > + object_class_property_add_bool(oc, PC_MACHINE_PIC, > + pc_machine_get_pic, pc_machine_set_pic); microvm already has such an option. We should move it from microvm to the common x86 base type so pc can use it too. > #define PC_MACHINE_PIT "pit" > +#define PC_MACHINE_PIC "pic" Oh, same for pit. Instead of both pc and microvm having that it likewise should be a property of the common x86 base machine type. take care, Gerd