From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1429C4320E for ; Thu, 26 Aug 2021 11:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDC9761058 for ; Thu, 26 Aug 2021 11:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242345AbhHZLvJ (ORCPT ); Thu, 26 Aug 2021 07:51:09 -0400 Received: from mga07.intel.com ([134.134.136.100]:45624 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242100AbhHZLvI (ORCPT ); Thu, 26 Aug 2021 07:51:08 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="281443945" X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="281443945" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 04:50:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="465099620" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 26 Aug 2021 04:50:21 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 719855805A3; Thu, 26 Aug 2021 04:50:17 -0700 (PDT) Date: Thu, 26 Aug 2021 19:50:14 +0800 From: Wong Vee Khee To: Andrew Lunn Cc: Florian Fainelli , Vivien Didelot , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: <20210826115014.GA5112@linux.intel.com> References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> <20210810235529.GB30818@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 11, 2021 at 04:20:56PM +0200, Andrew Lunn wrote: > > > BIOS does configured the SerDes. The problem here is that all the > > > configurations done by BIOS are being reset at xpcs_create(). > > > > > > We would want user of the pcs-xpcs module (stmmac, sja1105) to have > > > control whether or not we need to perform to the soft reset in the > > > xpcs_create() call. > > > > I understood Andrew's response as suggesting to introduce the ability for > > xpcs_create() to make a BIOS call which would configure the SerDes after > > xpcs_soft_reset(). > > Yes. Exactly. That is what ACPI is for, so we should use it for this. > > Andrew Thanks Florian for the explaination. I have checked with the BIOS developers and they did not implmenet a method to this at the kernel level. Also, Intel AlderLake has both UEFI BIOS and Slim Bootloader which make it least feasible to go for the ACPI method as per suggested. Regards, VK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C25C432BE for ; Thu, 26 Aug 2021 11:52:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 967806108D for ; Thu, 26 Aug 2021 11:52:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 967806108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tYUDMNgjVAaF5GFJ0jQLIrMUnE6/VkVovLYMnjEFlxQ=; b=yPUFsTTS1ON1ic YSbcKb657G9T3sEtaDjoObkiVQ683adsXT6LbwMoVhGIwFaWpF9TyX3butvN7LPkxuDrZf1eW4zXC qAcaM5hhFaCHSaSi/xNdZLDzVMx9knwPtdjq55wvyzKBhXdQJLEN7PBWT8RfqwyaaIkVh2qNzObEN O2mULpg58llfd+gcM+CEUQzz2tCxB/1kPY28aM1hw9RiDpXyY+/hkJ6YkZk3ybq1OY8P02qXt6MO9 /6WDR6hUa2rzKC5AV2ABu9Z3Z/mSEzcn5U84ws+Mzbs14A03dPqw9DIGc3eqOF1e/dvhRSZelphsl eBOe+6T1GdnntIza3AxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJDts-009ypR-1d; Thu, 26 Aug 2021 11:50:28 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJDtn-009yoi-SY for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 11:50:25 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="214597320" X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="214597320" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 04:50:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="465099620" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 26 Aug 2021 04:50:21 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 719855805A3; Thu, 26 Aug 2021 04:50:17 -0700 (PDT) Date: Thu, 26 Aug 2021 19:50:14 +0800 From: Wong Vee Khee To: Andrew Lunn Cc: Florian Fainelli , Vivien Didelot , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: <20210826115014.GA5112@linux.intel.com> References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> <20210810235529.GB30818@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_045023_982491_C587A055 X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 11, 2021 at 04:20:56PM +0200, Andrew Lunn wrote: > > > BIOS does configured the SerDes. The problem here is that all the > > > configurations done by BIOS are being reset at xpcs_create(). > > > > > > We would want user of the pcs-xpcs module (stmmac, sja1105) to have > > > control whether or not we need to perform to the soft reset in the > > > xpcs_create() call. > > > > I understood Andrew's response as suggesting to introduce the ability for > > xpcs_create() to make a BIOS call which would configure the SerDes after > > xpcs_soft_reset(). > > Yes. Exactly. That is what ACPI is for, so we should use it for this. > > Andrew Thanks Florian for the explaination. I have checked with the BIOS developers and they did not implmenet a method to this at the kernel level. Also, Intel AlderLake has both UEFI BIOS and Slim Bootloader which make it least feasible to go for the ACPI method as per suggested. Regards, VK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel