From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mJG8I-000433-KA for mharc-grub-devel@gnu.org; Thu, 26 Aug 2021 10:13:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJG8G-0003yq-MO for grub-devel@gnu.org; Thu, 26 Aug 2021 10:13:28 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:50696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJG8C-0001g1-0U for grub-devel@gnu.org; Thu, 26 Aug 2021 10:13:28 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17QCrAw0017616; Thu, 26 Aug 2021 14:13:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=lOiO5hzHjS1jFnV3gdeymzJ+dCguskcCDaxxAPwb2LQ=; b=lfs/BmQif7sGhm69ALVlok3dU0YNrBzDql8ZbzsDNnU/4aHT3OcT4ilM+8JpFPbstiXL Fyoo2UuiCOReGL80yIQs84hQOOUHzzkhyoe01SAku7BaE0fQqdV/TenfT1u1mDKsMvu1 TMu7PvLryiron6BTj6qOqJMhR2H6eEfznR2ULvTa1NPUMAX/rTUFizALg5JWzJFgFZAH tOhk493ify313p3diTGFwTVVg4GHVlXXwPLBAJaiydAGKdyEWZwdkraQjDexziaiWkCa wa5Jjhu2Tc/T4Lo4WELkt02rTz07Y2S2d5U3H//bpcremy2ORxaLb+SNAKYzkgqDLl2N cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=lOiO5hzHjS1jFnV3gdeymzJ+dCguskcCDaxxAPwb2LQ=; b=QrJ/Y77YVjy8LcvPPmmdRCRhZ7niZ1TTDmUByRM44eUqrbhgEYnSDvbFhhWPOP7BMYQV +9TWLgyGDbk9GQllCmY05iWQagkn0jiZw2nOthWGKNlDcV7jkAryFfiyBLf0W2XmJTwj 5gg+C2ZQunzToIekLpYdGfC4oUg4e9jrcmna8ZuQeiVdZ9/mLpLmCcMBtMy6wnC1eTlU bzvzTm4W2/zAscLh56jWR3HQIK8j7cQozOoi0BgO6yXuuXArb3E78POXcKpcHGxAxJBC yyNBIARtq90OOd0+ErW0zZeuIHGXQN2K9MjTbQ4YwjevuedilEUKGCuMZdCDjK8+qQ9F qw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ap4eks5pp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Aug 2021 14:13:18 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 17QDtjH5156970; Thu, 26 Aug 2021 14:13:17 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by userp3030.oracle.com with ESMTP id 3ajpm2mx15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Aug 2021 14:13:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKuO0In9s31FvPH2x8zbc4psmGjbV+SJkp1nkwl7ZDwtCkG+zTXlgRy32JZXDonZ7sgfazlt3UJiY6ntPEl7QdS4rUSh5ZgTF2Y+BBFmwxoQwujpVUfoGRe1Eo579KRjrG8He1nDQL7VVeZUk9mQfnGKF9+IlLprKJUI3hJSBUwcb8zISd98vQj7HYmqse0faoyFVKgl1+E48UZVLymwxejAROCE6E+1SI6PLQE8Ecg5BuWYO1/lGaUev5dJ/Juy/lDelwtMvy7QRVrJ5l8gf9+yLJiL6rmaSEAAnmxWT8O1DMWm3vEcA5/xON3rakqO8P7eTO7r3wddhze6HSbgMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOiO5hzHjS1jFnV3gdeymzJ+dCguskcCDaxxAPwb2LQ=; b=SgkN2L70pNdjYPF9WY24cQR1kCRR4sPmtHofjRph/DdRsJczzw7KAfYPjKe2z/I37qEeZ3JLpd/BMDKwpdpFVhb4GmUBFeRgQ6PJmmrw8sJNIJr+yuZE7R47mHeL/EBZMTWoM+guzqt9AomYxvGineqbfyHjALPjm05vmGb2/EI+RBmS9GBuvOBlLrHydJG2dRZwT5VOASk6w6TLURQIS7xzt25+Xr9dZHJPHCVq7GaHPbmVnCUG2CzIcO+xb/PjGk5qgEMCUwCs1Sgyanl/4q8dpAwyMjOGPkPbx+vChNPTc8w3+o1MZIqJEoWpJeDkzBgUjjgsgYe4FevszP00EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOiO5hzHjS1jFnV3gdeymzJ+dCguskcCDaxxAPwb2LQ=; b=UlrzJwtImm3NjsyEz5UTr3Svyu5tEZc51R9KaVo9nQlP8qNS9BbYfidANbQ63Yj+DRLB7tf4Z2XgWg8Yzv3ysce/oh1K5Xy4+briA6wiwYrSd/KAaQi0QBKWm80jGLkES0CdoVdViqEGwlMej/bzLEWRWJLKmsG2ChO/NATJGto= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=oracle.com; Received: from CY4PR1001MB2230.namprd10.prod.outlook.com (2603:10b6:910:46::36) by CY4PR10MB1734.namprd10.prod.outlook.com (2603:10b6:910:8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Thu, 26 Aug 2021 14:13:15 +0000 Received: from CY4PR1001MB2230.namprd10.prod.outlook.com ([fe80::e0a6:ce87:61ef:b0ba]) by CY4PR1001MB2230.namprd10.prod.outlook.com ([fe80::e0a6:ce87:61ef:b0ba%7]) with mapi id 15.20.4436.024; Thu, 26 Aug 2021 14:13:15 +0000 Date: Thu, 26 Aug 2021 16:13:07 +0200 From: Daniel Kiper To: Fangrui Song Cc: grub-devel@gnu.org, Alex Burmashev , Vladimir 'phcoder' Serbinenko Subject: Re: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 Message-ID: <20210826135138.bmb4y6lt5d5yua2x@tomti.i.net-space.pl> References: <20210824061838.3569412-1-maskray@google.com> <20210824061838.3569412-3-maskray@google.com> <20210825132408.owyrc2gm72zgg5s6@tomti.i.net-space.pl> <20210825163441.vfzgujarnnq2rs4l@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825163441.vfzgujarnnq2rs4l@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: AM5PR1001CA0032.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::45) To CY4PR1001MB2230.namprd10.prod.outlook.com (2603:10b6:910:46::36) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tomti.i.net-space.pl (84.10.22.86) by AM5PR1001CA0032.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Thu, 26 Aug 2021 14:13:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d76a4a72-b819-41b6-fe79-08d9689ba53e X-MS-TrafficTypeDiagnostic: CY4PR10MB1734: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6SnjHJNEw81cCQlyUAkEY1tEC/QCF24eqDYUC4w6WV5+4ssGXGDizXWbkhBwYVpuLJZ/jTlRiqeIbxXTOmZwLieWt849xYSZp0B9rx8199rBo1QBnZmJQcDzGKbKB/5W7qf+pwzGKPt1Crul2UyBQcqZbZgzr+Yd3GsFGHaCU646tHevaIKQD5iAltaM5HhLhLiJ5+j35S7TYVQRO3krvoSQrFsSujaWZkhz6f8efJ4gGhhw1VbhyLgOK7JL7smGls1yXRhN0SKDlKggBtiHAgKG/p1JaxCanz/MWg7NzxECiYyAriheo1FDdvhUzNNEDMaM5/xBUWWOj0tzj4bFxz0p9Uf/P+wdWu8qhv03VaKl6M/CE53YKg6n9zMIJPbTYUMRG1naILdi4U/XdAUInQXYI9apjiwebMEGlyjSiqBKQQunXdcCfwYLQYWVHtxqtmzZECcXmU+IeSJFHQy1QvTZk5H2CNdbyeH+q187PkwlhbAaoBlBpk29vCKtQGqJMvdPAXe1WhELrVK9ra3UNYw0IMEY6DmX9wW6Bp4KQKM4uADmMnap/P3YUpllnOgsxoJ8PcJKXQ7XslnW7XYQVNlrLWS9KP5dCY3z661L8G4JIeJ5i6SZweFi1Z22EsdewgcTkbrcb8ifHpyMf3qGBTVij5Q2FwHTlL1CLJ+iuqXAe0AWQg2HYXLCNge3GqE7hSi0uIkD8STEkOIZ/SIE9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1001MB2230.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(396003)(346002)(366004)(376002)(54906003)(2906002)(8936002)(38350700002)(6916009)(38100700002)(8676002)(86362001)(7696005)(5660300002)(1076003)(956004)(44832011)(316002)(83380400001)(66946007)(186003)(6666004)(4326008)(478600001)(52116002)(9686003)(55016002)(66556008)(53546011)(6506007)(66476007)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8VyjZb83fg+iwv0JMfg/2MqsIZEf5DdCfOPpxu5R7sJr+ROjG/s7y7V42Ayz?= =?us-ascii?Q?HE8ER2fNdsQh6FX1BRmQt5DQfvr2dwlQXmSov3wg6Va9LDbI2UW2wAEjlmX3?= =?us-ascii?Q?cyVWhHHDCBCnih8nDbkr9t0z0a+D+8M1ktqjP5NZzOVTIbnG8iaZolusSIUb?= =?us-ascii?Q?etAqu3xJSsj+eznTVlkjMe3CCeL4HfCdxkH8yeXS5/GQOHAnGN/Dr7ylBX1q?= =?us-ascii?Q?XqLpRQScSuu7AuG/HbY0xJWrwqyBCJCXYalelNL/7ed2oRqMK60gnLMFYEux?= =?us-ascii?Q?62Gbikwg27v00ZE1N9IN1jLI4hJ7g4hhAnInxdAzQ0PDuPvu8WIzsQpQsF8Q?= =?us-ascii?Q?vj6WjgTdxk/UE5tQGspAwRcxwmnp4rDR5AvAqeb91qDxKgp6kuYOQ47hqrIK?= =?us-ascii?Q?F63OddGW+75gHn6o/hBtEDwVyVuY+A0sm60YhvvFF2E3UTmeocRG1cQWCP31?= =?us-ascii?Q?f6qcyaZ2ScAPzFdJhDvnrv92Ik37Gsfsaxr6OvLuKKFqtV8KiuNB0o5vdLFS?= =?us-ascii?Q?+dZw4jMjNqMfBtbAwDIMf2jFw+e1eI3dFLosnLab0KsfQiY/AZipx45YkwyR?= =?us-ascii?Q?TEQt0zedqRbvQ1Y8UDSWa4HZOc05hdUSnzrJYMidMiqxzV6J3XebbT6LuOun?= =?us-ascii?Q?y068mOOC0CnG+dKOGDD93j+6LQVuF8GzGU0EBswXFoLFCu0qNyox9J9zsDwz?= =?us-ascii?Q?igF5MKRBe894LYJGWC8qeycl5Onz3yMybVg57OgiS59B1gRjAjRwJRip+8E3?= =?us-ascii?Q?5rWcbJS2woswImEGOGdqHJZwZYxfAiS8h5XEH+qti9uMDwl/wdy97WMInHQO?= =?us-ascii?Q?Wyte/UlprkBdJDaIO5VlrV+TFFcAZWsv61dm9tU6oUDvOf9jFF83vGYnsklS?= =?us-ascii?Q?fvb15/BCxLrYHCAXe0sz9GDplasj3F88cLBYbREoVCo3tVNJBGYl5egue+wt?= =?us-ascii?Q?PGBgmgJkMnPMmHLGMS06EZoKk6PFl1KxQv2fleFSe0mDa9nR7LAk/92C2IKF?= =?us-ascii?Q?QPV+S9OhIPl2RB7znk8ID8kTZVm4y03jO4tPKKUl4MlrmTT2X0ngAKkTreDr?= =?us-ascii?Q?6LC5tp2rgX9XVdSt2mw0w849qVc5120PhMuzhVXj3zeV8UkHttreYes6++Sx?= =?us-ascii?Q?a0J8X1pDBBCDhd66CoARPewolTrdOw9cHwkEq3GD9u426xRHhgnybey/cVRy?= =?us-ascii?Q?jRNnQO/+MifP4+aOoEJ7iGcMk+X5BSe8RCiHGLcg6LQ7iIhjAWf9qcXQAf85?= =?us-ascii?Q?8V7/9k2gohgusxWgThEH99vvMudvnDJ8guuGiZO6aiN996Bfhfx3lX+d/vfq?= =?us-ascii?Q?MzJZIl85JkkvG6IALkdw5ydq?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d76a4a72-b819-41b6-fe79-08d9689ba53e X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2230.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 14:13:15.5516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YAWJo22IXZkvx7RJ/6sOMzZHPn4IgdfHod1x+JVcGKgnWml6GBhnlTek2/Yo6iQXGwjDr9id2jBrVBq9WCGDNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1734 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10088 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108260084 X-Proofpoint-GUID: g72-vNwGHNEuJiJmJxpQjP5z9tyrRJK6 X-Proofpoint-ORIG-GUID: g72-vNwGHNEuJiJmJxpQjP5z9tyrRJK6 Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 14:13:28 -0000 On Wed, Aug 25, 2021 at 09:34:41AM -0700, Fangrui Song wrote: > On 2021-08-25, Daniel Kiper wrote: > > On Mon, Aug 23, 2021 at 11:18:38PM -0700, Fangrui Song wrote: > > > Clang does not support -falign-jumps and only recently gained support > > > for -falign-loops. Test all the alignment options to avoid passing > > > unrecognized options to Clang: > > > > > > clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] > > > > > > When compiled with older Clang, the alignment options are not added, so > > > just avoid the complexity for each option. > > > > > > Signed-off-by: Fangrui Song > > > --- > > > configure.ac | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/configure.ac b/configure.ac > > > index 9a12151bd..8625e6776 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -798,8 +798,9 @@ fi > > > > > > # Force no alignment to save space on i386. > > > if test "x$target_cpu" = xi386; then > > > - AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ > > > - CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" > > > + AC_CACHE_CHECK([whether -falign-jumps=1 -falign-loops=1 -falign-functions=1 works], > > > + [grub_cv_cc_falign_loop], [ > > > + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" > > > > I would prefer if you add a separate check for every -falign-* option. > > > > Daniel > > The attached patch checks both -falign-jumps=1 and -falign-loops=1 > From fbef8198d26babeb402b480d333a4a5212069afb Mon Sep 17 00:00:00 2001 > From: Fangrui Song > Date: Wed, 25 Aug 2021 09:28:46 -0700 > Subject: [PATCH] configure: Check -falign-jumps=1 beside -falign-loops=1 > > Clang does not support -falign-jumps and only recently gained support > for -falign-loops. -falign-jumps=1 should be tested beside > -fliang-loops=1 to avoid passing unrecognized options to Clang: > > clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] > > -falign-functions=1 is supported by GCC 5.1.0/Clang 3.8.0, so just add > the option unconditionally. > > Signed-off-by: Fangrui Song > --- > configure.ac | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 9a12151bd..91a6ef128 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -798,6 +798,8 @@ fi > > # Force no alignment to save space on i386. > if test "x$target_cpu" = xi386; then > + TARGET_CFLAGS="$TARGET_CFLAGS -falign-functions=1" > + > AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ > CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" > AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], > @@ -806,7 +808,18 @@ if test "x$target_cpu" = xi386; then > ]) > > if test "x$grub_cv_cc_falign_loop" = xyes; then > - TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1" > + TARGET_CFLAGS="$TARGET_CFLAGS -falign-loops=1" > + fi > + > + AC_CACHE_CHECK([whether -falign-jumps works], [grub_cv_cc_falign_jumps], [ > + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -Werror" > + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], > + [grub_cv_cc_falign_jumps=yes], > + [grub_cv_cc_falign_jumps=no]) It seems to me formatting is broken somehow here. It should be the same like for -falign-loops detection. Otherwise LGTM... Please repost both patches using "git send-email" as v3. You can add Reviewed-by: Daniel Kiper and Paul's Acked-by to the patches before posting. If there are no objections I will merge them and other reviewed patches next week... Daniel