From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0E8C432BE for ; Thu, 26 Aug 2021 14:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB85F61037 for ; Thu, 26 Aug 2021 14:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233156AbhHZOpd (ORCPT ); Thu, 26 Aug 2021 10:45:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbhHZOpc (ORCPT ); Thu, 26 Aug 2021 10:45:32 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 168D5C061757 for ; Thu, 26 Aug 2021 07:44:45 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id n12so1938796plk.10 for ; Thu, 26 Aug 2021 07:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YOjtI3qx0M254KDq+vV2lIwjyICRboqTWxAI+H38ssM=; b=I8xq/NoOFhh/5x68+L8ADT+Ep4HxR1ViP0XuLL7ZbDp0uRZaY9XoQgO3dNXBZr3rae MaH9NQnf0wRzcSqeW8zB3DfopN0uXX+bhyr9mM7CBIwi5yarenXmFOEjk5/WQcxHyX/A JM/NwRBlTWlDN1u4RzQe6Ntz4/e9iXKUj+ZxN2y1kkUFUm+sMb994+Sa9vW0HwNcBlVy Yj27lPEEBhoDhDGrgfzunmYeHh0K24EoRJA/r2eqJz2gGXWa5Vuynf6IgIY0+iTQFl6j +A2nunmksb7jS2/y8g7Qx+dD75oWUANvCqXTTG5UwlTi75/+mWh+tILMd3d2LV/wVtiM oX8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YOjtI3qx0M254KDq+vV2lIwjyICRboqTWxAI+H38ssM=; b=FFZ+tse/wDsQ0EcgIfB1nbSUyuM2R0N8L60smetKqJhZ0iI0yDZnScf/oTY/H2QF3r X4TgFv9KGvj7XafoSgb5y5sCwTTvGhI3GDzLQwlgS3z1VDbrIHQsOu4T6CWQ2DjOmo0v IQPG1j5WuEjhBgKX3w0KJEMpoAciDWcH0AVPn8EIg5Azx/w+mYP+Hvj1YxAu8Q3OMC9L Z92khSBjIQ4N09/B5n0qjw+74Kz8aumZWjLDy2Z+kXWYXLJA4bjfkqU1C964A8SZ/PYN 5P3K+SeSKk5YHbI0v6/xllRm/ar5yotC1quorolbUUICwol6q78xNi3Q/pmehEzuZJcD DgZA== X-Gm-Message-State: AOAM530wFUinGeh5EHNzIU1ddX3XP4EZdHG4YnKA6Gzdry8xvEnhkYOx XrbOB6X9nVcAVttvMDiaVEU= X-Google-Smtp-Source: ABdhPJx8PNlI0Wl9kkfQvrhH73q3j3ItVYoYEgdppEXuoaSVqGar6snGgPjopUwsDXYAr/oHEb98EQ== X-Received: by 2002:a17:90a:c8b:: with SMTP id v11mr16686522pja.114.1629989084595; Thu, 26 Aug 2021 07:44:44 -0700 (PDT) Received: from localhost.localdomain ([59.12.165.26]) by smtp.gmail.com with ESMTPSA id y67sm3390306pfg.218.2021.08.26.07.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 07:44:44 -0700 (PDT) From: Sidong Yang To: David Sterba , Filipe Manana , linux-btrfs , Nikolay Borisov Cc: Sidong Yang Subject: [PATCH v3] btrfs: reflink: Initialize return value to 0 in btrfs_extent_same() Date: Thu, 26 Aug 2021 14:44:36 +0000 Message-Id: <20210826144436.19600-1-realwakka@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org This patch fixes a warning reported by smatch. It reported that ret could be returned without initialized. 0 would be proper value for initializing ret. Because dedupe operations are supposed to to return 0 for a 0 length range. Signed-off-by: Sidong Yang --- v2: - Removed assert and added initializing ret v3: - Changed initializing value to 0 --- fs/btrfs/reflink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/reflink.c b/fs/btrfs/reflink.c index 9b0814318e72..c71e49782e86 100644 --- a/fs/btrfs/reflink.c +++ b/fs/btrfs/reflink.c @@ -649,7 +649,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 len, static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen, struct inode *dst, u64 dst_loff) { - int ret; + int ret = 0; u64 i, tail_len, chunk_count; struct btrfs_root *root_dst = BTRFS_I(dst)->root; -- 2.25.1