From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mike Galbraith <efault@gmx.de>,
linux-rt-users@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] mm, zsmalloc: Convert zsmalloc_handle.lock to spinlock_t
Date: Thu, 26 Aug 2021 16:57:18 +0200 [thread overview]
Message-ID: <20210826145718.3jwe2ndlfu3nveqw@linutronix.de> (raw)
In-Reply-To: <b8a39e05-696a-d459-c651-a3415bc09886@suse.cz>
On 2021-08-24 13:14:52 [+0200], Vlastimil Babka wrote:
> On 8/24/21 13:08, Mike Galbraith wrote:
> >
> > local_lock_t becoming a synonym of spinlock_t had consequences for the RT
> > mods to zsmalloc, which were taking a mutex while holding a local_lock,
> > inspiring a lockdep "BUG: Invalid wait context" gripe.
> >
> > Converting zsmalloc_handle.lock to a spinlock_t restored lockdep silence.
> >
> > Signed-off-by: Mike Galbraith <efault@gmx.de>
>
> BTW, does anyone really run zswap on a RT system?
The bit spinlock is problematic for RT and needs a replacement. Having a
page not available in RT is a no no. But then it might be a good
testcase if mlock() has been setup properly :) But other than that, I
can't imagine a real use case.
I'm going to apply that patch for the time being.
Sebastian
prev parent reply other threads:[~2021-08-26 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 11:08 [patch] mm, zsmalloc: Convert zsmalloc_handle.lock to spinlock_t Mike Galbraith
2021-08-24 11:14 ` Vlastimil Babka
2021-08-24 11:32 ` Mike Galbraith
2021-08-26 14:57 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826145718.3jwe2ndlfu3nveqw@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.