From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123F6C432BE for ; Thu, 26 Aug 2021 15:07:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0D6E60F4C for ; Thu, 26 Aug 2021 15:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242901AbhHZPHv (ORCPT ); Thu, 26 Aug 2021 11:07:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57792 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234068AbhHZPHu (ORCPT ); Thu, 26 Aug 2021 11:07:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629990423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G2Q2x7WOo9oasuIA3XWldpXDoxM+ky2X6T8xE/JmZNk=; b=TX4UMwcV8xbtaUFs76+NebtceXbPeZLv6N1enAp8bPWepjpvefci5jKwaqJ5p+NnshjdT+ 7EuDPHb7vK2pR4w2F2sBcP/maVC7BATsPOI2tash6vNNIakSp+qckaD/ECP7Srwxr6OvG1 2y6mWwD/IpJO6XurLAR1DIj5eHn6Nbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-PCjM7CiCMkOrfpPea-3Y0w-1; Thu, 26 Aug 2021 11:07:01 -0400 X-MC-Unique: PCjM7CiCMkOrfpPea-3Y0w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 182B61853026; Thu, 26 Aug 2021 15:07:00 +0000 (UTC) Received: from redhat.com (ovpn-112-96.phx2.redhat.com [10.3.112.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1F2B5D9FC; Thu, 26 Aug 2021 15:06:54 +0000 (UTC) Date: Thu, 26 Aug 2021 10:06:53 -0500 From: Eric Blake To: isaku.yamahata@gmail.com Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, alistair@alistair23.me, ehabkost@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, cohuck@redhat.com, mtosatti@redhat.com, xiaoyao.li@intel.com, seanjc@google.com, erdemaktas@google.com, isaku.yamahata@intel.com, Sean Christopherson , kvm@vger.kernel.org Subject: Re: [RFC PATCH v2 10/44] hw/i386: Initialize TDX via KVM ioctl() when kvm_type is TDX Message-ID: <20210826150653.3vurw57fluf53cnt@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20210205-739-420e15 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 07, 2021 at 05:54:40PM -0700, isaku.yamahata@gmail.com wrote: > From: Xiaoyao Li > > Introduce tdx_ioctl() to invoke TDX specific sub-ioctls of > KVM_MEMORY_ENCRYPT_OP. Use tdx_ioctl() to invoke KVM_TDX_INIT, by way > of tdx_init(), during kvm_arch_init(). KVM_TDX_INIT configures global > TD state, e.g. the canonical CPUID config, and must be executed prior to > creating vCPUs. > > Note, this doesn't address the fact that Qemu may change the CPUID > configuration when creating vCPUs, i.e. punts on refactoring Qemu to > provide a stable CPUID config prior to kvm_arch_init(). > > Explicitly set subleaf index and flags when adding CPUID > Set the index and flags when adding a CPUID entry to avoid propagating > stale state from a removed entry, e.g. when the CPUID 0x4 loop bails, it > can leave non-zero index and flags in the array. > > Signed-off-by: Xiaoyao Li > Co-developed-by: Sean Christopherson > Signed-off-by: Sean Christopherson > Signed-off-by: Isaku Yamahata > --- > +++ b/qapi/qom.json > @@ -760,6 +760,18 @@ > '*cbitpos': 'uint32', > 'reduced-phys-bits': 'uint32' } } > > +## > +# @TdxGuestProperties: > +# > +# Properties for tdx-guest objects. > +# > +# @debug: enable debug mode (default: off) > +# > +# Since: 6.0 This should be 6.2 > +## > +{ 'struct': 'TdxGuestProperties', > + 'data': { '*debug': 'bool' } } > + > ## > # @ObjectType: > # > @@ -802,6 +814,7 @@ > 'secret_keyring', > 'sev-guest', > 's390-pv-guest', > + 'tdx-guest', > 'throttle-group', > 'tls-creds-anon', > 'tls-creds-psk', > @@ -858,6 +871,7 @@ > 'secret': 'SecretProperties', > 'secret_keyring': 'SecretKeyringProperties', > 'sev-guest': 'SevGuestProperties', > + 'tdx-guest': 'TdxGuestProperties', > 'throttle-group': 'ThrottleGroupProperties', > 'tls-creds-anon': 'TlsCredsAnonProperties', > 'tls-creds-psk': 'TlsCredsPskProperties', -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0E9C432BE for ; Thu, 26 Aug 2021 15:08:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0217860F21 for ; Thu, 26 Aug 2021 15:08:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0217860F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:35998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJGzR-00077H-3p for qemu-devel@archiver.kernel.org; Thu, 26 Aug 2021 11:08:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJGyD-0006QD-Lg for qemu-devel@nongnu.org; Thu, 26 Aug 2021 11:07:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJGy8-0004H6-Tt for qemu-devel@nongnu.org; Thu, 26 Aug 2021 11:07:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629990423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G2Q2x7WOo9oasuIA3XWldpXDoxM+ky2X6T8xE/JmZNk=; b=TX4UMwcV8xbtaUFs76+NebtceXbPeZLv6N1enAp8bPWepjpvefci5jKwaqJ5p+NnshjdT+ 7EuDPHb7vK2pR4w2F2sBcP/maVC7BATsPOI2tash6vNNIakSp+qckaD/ECP7Srwxr6OvG1 2y6mWwD/IpJO6XurLAR1DIj5eHn6Nbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-PCjM7CiCMkOrfpPea-3Y0w-1; Thu, 26 Aug 2021 11:07:01 -0400 X-MC-Unique: PCjM7CiCMkOrfpPea-3Y0w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 182B61853026; Thu, 26 Aug 2021 15:07:00 +0000 (UTC) Received: from redhat.com (ovpn-112-96.phx2.redhat.com [10.3.112.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1F2B5D9FC; Thu, 26 Aug 2021 15:06:54 +0000 (UTC) Date: Thu, 26 Aug 2021 10:06:53 -0500 From: Eric Blake To: isaku.yamahata@gmail.com Subject: Re: [RFC PATCH v2 10/44] hw/i386: Initialize TDX via KVM ioctl() when kvm_type is TDX Message-ID: <20210826150653.3vurw57fluf53cnt@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20210205-739-420e15 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: isaku.yamahata@intel.com, cohuck@redhat.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, seanjc@google.com, alistair@alistair23.me, xiaoyao.li@intel.com, qemu-devel@nongnu.org, Sean Christopherson , mtosatti@redhat.com, erdemaktas@google.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 07, 2021 at 05:54:40PM -0700, isaku.yamahata@gmail.com wrote: > From: Xiaoyao Li > > Introduce tdx_ioctl() to invoke TDX specific sub-ioctls of > KVM_MEMORY_ENCRYPT_OP. Use tdx_ioctl() to invoke KVM_TDX_INIT, by way > of tdx_init(), during kvm_arch_init(). KVM_TDX_INIT configures global > TD state, e.g. the canonical CPUID config, and must be executed prior to > creating vCPUs. > > Note, this doesn't address the fact that Qemu may change the CPUID > configuration when creating vCPUs, i.e. punts on refactoring Qemu to > provide a stable CPUID config prior to kvm_arch_init(). > > Explicitly set subleaf index and flags when adding CPUID > Set the index and flags when adding a CPUID entry to avoid propagating > stale state from a removed entry, e.g. when the CPUID 0x4 loop bails, it > can leave non-zero index and flags in the array. > > Signed-off-by: Xiaoyao Li > Co-developed-by: Sean Christopherson > Signed-off-by: Sean Christopherson > Signed-off-by: Isaku Yamahata > --- > +++ b/qapi/qom.json > @@ -760,6 +760,18 @@ > '*cbitpos': 'uint32', > 'reduced-phys-bits': 'uint32' } } > > +## > +# @TdxGuestProperties: > +# > +# Properties for tdx-guest objects. > +# > +# @debug: enable debug mode (default: off) > +# > +# Since: 6.0 This should be 6.2 > +## > +{ 'struct': 'TdxGuestProperties', > + 'data': { '*debug': 'bool' } } > + > ## > # @ObjectType: > # > @@ -802,6 +814,7 @@ > 'secret_keyring', > 'sev-guest', > 's390-pv-guest', > + 'tdx-guest', > 'throttle-group', > 'tls-creds-anon', > 'tls-creds-psk', > @@ -858,6 +871,7 @@ > 'secret': 'SecretProperties', > 'secret_keyring': 'SecretKeyringProperties', > 'sev-guest': 'SevGuestProperties', > + 'tdx-guest': 'TdxGuestProperties', > 'throttle-group': 'ThrottleGroupProperties', > 'tls-creds-anon': 'TlsCredsAnonProperties', > 'tls-creds-psk': 'TlsCredsPskProperties', -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org