All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] kcsan: Make it RT aware
Date: Thu, 26 Aug 2021 17:48:33 +0200	[thread overview]
Message-ID: <20210826154833.gu45q5hduypwgyce@linutronix.de> (raw)
In-Reply-To: <f6c40d238a1990a4649ec848a67aae88846505ab.camel@gmx.de>

On 2021-08-26 17:42:21 [+0200], Mike Galbraith wrote:
> On Thu, 2021-08-26 at 17:18 +0200, Sebastian Andrzej Siewior wrote:
> > On 2021-08-22 19:29:00 [+0200], Vlastimil Babka wrote:
> > > On 8/22/21 6:35 PM, Mike Galbraith wrote:
> > > > On second thought, burn both patches.  Making K[AC]SAN work with RT
> > > > ain't worth the warts.
> > >
> > > The stackdepot part of kasan patch will be useful at some point.
> > > slub_debug should eventually switch to stackdepot - it almost did in
> > > mainline already. I'll try to remember and dig that part up when
> > > needed.
> > > Thanks.
> >
> > If you want them dropped, sure.
> 
> If you think they're worth having, feel free.  The kcsan patch I found
> especially icky, and changed it like so, avoiding icky config dependent
> branches while giving myself an ever so tiny excuse for looping ;-)
> 
> kcsan: Make it RT aware
> 
> Converting report_filterlist_lock to raw_spinlock_t lets RT report
> problem free, but makes allocations in insert_report_filterlist()
> problematic.  Solve that by taking the lock after allocation.  That
> means all configs must check that the situation didn't change while
> acquiring if we're to avoid ugly config specific branches, but it
> also removes the need for GFP_ATOMIC allocations.
> 
> Signed-off-by: Mike Galbraith <efault@gmx.de>

I would have to look at this raw lock change now more closely…

Sebastian

      reply	other threads:[~2021-08-26 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21  6:50 [patch] kcsan: Make it RT aware Mike Galbraith
2021-08-22 16:35 ` Mike Galbraith
2021-08-22 17:29   ` Vlastimil Babka
2021-08-26 15:18     ` Sebastian Andrzej Siewior
2021-08-26 15:42       ` Mike Galbraith
2021-08-26 15:48         ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210826154833.gu45q5hduypwgyce@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=efault@gmx.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.