From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mJNY1-0003sk-KN for mharc-grub-devel@gnu.org; Thu, 26 Aug 2021 18:08:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJNY0-0003sc-Fh for grub-devel@gnu.org; Thu, 26 Aug 2021 18:08:32 -0400 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]:36377) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJNXx-0001S0-Uj for grub-devel@gnu.org; Thu, 26 Aug 2021 18:08:32 -0400 Received: by mail-qt1-x832.google.com with SMTP id t32so3814142qtc.3 for ; Thu, 26 Aug 2021 15:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=Ahyy6ttaM9kTJPZoYXp+9h9R8CX4eYW1V6sABNdHSBg=; b=SUlIQ5KYo25YSoKIY89S/vlLB4E6yWfvV3U/sMaM3qcp+idMnPbb6gVGSZTQzxnKWy FfP6fvzjIYZprhL1oF1VS8npcomI8tkWdLP+ZImGv2ZbQL5fGDUaAJ4YDqqfrIUQRYJ8 IELUtON9K4YyeyQb5oA7pTSfIvqhKNkTZDHiPZZG++EQAz2/fBQD4umQ0fpGXW46HqAK 6eAhnn5pL0ygovl6FMNiUUF34qupssnR3WRfZH6YikEz/w4RkoYAipBMysZyJZWbBBWS dhIMPDLPgF9f8myCj6AE/LGVFwAHm4ma7V1vs8uX27He7XZSNTrKBGNtb8/K6UUYjmyV kivw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=Ahyy6ttaM9kTJPZoYXp+9h9R8CX4eYW1V6sABNdHSBg=; b=UcxTDq0zsBCa7F5blen/8w376HBfT7efkbL2vyk4SJkkalhy9S9uakAbCBL7H58GVl xFYEhOQb5O8cP6rM0i4xNw+WlE/ZGSf/p7kTNDW3M7JzsrpsM0C8iiUlskFh9ILKzGJk B5xlAv5KuoFMzFL3jZGlKFGn8FzooQkIEWj+RcffnW3gG4QISB853B33eq0fKDn/XHk1 rfy9AZerj9KBsCMv3mJX1XT3gjUNvjDQzH/UwIs89VMRARncA1ocARo7rKXFEKqo4VFq 2tk1z6VR27g0ypE6T3gBVGD3bgLb4ceR8z344yR6FZyqZrGT7QIbNMJ2ac1md1o9jQp4 9+GQ== X-Gm-Message-State: AOAM531ncGIqaLPAEYpZcQ646vQ+s3swNk2ywRM2wywf6fy9rZ1JQ8ud eUiH8PuNf/hdkT4nmSJ8/bbMAA== X-Google-Smtp-Source: ABdhPJyOf1P5s0NGdAQ4aB/OsLy0awXZWKtAz0uk6+Fhy1ccWI0fxR/PpgOaaQYm8GkYbXWrQeCR5g== X-Received: by 2002:a05:622a:138c:: with SMTP id o12mr5545829qtk.346.1630015708663; Thu, 26 Aug 2021 15:08:28 -0700 (PDT) Received: from crass-HP-ZBook-15-G2 ([199.58.83.11]) by smtp.gmail.com with ESMTPSA id n20sm3487754qkk.135.2021.08.26.15.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 15:08:28 -0700 (PDT) Date: Thu, 26 Aug 2021 17:08:21 -0500 From: Glenn Washburn To: Daniel Kiper Cc: grub-devel@gnu.org Subject: Re: [PATCH 00/12] Grub-shell improvements Message-ID: <20210826170821.040d202b@crass-HP-ZBook-15-G2> In-Reply-To: <20210826180032.qf7z5ybrizro3wdt@tomti.i.net-space.pl> References: <20210825180630.5378bb5c@crass-HP-ZBook-15-G2> <20210826180032.qf7z5ybrizro3wdt@tomti.i.net-space.pl> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=development@efficientek.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 22:08:32 -0000 Hi Daniel, On Thu, 26 Aug 2021 20:00:32 +0200 Daniel Kiper wrote: > Hi Glenn, > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > What are the chances this patch series can be reviewed in the near > > future? Some feedback would be greatly appreciated. > > I can see the following patches from you waiting in my review queue: > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for > cryptodisks+luks2 and a few other things. > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html > - [PATCH 0/5] Testing improvements > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html > - [CI 00/17] Gitlab CI and test framework improvements > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html > - [PROCFS 0/5] Add and improve (proc) entries > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html > - [PATCH 0/4] Various LUKS2 improvements > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html > - [PATCH] fs: Allow number of blocks in block list to be optional, > defaulting length to device length > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > dash-insensitive manner > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html > - [PATCH] command: Add silent mode to read command to suppress > input echo > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > - [PATCH 0/2] Allow overriding commands > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html > - [PATCH 00/12] Grub-shell improvements > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html > - [PATCH v2 0/8] Various fixes/improvements for tests > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > modules > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > Please sort them in the order of importance/preference/... Then I > will be looking at them (more or less) in that order, one patch set > at a time. > > I hope I did not miss any of your patches. As far as I can tell, this is the full list. My order preference is as follows: These two patches are only first because it should be a quick review. - [PATCH] command: Add silent mode to read command to suppress input echo https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html - [PATCH] fs: Allow number of blocks in block list to be optional, defaulting length to device length https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html This is a high priority because I think it should be merged before the keyfile and detached header support patch series. If this is merged, I'll submit and updated keyfile and detached header patch series that works with this patch series. - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto modules https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html Based on discussion with Thomas Schmitt, I think the first patch of this series should be dropped. Should I make a v3, or would you review it and if acceptable drop the first patch? - [PATCH v2 0/8] Various fixes/improvements for tests https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html Then these in this order. - [PATCH 00/12] Grub-shell improvements https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html - [PATCH 0/4] Various LUKS2 improvements https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html - [PROCFS 0/5] Add and improve (proc) entries https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html - [PATCH 0/2] Allow overriding commands https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html ==================================================================== Patch series with dependencies This patch series requires keyfile support via the -k argument for cryptomount. So it must be reviewed after a patch series implementing this. Also, iirc, this series relies on "Grub-shell improvements". Ideally this would get reviewed soon after its prerequisites get merged, so that we can be testing LUKS support. I'll probably also need to update it for changes, so let's hold off on this until I resubmit an updated version. - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html ==================================================================== Excluded/Discarded patch series I'm excluding the following patch series because most of it has already been accepted or is in one of the above patch series. So no need to review this one. - [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2 and a few other things. https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html Likewise this patch series is mostly a subset of "Various fixes/improvements for tests", and can be discarded. - [PATCH 0/5] Testing improvements https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html This patch series is the patch series "Testing improvements" combined with "Grub-shell improvements" with the CI patch on top. It makes sense to first deal with the patch series as separate, then the CI patch, which I'll submit at a later date. So let's ignore this one also. - [CI 00/17] Gitlab CI and test framework improvements https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html Much appreciated, Glenn