From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB520C432BE for ; Fri, 27 Aug 2021 04:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C5C560FC2 for ; Fri, 27 Aug 2021 04:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233131AbhH0ENy (ORCPT ); Fri, 27 Aug 2021 00:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbhH0ENy (ORCPT ); Fri, 27 Aug 2021 00:13:54 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E068AC061757 for ; Thu, 26 Aug 2021 21:13:05 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id mq3so3658766pjb.5 for ; Thu, 26 Aug 2021 21:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2crkDDVovoRCpVLHwusC/Etpp4MlaRIcgmloNRwz3ZA=; b=bnW+rlLr9u57Q4BBgt2wYSvPUvC9w71Jmv9CwQQxjc91Wp4Z+Ag0ASFr3DC7N5TxHh JZTAMGm16qdadxA0leOZSlXWk8wDxRIdLblaYjr4NvJzP/L8hgagsQK/UzrA/dfres2u aRD5fBDT4YS71ZAcVYuh2KOGut5wSM5YxX/hj2nDlycdU9UA18VByDNWH5YT7SN/32fr S0Rcx8hbRDXKlQgtXtX8Fv4H2Q0vazoT8aHnABGUEQ6LSVeR5pks138suIfTfl4i3ps9 ou67TuGMp2/Ruk9J16WaGYbJNzBAnc2yvOLeyrJhJYnG1hDVseHIttw661aja2oqKAQT Eaug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2crkDDVovoRCpVLHwusC/Etpp4MlaRIcgmloNRwz3ZA=; b=YmI4WJLxtuS4ExlHjL7dpiNgYE2zk7ejeyQD3s1SMaT48SBrhSyV7yq8RzVe2O829G 4wkPxzbDEX+n95ZVs0yMYHd950D76c+YgquiH9TikKw+jmsVlx9WWgsHI6ulEVM8iw5M zWFU2p1YGiHbfz9LJ2q7asuKfQswCxu2cevFPiE0A8RW4u31lyF25hcp66FUZ0vBUyyr cbgdfHi+JjYJ/ko+3Vsl+BMs2fPNVZTXn3zq1GLhlY46RrCaEb1DeCcploH0mx8prETu vMSwj6k+kH1oNAWs2mvjQnz89UtXUbzNRGsCwrJ48WXCoxfPQRno1uvRI/RCdHc6QcFb qegQ== X-Gm-Message-State: AOAM5320PTjumPY3RTHJkQBKcEeOra/5kaSh42pqWkyPNJXms4qfp7x4 aG7fwh4r/26p+McYTdJFmqoWTw== X-Google-Smtp-Source: ABdhPJwxaRyy57tJuvxS009YryGtF88eBYjzRhV5X9ukzyaCKAtLMwVIZ6JW1GGf/e3dlFh4bngtKQ== X-Received: by 2002:a17:90a:420c:: with SMTP id o12mr8239511pjg.101.1630037585353; Thu, 26 Aug 2021 21:13:05 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id i14sm4459212pfd.112.2021.08.26.21.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 21:13:04 -0700 (PDT) Date: Fri, 27 Aug 2021 09:43:03 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Viresh Kumar , Stephen Boyd , Nishanth Menon , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v9 5/8] soc/tegra: pmc: Implement get_performance_state() callback Message-ID: <20210827041303.5rz6xcyc2bo75tbr@vireshk-i7> References: <20210827013415.24027-1-digetx@gmail.com> <20210827013415.24027-6-digetx@gmail.com> <20210827030557.aymjkky7athjxpow@vireshk-i7> <9c2287ca-4c51-d782-a0a5-4b1227c2e9db@gmail.com> <7aca6da3-89a7-a4a6-c720-8be4a105a696@gmail.com> <20210827040239.roal5jpndamzotle@vireshk-i7> <4a945d40-b30a-8a30-bdf8-4e17ad26cea7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a945d40-b30a-8a30-bdf8-4e17ad26cea7@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 27-08-21, 07:08, Dmitry Osipenko wrote: > 27.08.2021 07:02, Viresh Kumar пишет: > > On 27-08-21, 06:47, Dmitry Osipenko wrote: > >> Actually, it doesn't work. > >> > >> The devm_tegra_core_dev_init_opp_table() needs to set clk to support older device-tree and now OPP table already has clk being set. > >> > >> WARNING: CPU: 2 PID: 92 at drivers/opp/core.c:2146 dev_pm_opp_set_clkname+0x97/0xb8 > >> Modules linked in: > >> CPU: 2 PID: 92 Comm: kworker/u8:1 Tainted: G W 5.14.0-rc7-next-20210826-00181-g6389463cbb0a #9318 > >> Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) > >> Workqueue: events_unbound deferred_probe_work_func > >> [] (unwind_backtrace) from [] (show_stack+0x11/0x14) > >> [] (show_stack) from [] (dump_stack_lvl+0x2b/0x34) > >> [] (dump_stack_lvl) from [] (__warn+0xbb/0x100) > >> [] (__warn) from [] (warn_slowpath_fmt+0x4b/0x80) > >> [] (warn_slowpath_fmt) from [] (dev_pm_opp_set_clkname+0x97/0xb8) > >> [] (dev_pm_opp_set_clkname) from [] (devm_pm_opp_set_clkname+0xf/0x64) > >> [] (devm_pm_opp_set_clkname) from [] (devm_tegra_core_dev_init_opp_table+0x23/0x144) > > > > Why are you calling this anymore ? > > Older device-trees don't have OPPs, meanwhile drivers will use > dev_pm_opp_set_rate() and it requires OPP table to be set up using > devm_pm_opp_set_clkname(). > > The devm_tegra_core_dev_init_opp_table() is a common helper that sets up > OPP table for Tegra drivers and it sets the clk. Ahh, I see. that's okay then. Just add a comment over it to specify the same. Doing devm_pm_opp_set_clkname(dev, NULL) is special and looks suspicious otherwise. -- viresh