All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v16 03/14] counter: Internalize sysfs interface code
Date: Fri, 27 Aug 2021 22:09:17 +0800	[thread overview]
Message-ID: <202108272232.mkUcPWed-lkp@intel.com> (raw)
In-Reply-To: <c68b4a1ffb195c1a2f65e8dd5ad7b7c14e79c6ef.1630031207.git.vilhelm.gray@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5259 bytes --]

Hi William,

I love your patch! Yet something to improve:

[auto build test ERROR on 5ffeb17c0d3dd44704b4aee83e297ec07666e4d6]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20210827-115154
base:   5ffeb17c0d3dd44704b4aee83e297ec07666e4d6
config: i386-randconfig-c001-20210827 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/4eb2e2f3fe9da9dddf9d8bbb82ff16b1329131ce
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20210827-115154
        git checkout 4eb2e2f3fe9da9dddf9d8bbb82ff16b1329131ce
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/counter/intel-qep.o: in function `intel_qep_spike_filter_ns_write':
>> drivers/counter/intel-qep.c:290: undefined reference to `__udivdi3'


vim +290 drivers/counter/intel-qep.c

b711f687a1c1c1 Jarkko Nikula          2021-06-02  275  
4eb2e2f3fe9da9 William Breathitt Gray 2021-08-27  276  static int intel_qep_spike_filter_ns_write(struct counter_device *counter,
b711f687a1c1c1 Jarkko Nikula          2021-06-02  277  					   struct counter_count *count,
4eb2e2f3fe9da9 William Breathitt Gray 2021-08-27  278  					   u64 length)
b711f687a1c1c1 Jarkko Nikula          2021-06-02  279  {
b711f687a1c1c1 Jarkko Nikula          2021-06-02  280  	struct intel_qep *qep = counter->priv;
4eb2e2f3fe9da9 William Breathitt Gray 2021-08-27  281  	u32 reg;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  282  	bool enable;
4eb2e2f3fe9da9 William Breathitt Gray 2021-08-27  283  	int ret = 0;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  284  
b711f687a1c1c1 Jarkko Nikula          2021-06-02  285  	/*
b711f687a1c1c1 Jarkko Nikula          2021-06-02  286  	 * Spike filter length is (MAX_COUNT + 2) clock periods.
b711f687a1c1c1 Jarkko Nikula          2021-06-02  287  	 * Disable filter when userspace writes 0, enable for valid
b711f687a1c1c1 Jarkko Nikula          2021-06-02  288  	 * nanoseconds values and error out otherwise.
b711f687a1c1c1 Jarkko Nikula          2021-06-02  289  	 */
b711f687a1c1c1 Jarkko Nikula          2021-06-02 @290  	length /= INTEL_QEP_CLK_PERIOD_NS;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  291  	if (length == 0) {
b711f687a1c1c1 Jarkko Nikula          2021-06-02  292  		enable = false;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  293  		length = 0;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  294  	} else if (length >= 2) {
b711f687a1c1c1 Jarkko Nikula          2021-06-02  295  		enable = true;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  296  		length -= 2;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  297  	} else {
b711f687a1c1c1 Jarkko Nikula          2021-06-02  298  		return -EINVAL;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  299  	}
b711f687a1c1c1 Jarkko Nikula          2021-06-02  300  
b711f687a1c1c1 Jarkko Nikula          2021-06-02  301  	if (length > INTEL_QEPFLT_MAX_COUNT(length))
e2ff3198c580a3 William Breathitt Gray 2021-08-03  302  		return -ERANGE;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  303  
b711f687a1c1c1 Jarkko Nikula          2021-06-02  304  	mutex_lock(&qep->lock);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  305  	if (qep->enabled) {
b711f687a1c1c1 Jarkko Nikula          2021-06-02  306  		ret = -EBUSY;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  307  		goto out;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  308  	}
b711f687a1c1c1 Jarkko Nikula          2021-06-02  309  
b711f687a1c1c1 Jarkko Nikula          2021-06-02  310  	pm_runtime_get_sync(qep->dev);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  311  	reg = intel_qep_readl(qep, INTEL_QEPCON);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  312  	if (enable)
b711f687a1c1c1 Jarkko Nikula          2021-06-02  313  		reg |= INTEL_QEPCON_FLT_EN;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  314  	else
b711f687a1c1c1 Jarkko Nikula          2021-06-02  315  		reg &= ~INTEL_QEPCON_FLT_EN;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  316  	intel_qep_writel(qep, INTEL_QEPFLT, length);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  317  	intel_qep_writel(qep, INTEL_QEPCON, reg);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  318  	pm_runtime_put(qep->dev);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  319  
b711f687a1c1c1 Jarkko Nikula          2021-06-02  320  out:
b711f687a1c1c1 Jarkko Nikula          2021-06-02  321  	mutex_unlock(&qep->lock);
b711f687a1c1c1 Jarkko Nikula          2021-06-02  322  	return ret;
b711f687a1c1c1 Jarkko Nikula          2021-06-02  323  }
b711f687a1c1c1 Jarkko Nikula          2021-06-02  324  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29020 bytes --]

  reply	other threads:[~2021-08-27 14:09 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27  3:47 [PATCH v16 00/14] Introduce the Counter character device interface William Breathitt Gray
2021-08-27  3:47 ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 01/14] counter: stm32-lptimer-cnt: Provide defines for clock polarities William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-31 13:38   ` Fabrice Gasnier
2021-08-31 13:38     ` Fabrice Gasnier
2021-09-08 17:31     ` Jonathan Cameron
2021-09-08 17:31       ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 02/14] counter: stm32-timer-cnt: Provide defines for slave mode selection William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-31 13:40   ` Fabrice Gasnier
2021-08-31 13:40     ` Fabrice Gasnier
2021-09-08 17:31     ` Jonathan Cameron
2021-09-08 17:31       ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 03/14] counter: Internalize sysfs interface code William Breathitt Gray
2021-08-27 14:09   ` kernel test robot [this message]
2021-08-28  4:56   ` kernel test robot
2021-08-31 13:44   ` [Linux-stm32] " Fabrice Gasnier
2021-08-31 14:16     ` William Breathitt Gray
2021-08-31 14:16       ` William Breathitt Gray
2021-08-31 14:55       ` William Breathitt Gray
2021-08-31 14:55         ` William Breathitt Gray
2021-09-08 17:44     ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 04/14] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-09-08 17:46   ` Jonathan Cameron
2021-09-08 17:46     ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 05/14] docs: counter: Update " William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-09-08 17:48   ` Jonathan Cameron
2021-09-08 17:48     ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 06/14] counter: Move counter enums to uapi header William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 07/14] counter: Add character device interface William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-09-12 16:18   ` Jonathan Cameron
2021-09-12 16:18     ` Jonathan Cameron
2021-09-20 10:09     ` William Breathitt Gray
2021-09-20 10:09       ` William Breathitt Gray
2021-09-26 15:15       ` Jonathan Cameron
2021-09-26 15:15         ` Jonathan Cameron
2021-09-27 10:21         ` William Breathitt Gray
2021-09-27 10:21           ` William Breathitt Gray
2021-09-27 11:20           ` Jonathan Cameron
2021-09-27 11:20             ` Jonathan Cameron
2021-09-27 11:33             ` William Breathitt Gray
2021-09-27 11:33               ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 08/14] docs: counter: Document " William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-09-12 16:18   ` Jonathan Cameron
2021-09-12 16:18     ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 09/14] tools/counter: Create Counter tools William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-09-12 16:26   ` Jonathan Cameron
2021-09-12 16:26     ` Jonathan Cameron
2021-08-27  3:47 ` [PATCH v16 10/14] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 11/14] counter: Implement *_component_id sysfs attributes William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 12/14] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 13/14] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-27  3:47 ` [PATCH v16 14/14] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-08-27  3:47   ` William Breathitt Gray
2021-08-30 17:17 ` [PATCH v16 00/14] Introduce the Counter character device interface Jonathan Cameron
2021-08-30 17:17   ` Jonathan Cameron
2021-09-12 16:36   ` Jonathan Cameron
2021-09-12 16:36     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108272232.mkUcPWed-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.