All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: roopa@nvidia.com, dsahern@gmail.com, stephen@networkplumber.org,
	Joachim Wiberg <troglobit@gmail.com>,
	Nikolay Aleksandrov <nikolay@nvidia.com>
Subject: [PATCH iproute2-next v2 10/19] bridge: vlan: add global mcast_last_member_count option
Date: Sat, 28 Aug 2021 14:07:56 +0300	[thread overview]
Message-ID: <20210828110805.463429-11-razor@blackwall.org> (raw)
In-Reply-To: <20210828110805.463429-1-razor@blackwall.org>

From: Nikolay Aleksandrov <nikolay@nvidia.com>

Add control and dump support for the global mcast_last_member_count option
which controls the number of queries the bridge will send on the vlan after
a leave is received (default 2).
Syntax:
 $ bridge vlan global set dev bridge vid 1 mcast_last_member_count 10

Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
---
v2: adjust help msg alignment to fit in 100 columns

 bridge/vlan.c     | 15 +++++++++++++++
 man/man8/bridge.8 | 10 +++++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/bridge/vlan.c b/bridge/vlan.c
index aa6fbef27b06..479574ca38e5 100644
--- a/bridge/vlan.c
+++ b/bridge/vlan.c
@@ -42,6 +42,7 @@ static void usage(void)
 		"                      [ mcast_snooping MULTICAST_SNOOPING ]\n"
 		"                      [ mcast_igmp_version IGMP_VERSION ]\n"
 		"                      [ mcast_mld_version MLD_VERSION ]\n"
+		"                      [ mcast_last_member_count LAST_MEMBER_COUNT ]\n"
 		"       bridge vlan global { show } [ dev DEV ] [ vid VLAN_ID ]\n");
 	exit(-1);
 }
@@ -359,6 +360,7 @@ static int vlan_global_option_set(int argc, char **argv)
 	short vid_end = -1;
 	char *d = NULL;
 	short vid = -1;
+	__u32 val32;
 	__u8 val8;
 
 	afspec = addattr_nest(&req.n, sizeof(req),
@@ -420,6 +422,13 @@ static int vlan_global_option_set(int argc, char **argv)
 				invarg("invalid mcast_mld_version", *argv);
 			addattr8(&req.n, 1024,
 				 BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION, val8);
+		} else if (strcmp(*argv, "mcast_last_member_count") == 0) {
+			NEXT_ARG();
+			if (get_u32(&val32, *argv, 0))
+				invarg("invalid mcast_last_member_count", *argv);
+			addattr32(&req.n, 1024,
+				  BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT,
+				  val32);
 		} else {
 			if (matches(*argv, "help") == 0)
 				NEXT_ARG();
@@ -768,6 +777,12 @@ static void print_vlan_global_opts(struct rtattr *a, int ifindex)
 		print_uint(PRINT_ANY, "mcast_mld_version",
 			   "mcast_mld_version %u ", rta_getattr_u8(vattr));
 	}
+	if (vtb[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]) {
+		vattr = vtb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT];
+		print_uint(PRINT_ANY, "mcast_last_member_count",
+			   "mcast_last_member_count %u ",
+			   rta_getattr_u32(vattr));
+	}
 	print_nl();
 	close_json_object();
 }
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index dcbff9367334..cea755184336 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -163,7 +163,9 @@ bridge \- show / manipulate bridge addresses and devices
 .B mcast_igmp_version
 .IR IGMP_VERSION " ] [ "
 .B mcast_mld_version
-.IR MLD_VERSION " ]"
+.IR MLD_VERSION " ] [ "
+.B mcast_last_member_count
+.IR LAST_MEMBER_COUNT " ]"
 
 .ti -8
 .BR "bridge vlan global" " [ " show " ] [ "
@@ -943,6 +945,12 @@ set the IGMP version. Default is 2.
 .BI mcast_mld_version " MLD_VERSION "
 set the MLD version. Default is 1.
 
+.TP
+.BI mcast_last_member_count " LAST_MEMBER_COUNT "
+set multicast last member count, ie the number of queries the bridge
+will send before stopping forwarding a multicast group after a "leave"
+message has been received. Default is 2.
+
 .SS bridge vlan global show - list global vlan options.
 
 This command displays the global VLAN options for each VLAN entry.
-- 
2.31.1


  parent reply	other threads:[~2021-08-28 11:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 11:07 [PATCH iproute2-next v2 00/19] bridge: vlan: add global multicast options Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 01/19] ip: bridge: add support for mcast_vlan_snooping Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 02/19] bridge: vlan: factor out vlan option printing Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 03/19] bridge: vlan: skip unknown attributes when printing options Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 04/19] bridge: vlan: add support to show global vlan options Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 05/19] bridge: vlan: add support for vlan filtering when dumping options Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 06/19] bridge: vlan: add support to set global vlan options Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 07/19] bridge: vlan: add global mcast_snooping option Nikolay Aleksandrov
2021-09-01  3:36   ` David Ahern
2021-09-01  8:07     ` Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 08/19] bridge: vlan: add global mcast_igmp_version option Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 09/19] bridge: vlan: add global mcast_mld_version option Nikolay Aleksandrov
2021-08-28 11:07 ` Nikolay Aleksandrov [this message]
2021-08-28 11:07 ` [PATCH iproute2-next v2 11/19] bridge: vlan: add global mcast_startup_query_count option Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 12/19] bridge: vlan: add global mcast_last_member_interval option Nikolay Aleksandrov
2021-08-28 11:07 ` [PATCH iproute2-next v2 13/19] bridge: vlan: add global mcast_membership_interval option Nikolay Aleksandrov
2021-08-28 11:08 ` [PATCH iproute2-next v2 14/19] bridge: vlan: add global mcast_querier_interval option Nikolay Aleksandrov
2021-08-28 11:08 ` [PATCH iproute2-next v2 15/19] bridge: vlan: add global mcast_query_interval option Nikolay Aleksandrov
2021-08-28 11:08 ` [PATCH iproute2-next v2 16/19] bridge: vlan: add global mcast_query_response_interval option Nikolay Aleksandrov
2021-08-28 11:08 ` [PATCH iproute2-next v2 17/19] bridge: vlan: add global mcast_startup_query_interval option Nikolay Aleksandrov
2021-08-28 11:08 ` [PATCH iproute2-next v2 18/19] bridge: vlan: add global mcast_querier option Nikolay Aleksandrov
2021-08-28 11:08 ` [PATCH iproute2-next v2 19/19] bridge: vlan: add support for dumping router ports Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210828110805.463429-11-razor@blackwall.org \
    --to=razor@blackwall.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=troglobit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.