From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-iio-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A162BC4320A
	for <linux-iio@archiver.kernel.org>; Sun, 29 Aug 2021 16:02:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 75D4E60E73
	for <linux-iio@archiver.kernel.org>; Sun, 29 Aug 2021 16:02:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235221AbhH2QDF (ORCPT <rfc822;linux-iio@archiver.kernel.org>);
        Sun, 29 Aug 2021 12:03:05 -0400
Received: from mail.kernel.org ([198.145.29.99]:43388 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S235167AbhH2QDF (ORCPT <rfc822;linux-iio@vger.kernel.org>);
        Sun, 29 Aug 2021 12:03:05 -0400
Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 431D060F42;
        Sun, 29 Aug 2021 16:02:10 +0000 (UTC)
Date:   Sun, 29 Aug 2021 17:05:25 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Jacopo Mondi <jacopo@jmondi.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Matt Ranostay <matt.ranostay@konsulko.com>,
        linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: chemical: Add Senseair Sunrise 006-0-007
 driver
Message-ID: <20210829170525.2e84dac1@jic23-huawei>
In-Reply-To: <20210818080213.d56phfmjlwbgzlca@uno.localdomain>
References: <20210817154951.50208-1-jacopo@jmondi.org>
        <20210817154951.50208-3-jacopo@jmondi.org>
        <YRvqvt4qVVe1+K1/@smile.fi.intel.com>
        <20210818080213.d56phfmjlwbgzlca@uno.localdomain>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-iio.vger.kernel.org>
X-Mailing-List: linux-iio@vger.kernel.org


> Ack
> 
> > > +			ret = sunrise_read_co2_filtered(client, &co2);
> > > +			*val = co2;
> > > +			mutex_unlock(&sunrise->lock);
> > > +
> > > +			return ret ? ret : IIO_VAL_INT;  
> >
> > Can be written as
> >
> > 			return ret ?: IIO_VAL_INT;
> >
> > but up to maintainers.
> >  
> 
> You know I never saw this syntax before ? :D
> I'll use it!
I'm rather late to the party, but I'd keep all error handling in driver of the form

	if (ret)
		return ret;

	return IIO_VAL_INT;

That means lazy reviewers like me have one less thing to think about ;)