From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1928C4320E for ; Mon, 30 Aug 2021 09:12:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C83356101B for ; Mon, 30 Aug 2021 09:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234714AbhH3JNF (ORCPT ); Mon, 30 Aug 2021 05:13:05 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:47876 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235496AbhH3JNE (ORCPT ); Mon, 30 Aug 2021 05:13:04 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 56B3B22107; Mon, 30 Aug 2021 09:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630314730; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nywd0oz6iwwHwglHPbyfAVv9NJlMdcowHwWK98LNbhY=; b=lffSWkpWgFlYo+ZZM06LAjRDIY5hi3nsHxp8I8HExonKk5tXEZT5IYAPnn1X3QghJbBNeE qyHE9DDsETENNM0pWho6lb8RIB/O5MxI3x3o0bPdAmP3RY7sJIGAsSOBk/820h5BSTnrrS /t2QDjpvXH3Xf5ebqgUZbXx8r8PE7aE= Received: from suse.com (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id CFF69A3B9C; Mon, 30 Aug 2021 09:12:09 +0000 (UTC) Date: Mon, 30 Aug 2021 10:12:08 +0100 From: Mel Gorman To: NeilBrown Cc: Chuck Lever III , Mike Javorski , Linux NFS Mailing List Subject: Re: [PATCH] SUNRPC: don't pause on incomplete allocation Message-ID: <20210830091208.GB3997@suse.com> References: <163004202961.7591.12633163545286005205@noble.neil.brown.name> <163004848514.7591.2757618782251492498@noble.neil.brown.name> <6CC9C852-CEE3-4657-86AD-9D5759E2BE1C@oracle.com> <416268C9-BEAC-483C-9392-8139340BC849@oracle.com> <12B831AA-4A4E-4102-ADA3-97B6FA0B119E@oracle.com> <163027659478.7591.8897815399981483759@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <163027659478.7591.8897815399981483759@noble.neil.brown.name> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Aug 30, 2021 at 08:36:34AM +1000, NeilBrown wrote: > > alloc_pages_bulk_array() attempts to allocate at least one page based on > the provided pages, and then opportunistically allocates more if that > can be done without dropping the spinlock. > > So if it returns fewer than requested, that could just mean that it > needed to drop the lock. In that case, try again immediately. > > Only pause for a time if no progress could be made. > > Reported-and-tested-by: Mike Javorski > Reported-and-tested-by: Lothar Paltins > Fixes: f6e70aab9dfe ("SUNRPC: refresh rq_pages using a bulk page allocator") > Signed-off-by: NeilBrown Acked-by: Mel Gorman -- Mel Gorman SUSE Labs