From: "Quentin Schulz" <quentin.schulz@theobroma-systems.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: YP docs mailing list <docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH] dev-manual: add line continuations for aesthetics
Date: Mon, 30 Aug 2021 11:17:23 +0200 [thread overview]
Message-ID: <20210830091723.ercjocjlom2yond6@fedora> (raw)
In-Reply-To: <9490f67c-af80-2517-737f-f05591c9a0bb@crashcourse.ca>
Hi Robert,
On Mon, Aug 30, 2021 at 05:00:39AM -0400, Robert P. J. Day wrote:
>
> Not a fan of lengthy lines that require horizontal scrolling,
> so add line continuations.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
It is the content of the recipe afterall, so not sure it's desired? Will
let Michael/Nicolas decide.
In any case, this code is out of sync, e.g. WITHOUT_XATTR is now
embedded in a bb.utils.contains check. Since you're sending patch for
this already, do you mind sending a patch for this too please?
Cheers,
Quentin
> ---
>
> diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
> index 4a5011ea7..6f0ee27c7 100644
> --- a/documentation/dev-manual/common-tasks.rst
> +++ b/documentation/dev-manual/common-tasks.rst
> @@ -2331,17 +2331,39 @@ In the following example, ``mtd-utils`` is a makefile-based package::
>
> S = "${WORKDIR}/git"
>
> - EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
> + EXTRA_OEMAKE = " \
> + 'CC=${CC}' \
> + 'RANLIB=${RANLIB}' \
> + 'AR=${AR}' \
> + 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' \
> + 'BUILDDIR=${S}' \
> + "
>
> do_install () {
> - oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> + oe_runmake install \
> + DESTDIR=${D} \
> + SBINDIR=${sbindir} \
> + MANDIR=${mandir} \
> + INCLUDEDIR=${includedir}
> }
>
> PACKAGES =+ "mtd-utils-jffs2 mtd-utils-ubifs mtd-utils-misc"
>
> - FILES:mtd-utils-jffs2 = "${sbindir}/mkfs.jffs2 ${sbindir}/jffs2dump ${sbindir}/jffs2reader ${sbindir}/sumtool"
> + FILES:mtd-utils-jffs2 = " \
> + ${sbindir}/mkfs.jffs2 \
> + ${sbindir}/jffs2dump \
> + ${sbindir}/jffs2reader \
> + ${sbindir}/sumtool \
> + "
> FILES:mtd-utils-ubifs = "${sbindir}/mkfs.ubifs ${sbindir}/ubi*"
> - FILES:mtd-utils-misc = "${sbindir}/nftl* ${sbindir}/ftl* ${sbindir}/rfd* ${sbindir}/doc* ${sbindir}/serve_image ${sbindir}/recv_image"
> + FILES:mtd-utils-misc = " \
> + ${sbindir}/nftl* \
> + ${sbindir}/ftl* \
> + ${sbindir}/rfd* \
> + ${sbindir}/doc* \
> + ${sbindir}/serve_image \
> + ${sbindir}/recv_image \
> + "
>
> PARALLEL_MAKE = ""
>
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> https://urldefense.proofpoint.com/v2/url?u=http-3A__crashcourse.ca&d=DwIBAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=sH8iuVXeDgFiq6-2yFuaJA1ahW9robcDxSFcJtunA6g&s=ez81p3lImZGQIgOs21G8Sys-IEhCl0eRKgi70lFiDSU&e=
>
> LinkedIn: https://urldefense.proofpoint.com/v2/url?u=http-3A__ca.linkedin.com_in_rpjday&d=DwIBAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=sH8iuVXeDgFiq6-2yFuaJA1ahW9robcDxSFcJtunA6g&s=0YgkyEX30AN49Fm5SfWLgeNzQw7rQ_AnyZoUjBGyhtw&e=
> ========================================================================
>
>
>
next prev parent reply other threads:[~2021-08-30 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 9:00 [PATCH] dev-manual: add line continuations for aesthetics Robert P. J. Day
2021-08-30 9:17 ` Quentin Schulz [this message]
2021-08-30 9:26 ` [docs] " Robert P. J. Day
2021-09-02 17:50 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830091723.ercjocjlom2yond6@fedora \
--to=quentin.schulz@theobroma-systems.com \
--cc=docs@lists.yoctoproject.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.