All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] [WIP]: fix build failure caused by zstd
@ 2021-08-30 10:46 Hsia-Jun Li
  2021-08-30 10:46 ` [PATCH 1/2] curl: fix the dependency to zstd Hsia-Jun Li
  2021-08-30 10:46 ` [PATCH 2/2] gcc: disable zstd by default Hsia-Jun Li
  0 siblings, 2 replies; 4+ messages in thread
From: Hsia-Jun Li @ 2021-08-30 10:46 UTC (permalink / raw)
  To: openembedded-core; +Cc: Hsia-Jun(Randy) Li

From: "Hsia-Jun(Randy) Li" <randy.li@synaptics.com>

The configure script of some packages may not be able to
handle this correctly.

I have not verified all the packages, I was developing
something for meta-clang actually.

Hsia-Jun(Randy) Li (2):
  curl: fix the dependency to zstd
  gcc: disable zstd by default

 meta/recipes-devtools/gcc/gcc-11.2.inc   | 2 ++
 meta/recipes-support/curl/curl_7.78.0.bb | 1 +
 2 files changed, 3 insertions(+)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] curl: fix the dependency to zstd
  2021-08-30 10:46 [PATCH 0/2] [WIP]: fix build failure caused by zstd Hsia-Jun Li
@ 2021-08-30 10:46 ` Hsia-Jun Li
  2021-08-30 10:46 ` [PATCH 2/2] gcc: disable zstd by default Hsia-Jun Li
  1 sibling, 0 replies; 4+ messages in thread
From: Hsia-Jun Li @ 2021-08-30 10:46 UTC (permalink / raw)
  To: openembedded-core; +Cc: Hsia-Jun(Randy) Li

From: "Hsia-Jun(Randy) Li" <randy.li@synaptics.com>

It would be enabled by default but I am not sure whether
we need it.

Signed-off-by: Hsia-Jun(Randy) Li <randy.li@synaptics.com>
---
 meta/recipes-support/curl/curl_7.78.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/curl/curl_7.78.0.bb b/meta/recipes-support/curl/curl_7.78.0.bb
index dece0ba..c779d8f 100644
--- a/meta/recipes-support/curl/curl_7.78.0.bb
+++ b/meta/recipes-support/curl/curl_7.78.0.bb
@@ -55,6 +55,7 @@ PACKAGECONFIG[tftp] = "--enable-tftp,--disable-tftp,"
 PACKAGECONFIG[threaded-resolver] = "--enable-threaded-resolver,--disable-threaded-resolver,,,,ares"
 PACKAGECONFIG[verbose] = "--enable-verbose,--disable-verbose"
 PACKAGECONFIG[zlib] = "--with-zlib=${STAGING_LIBDIR}/../,--without-zlib,zlib"
+PACKAGECONFIG[zstd] = ",--without-zstd,zstd"
 
 EXTRA_OECONF = " \
     --disable-libcurl-option \
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] gcc: disable zstd by default
  2021-08-30 10:46 [PATCH 0/2] [WIP]: fix build failure caused by zstd Hsia-Jun Li
  2021-08-30 10:46 ` [PATCH 1/2] curl: fix the dependency to zstd Hsia-Jun Li
@ 2021-08-30 10:46 ` Hsia-Jun Li
  2021-08-30 16:02   ` [OE-core] " Khem Raj
  1 sibling, 1 reply; 4+ messages in thread
From: Hsia-Jun Li @ 2021-08-30 10:46 UTC (permalink / raw)
  To: openembedded-core; +Cc: Hsia-Jun(Randy) Li

From: "Hsia-Jun(Randy) Li" <randy.li@synaptics.com>

I think this script is a little trick, unless you disable
it, it would consider it enabled anyway.

Signed-off-by: Hsia-Jun(Randy) Li <randy.li@synaptics.com>
---
 meta/recipes-devtools/gcc/gcc-11.2.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/gcc/gcc-11.2.inc b/meta/recipes-devtools/gcc/gcc-11.2.inc
index 9fd30f5..77dd94e 100644
--- a/meta/recipes-devtools/gcc/gcc-11.2.inc
+++ b/meta/recipes-devtools/gcc/gcc-11.2.inc
@@ -90,6 +90,7 @@ EXTRA_OECONF_BASE = "\
     --enable-lto \
     --disable-bootstrap \
     --with-system-zlib \
+    --with-zstd=no \
     ${@'--with-linker-hash-style=${LINKER_HASH_STYLE}' if '${LINKER_HASH_STYLE}' else ''} \
     --enable-linker-build-id \
     --with-ppl=no \
@@ -105,6 +106,7 @@ EXTRA_OECONF_INITIAL = "\
     --disable-libquadmath \
     --with-system-zlib \
     --disable-lto \
+    --with-zstd=no \
     --disable-plugin \
     --enable-linker-build-id \
     --enable-decimal-float=no \
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [OE-core] [PATCH 2/2] gcc: disable zstd by default
  2021-08-30 10:46 ` [PATCH 2/2] gcc: disable zstd by default Hsia-Jun Li
@ 2021-08-30 16:02   ` Khem Raj
  0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2021-08-30 16:02 UTC (permalink / raw)
  To: Hsia-Jun Li; +Cc: Patches and discussions about the oe-core layer

On Mon, Aug 30, 2021 at 3:47 AM Hsia-Jun Li <randy.li@synaptics.com> wrote:
>
> From: "Hsia-Jun(Randy) Li" <randy.li@synaptics.com>
>
> I think this script is a little trick, unless you disable
> it, it would consider it enabled anyway.
>
> Signed-off-by: Hsia-Jun(Randy) Li <randy.li@synaptics.com>
> ---
>  meta/recipes-devtools/gcc/gcc-11.2.inc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-11.2.inc b/meta/recipes-devtools/gcc/gcc-11.2.inc
> index 9fd30f5..77dd94e 100644
> --- a/meta/recipes-devtools/gcc/gcc-11.2.inc
> +++ b/meta/recipes-devtools/gcc/gcc-11.2.inc
> @@ -90,6 +90,7 @@ EXTRA_OECONF_BASE = "\
>      --enable-lto \
>      --disable-bootstrap \
>      --with-system-zlib \
> +    --with-zstd=no \
>      ${@'--with-linker-hash-style=${LINKER_HASH_STYLE}' if '${LINKER_HASH_STYLE}' else ''} \
>      --enable-linker-build-id \
>      --with-ppl=no \
> @@ -105,6 +106,7 @@ EXTRA_OECONF_INITIAL = "\
>      --disable-libquadmath \
>      --with-system-zlib \
>      --disable-lto \
> +    --with-zstd=no \
>      --disable-plugin \
>      --enable-linker-build-id \
>      --enable-decimal-float=no \
> --

why do we want to disable it ? In anycase perhaps make it a
packageconfig for consistency and I would
think we should enable it by default.

> 2.7.4
>
>
> 
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-30 16:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 10:46 [PATCH 0/2] [WIP]: fix build failure caused by zstd Hsia-Jun Li
2021-08-30 10:46 ` [PATCH 1/2] curl: fix the dependency to zstd Hsia-Jun Li
2021-08-30 10:46 ` [PATCH 2/2] gcc: disable zstd by default Hsia-Jun Li
2021-08-30 16:02   ` [OE-core] " Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.