From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A541DC4320E for ; Mon, 30 Aug 2021 18:26:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 834C360ED4 for ; Mon, 30 Aug 2021 18:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238621AbhH3S1u (ORCPT ); Mon, 30 Aug 2021 14:27:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:47884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238280AbhH3S1t (ORCPT ); Mon, 30 Aug 2021 14:27:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B9BA160E98; Mon, 30 Aug 2021 18:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630348015; bh=8tUSjnr7H3PoBoLy0ZN0FF3bzIzyWoa6mO5HoG79dZc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aGysZSQSmRhXl9MzPNSZy5H4pIPbHZfQyvZiuDdc+QmanI7H9JYXKHko8cHFaD6GT MY8U8DYhC2r4LUCAzNySMWidPasMQIxU1ZNATOo4bXx060x9vO0r+kXEKnXTQZLeOh hNvkPlVMeDSgKohJzrV4o+Ni5Ylon2DSr1QaU/k3Kf6UFhLxTXq8BXGmyqifcOY45u WNrXARu2Gqn0ySve1D3aoYy3pRJQxvb6o+5M9HUhl2Xfi2wDgKQzc5Tp0SUa7qfWeC e+zPXTbHWb8nY0948rvn59Y5LcIgIFhGNEObAIc7hlrMzW6jf6vPOQjR6HiEQ7ZQCo oJplxMt8qESww== Date: Mon, 30 Aug 2021 11:26:53 -0700 From: Jakub Kicinski To: zhaoxiao Cc: davem@davemloft.net, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() Message-ID: <20210830112653.450eab49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210830012417.14872-1-zhaoxiao@uniontech.com> References: <20210830012417.14872-1-zhaoxiao@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Aug 2021 09:24:17 +0800 zhaoxiao wrote: > @@ -69,6 +68,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id > if (!plat) > return -ENOMEM; > > + > if (plat->mdio_node) { > dev_err(&pdev->dev, "Found MDIO subnode\n"); > mdio = true; > @@ -111,6 +111,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id > phy_mode = device_get_phy_mode(&pdev->dev); > if (phy_mode < 0) > dev_err(&pdev->dev, "phy_mode not found\n"); > + > > plat->phy_interface = phy_mode; > plat->interface = PHY_INTERFACE_MODE_GMII; Please remove these changes from the patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA94C432BE for ; Mon, 30 Aug 2021 18:28:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86CEA60E98 for ; Mon, 30 Aug 2021 18:28:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 86CEA60E98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=El+8siFjzG0hnZ396GfCi2/vKzvzcwq9KTK1+IEOz/Q=; b=kYwOfSP5IgShJr sMkzBlTEoXf8hkysRNeYo1z1SltNtVuuP6pN8MbQCr9sx4/FxAfhZBuxlq2M0uXPk823NifbLyeE4 0Dp9XUzzU1R/iVul/AiQ68wrWpBEHe8pRTrrZwgi9o9anKt+4mk5sE+hAIrAzyNs1Hi0mHpIWYn3z QSpFWDss8uvFPbAZK9FgwTjbeuf7YUENqLkQgFVbFxkt9Xx27juaCGc4TsKHfTMrIhhMvRkSBTR9t gPWPALVm1mOVnrWiBskoPB5eRq1tBe9NQtmPI/2lGgT2KSL96hPXYj0FMTEQvfrGDhQ0h4Qw+5mvL mKQ2zd646QyIkv0dBMNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKlzo-000MUa-H7; Mon, 30 Aug 2021 18:27:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKlzj-000MTj-Rc for linux-arm-kernel@lists.infradead.org; Mon, 30 Aug 2021 18:26:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B9BA160E98; Mon, 30 Aug 2021 18:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630348015; bh=8tUSjnr7H3PoBoLy0ZN0FF3bzIzyWoa6mO5HoG79dZc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aGysZSQSmRhXl9MzPNSZy5H4pIPbHZfQyvZiuDdc+QmanI7H9JYXKHko8cHFaD6GT MY8U8DYhC2r4LUCAzNySMWidPasMQIxU1ZNATOo4bXx060x9vO0r+kXEKnXTQZLeOh hNvkPlVMeDSgKohJzrV4o+Ni5Ylon2DSr1QaU/k3Kf6UFhLxTXq8BXGmyqifcOY45u WNrXARu2Gqn0ySve1D3aoYy3pRJQxvb6o+5M9HUhl2Xfi2wDgKQzc5Tp0SUa7qfWeC e+zPXTbHWb8nY0948rvn59Y5LcIgIFhGNEObAIc7hlrMzW6jf6vPOQjR6HiEQ7ZQCo oJplxMt8qESww== Date: Mon, 30 Aug 2021 11:26:53 -0700 From: Jakub Kicinski To: zhaoxiao Cc: davem@davemloft.net, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() Message-ID: <20210830112653.450eab49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210830012417.14872-1-zhaoxiao@uniontech.com> References: <20210830012417.14872-1-zhaoxiao@uniontech.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_112655_962624_7F238611 X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 30 Aug 2021 09:24:17 +0800 zhaoxiao wrote: > @@ -69,6 +68,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id > if (!plat) > return -ENOMEM; > > + > if (plat->mdio_node) { > dev_err(&pdev->dev, "Found MDIO subnode\n"); > mdio = true; > @@ -111,6 +111,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id > phy_mode = device_get_phy_mode(&pdev->dev); > if (phy_mode < 0) > dev_err(&pdev->dev, "phy_mode not found\n"); > + > > plat->phy_interface = phy_mode; > plat->interface = PHY_INTERFACE_MODE_GMII; Please remove these changes from the patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel