From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mKfnj-0002L9-NT for mharc-grub-devel@gnu.org; Mon, 30 Aug 2021 07:50:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKfnh-0002IQ-C8 for grub-devel@gnu.org; Mon, 30 Aug 2021 07:50:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKfnf-00058o-2N for grub-devel@gnu.org; Mon, 30 Aug 2021 07:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630324201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BUZaPHG+WwtxSx8rLGcAEgZbaGnRrSneezdnU7wmARA=; b=Yg1vGvpLM5/5cw8PDjFnZvASsPnBfyOzgJ675hQJ4F9JCt7a+9pYuEuSFx7IvlVEdja+A0 Ux99C6OEdGdkyzTH/La/VLPYkNggIFwYX7bbGFKZGtw2iM/x2XCjrLldaQQH7zhwYj4GQz uEA9F3l60X6ESQobSiGq/Be8HKILB84= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-nPVfvEqdMm6z7pnkn1sAFQ-1; Mon, 30 Aug 2021 07:48:53 -0400 X-MC-Unique: nPVfvEqdMm6z7pnkn1sAFQ-1 Received: by mail-ed1-f71.google.com with SMTP id o11-20020a056402038b00b003c9e6fd522bso2755351edv.19 for ; Mon, 30 Aug 2021 04:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BUZaPHG+WwtxSx8rLGcAEgZbaGnRrSneezdnU7wmARA=; b=PLWrsLXONcsCJgkV8PaYPPVyQMWINerCUyYzQYzROWrqvKRuyqmGQ4qkxywI49N5mv /nPj820bx7wAex5J68LXuTT1L09zb6D+hvEiaTgV9FIk9ss22d6wqouY+/Kq4HdODg7a oUXxBV3AT+Y5MYjJs4Q3TCQAfhuzuKi5kuYR89rd5zPNAW1wxn1VHXbLMOfKyXc+XjXg HDdjNcUsezZahU0aiVvCvFHWCq/mcuzcRN+CKBQ9KXfJr5PDo/kN+N3MAdDx+tiDFMBT 8A3F3vboJbrSagNRA5vFmSQc8P3GNGJ4KM8GuDzmupyPUjeE8FendbNUrWH8kyNAbhns 7F6w== X-Gm-Message-State: AOAM5317FJ3fIUbpwNzcSl4ghK38uuu3BxTsZ3hg+lgTxbvm0W5OAOQA 7/H6IkJxg4HZ7wjTl1f12xnDEgome61mu+pVeBO0CQhYtKvF6UlJZqUXzRTvHN4No4NBMktP7IX WhRRRG3daBJ8= X-Received: by 2002:aa7:d501:: with SMTP id y1mr15239546edq.6.1630324132550; Mon, 30 Aug 2021 04:48:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxd7qTsQTG32VHfC9QDwo62E3l4pwEEFlSjCXtpcDQRbaMYGa5mMiU/nh0yfQnOcEwVmuQL+Q== X-Received: by 2002:aa7:d501:: with SMTP id y1mr15239520edq.6.1630324132354; Mon, 30 Aug 2021 04:48:52 -0700 (PDT) Received: from omega.lan (ip4-46-39-172-19.cust.nbox.cz. [46.39.172.19]) by smtp.gmail.com with ESMTPSA id p21sm3370789ejm.88.2021.08.30.04.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 04:48:51 -0700 (PDT) Date: Mon, 30 Aug 2021 13:48:50 +0200 From: Carlos Maiolino To: Erwan Velu Cc: grub-devel@gnu.org, a.rougemont@criteo.com, Erwan Velu , daniel.kiper@oracle.com, dkiper@net-space.pl, alexander.burmashev@oracle.com, phcoder@gmail.com Subject: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock Message-ID: <20210830114850.kemzuknbe4nwzkip@omega.lan> References: <20210825133152.1165682-1-e.velu@criteo.com> <20210826132616.dhhiwdowapcolrdr@omega.lan> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cmaiolino@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cmaiolino@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 11:50:06 -0000 Hi. On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > Good day list, > Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiolino@redhat.com> > a écrit : > > [..] > Thanks for spotting this! > > I'm adding the maintainers in CC. Carlos who commit the patch I'm > fixing, agreed on the content. I didn't test the patch itself yet, but I've reproduced the issue. I was quite sure I had tested this patch on a V4 fs, but looks like I miscalculated the sizing. Thanks again. I'll try to test the patch here asap. > This patch is important as it prevents the 2.06 version to turn XFS v4 > system into an unbootable state. > > References > > 1. mailto:cmaiolino@redhat.com -- Carlos