Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3198 bytes --]

Hi Zhiyong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.14 next-20210827]
[cannot apply to pinctrl/devel mediatek/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhiyong-Tao/Mediatek-pinctrl-patch-on-mt8195/20210830-083752
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-buildonly-randconfig-r006-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/eec1945e55fba60a9ef8b426b21d12c0a2aa1ac7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhiyong-Tao/Mediatek-pinctrl-patch-on-mt8195/20210830-083752
        git checkout eec1945e55fba60a9ef8b426b21d12c0a2aa1ac7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:723:3: warning: variable 'rsel_val' is uninitialized when used here [-Wuninitialized]
                   rsel_val -= MTK_PULL_SET_RSEL_000;
                   ^~~~~~~~
   drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:709:19: note: initialize the variable 'rsel_val' to silence this warning
           int err, rsel_val;
                            ^
                             = 0
   1 warning generated.


vim +/rsel_val +723 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c

   704	
   705	static int mtk_pinconf_bias_set_rsel(struct mtk_pinctrl *hw,
   706					     const struct mtk_pin_desc *desc,
   707					     u32 pullup, u32 arg)
   708	{
   709		int err, rsel_val;
   710	
   711		if (hw->soc->pin_rsel) {
   712			/* find pin rsel_index from pin_rsel array*/
   713			err = mtk_hw_pin_rsel_lookup(hw, desc, pullup, arg, &rsel_val);
   714			if (err)
   715				goto out;
   716		} else {
   717			if (arg < MTK_PULL_SET_RSEL_000 ||
   718			    arg > MTK_PULL_SET_RSEL_111) {
   719				err = -EINVAL;
   720				goto out;
   721			}
   722	
 > 723			rsel_val -= MTK_PULL_SET_RSEL_000;
   724		}
   725	
   726		err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_RSEL, rsel_val);
   727		if (err)
   728			goto out;
   729	
   730		err = mtk_pinconf_bias_set_pu_pd(hw, desc, pullup, MTK_ENABLE);
   731	
   732	out:
   733		return err;
   734	}
   735	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44984 bytes --]