From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA8703FC3 for ; Mon, 30 Aug 2021 12:04:38 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id x2-20020a1c7c02000000b002e6f1f69a1eso14523442wmc.5 for ; Mon, 30 Aug 2021 05:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7HirnwGNf7jyImc4ZKCsenDbRLWYzFjlPI/Sq6s9Xg8=; b=uzMCEtoEezXlvfIcoS/Z30RKzKk1Ue2suN/TxfDZwb0G//T88o+gkAgIpOHMXiMjcx RYL/Z5/RQBH4UO26Oiao+8MipEoMSp+zMgHe/8AjVZNumfY+FUhkR+1ie771Mm/wlhXy svOO1z90pXICCwVWdrStQsGuFeTG4+2QSuq7L+0S9eiZMfemf9n1KPlNTmPFP/iEosXG 1xp/ujbUpUMJzAZ8a3zNUYmAtvXxu7qiP2VUC/4PItOUvcxXw6Klc/k2NvrDIWTcYxpS 0d8JXZz4Na3+Y5vrLn2nSmTmeea4njqUPUgRkPmbUqKDt1ul/alUK1BOLYnUw4JEWD4p 4lKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7HirnwGNf7jyImc4ZKCsenDbRLWYzFjlPI/Sq6s9Xg8=; b=s8Jvj+3UZAIigACN6X0AffqqjVLiYiChdeox83NDtemGbxfCbtDAJWOV32qMYEt/x9 sqnDjz0sdFESdt44Y77EMuQJAcYhcwi88bBsoysRZfgJwHCQhEXRE6XYR9f/opJP2JdE lx1nzrCQBwNCQqkhYFFcQ+9dv9zANQN+up3hX0LSphnA0Y9Qojyia5SdPdxbH5zRZR/x 7MJ4BrR6XCwy3FARchze4WKumSSn37CulwFdWIb1hOpiewruycGeQDPfaChqoEUpkJMh oJad78+o3LguJNxrlCskHYnsnrCq+NJdC1KOAaw/Ss0rCKa+X7aJ6COh+vR7hsqq9Zt6 BnrA== X-Gm-Message-State: AOAM533Qch54Ux4vpJNVO/Fdb0c88dnCDjeVlTCL+rSvV13YotOSkaXE 3OQ+xm5Jsj8gYrL49aolzX4= X-Google-Smtp-Source: ABdhPJxiHO229Pl+V8QCp4XfHbvkFo7i8EM28vmDLDdlDs1ZDDthnKbJSwPdygfGuWiM7srCQWXV4Q== X-Received: by 2002:a7b:c94c:: with SMTP id i12mr9960953wml.111.1630325077420; Mon, 30 Aug 2021 05:04:37 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::16fa]) by smtp.gmail.com with ESMTPSA id f18sm13184195wmc.6.2021.08.30.05.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 05:04:37 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/8] staging: r8188eu: use is_*_ether_addr() in rtw_macaddr_cfg() Date: Mon, 30 Aug 2021 14:04:16 +0200 Message-Id: <20210830120420.5287-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210830120420.5287-1-straube.linux@gmail.com> References: <20210830120420.5287-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use is_broadcast_ether_addr() and is_zero_ether_addr() in rtw_macaddr_cfg(). The buffer is properly aligned. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_ieee80211.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_ieee80211.c b/drivers/staging/r8188eu/core/rtw_ieee80211.c index 205798b76cf9..35a548e1c92e 100644 --- a/drivers/staging/r8188eu/core/rtw_ieee80211.c +++ b/drivers/staging/r8188eu/core/rtw_ieee80211.c @@ -1032,10 +1032,7 @@ void rtw_macaddr_cfg(u8 *mac_addr) memcpy(mac, mac_addr, ETH_ALEN); } - if (((mac[0] == 0xff) && (mac[1] == 0xff) && (mac[2] == 0xff) && - (mac[3] == 0xff) && (mac[4] == 0xff) && (mac[5] == 0xff)) || - ((mac[0] == 0x0) && (mac[1] == 0x0) && (mac[2] == 0x0) && - (mac[3] == 0x0) && (mac[4] == 0x0) && (mac[5] == 0x0))) { + if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) { mac[0] = 0x00; mac[1] = 0xe0; mac[2] = 0x4c; -- 2.33.0