CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: "James E.J. Bottomley" CC: Helge Deller CC: Nick Desaulniers CC: Russell King CC: Dave Hansen CC: Christophe Leroy CC: Mike Rapoport CC: Joe Perches From: kernel test robot arch/parisc/mm/init.c:138:36-37: WARNING opportunity for swap() Check for opencoded swap() implementation. Generated by: scripts/coccinelle/misc/swap.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7d2a07b769330c34b4deabeed939325c77a7ec2f commit: 7845daa8bd72efa8bbc1de122edfce6e058bbe41 coccinelle: misc: add swap script :::::: branch date: 15 hours ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/arch/parisc/mm/init.c +++ b/arch/parisc/mm/init.c @@ -134,9 +134,7 @@ static void __init setup_bootmem(void) break; } - tmp = pmem_ranges[j-1]; - pmem_ranges[j-1] = pmem_ranges[j]; - pmem_ranges[j] = tmp; + swap(pmem_ranges[j - 1], pmem_ranges[j]); } }