From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1295BC4320A for ; Mon, 30 Aug 2021 15:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0A9760F91 for ; Mon, 30 Aug 2021 15:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237636AbhH3QAn (ORCPT ); Mon, 30 Aug 2021 12:00:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:36576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237857AbhH3QAm (ORCPT ); Mon, 30 Aug 2021 12:00:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D10A60F56; Mon, 30 Aug 2021 15:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630339188; bh=RKKJL2Oa462dloe2S2b4LJnqrOSFWbJ15BpzgjMEaKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XxR5WdMPVmngFeWeWo2gCYUQI+j4hJZNKUfhSAHJ5qMH+MD8/366tZOqAEVTd73gy aj4IDHh+My+406/Zcu0nw6f2nx3DZJmwEz2dcqTAdsmtOY1Xr3/6LQK1D3+F1HhfKL jzBv/27DFJ1cERXdkJXblORGMAk14ucEywveq7AOvfzBN7uS3U2hBR19MrkCSiJ6xM u4uOrbieaCo+ecNfTo117zz7ii474eYRIC3px17mUrgDdyHIIPxzTI/0xDd+/TjmAA Dlx3KOmpyUM9cURws+wVLTSljB18BoGsXBM1LvlbtUQplrdve3J9fVnHhEg3Oe0uU3 5agCrqJHMpXYw== Received: by pali.im (Postfix) id C8A537B8; Mon, 30 Aug 2021 17:59:45 +0200 (CEST) Date: Mon, 30 Aug 2021 17:59:45 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kunihiko Hayashi Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Marc Zyngier , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack function Message-ID: <20210830155945.yuirq5tsy2migovk@pali> References: <1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com> <1630290158-31264-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1630290158-31264-2-git-send-email-hayashi.kunihiko@socionext.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 30 August 2021 11:22:37 Kunihiko Hayashi wrote: > INTX mask and unmask fields in PCL_RCV_INTX register should only be > set/reset for each bit. Clearing by PCL_RCV_INTX_ALL_MASK should be > removed. > > INTX status fields in PCL_RCV_INTX register only indicates each INTX > interrupt status, so the handler can't clear by writing 1 to the field. > The status is expected to be cleared by the interrupt origin. > The ack function has no meaning, so should remove it. > > Fixes: 7e6d5cd88a6f ("PCI: uniphier: Add UniPhier PCIe host controller support") > Signed-off-by: Kunihiko Hayashi Acked-by: Pali Rohár > --- > drivers/pci/controller/dwc/pcie-uniphier.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c > index ebe43e9..26f630c 100644 > --- a/drivers/pci/controller/dwc/pcie-uniphier.c > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c > @@ -181,19 +181,6 @@ static void uniphier_pcie_irq_enable(struct uniphier_pcie_priv *priv) > writel(PCL_RCV_INTX_ALL_ENABLE, priv->base + PCL_RCV_INTX); > } > > -static void uniphier_pcie_irq_ack(struct irq_data *d) > -{ > - struct pcie_port *pp = irq_data_get_irq_chip_data(d); > - struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > - struct uniphier_pcie_priv *priv = to_uniphier_pcie(pci); > - u32 val; > - > - val = readl(priv->base + PCL_RCV_INTX); > - val &= ~PCL_RCV_INTX_ALL_STATUS; > - val |= BIT(irqd_to_hwirq(d) + PCL_RCV_INTX_STATUS_SHIFT); > - writel(val, priv->base + PCL_RCV_INTX); > -} > - > static void uniphier_pcie_irq_mask(struct irq_data *d) > { > struct pcie_port *pp = irq_data_get_irq_chip_data(d); > @@ -202,7 +189,6 @@ static void uniphier_pcie_irq_mask(struct irq_data *d) > u32 val; > > val = readl(priv->base + PCL_RCV_INTX); > - val &= ~PCL_RCV_INTX_ALL_MASK; > val |= BIT(irqd_to_hwirq(d) + PCL_RCV_INTX_MASK_SHIFT); > writel(val, priv->base + PCL_RCV_INTX); > } > @@ -215,14 +201,12 @@ static void uniphier_pcie_irq_unmask(struct irq_data *d) > u32 val; > > val = readl(priv->base + PCL_RCV_INTX); > - val &= ~PCL_RCV_INTX_ALL_MASK; > val &= ~BIT(irqd_to_hwirq(d) + PCL_RCV_INTX_MASK_SHIFT); > writel(val, priv->base + PCL_RCV_INTX); > } > > static struct irq_chip uniphier_pcie_irq_chip = { > .name = "PCI", > - .irq_ack = uniphier_pcie_irq_ack, > .irq_mask = uniphier_pcie_irq_mask, > .irq_unmask = uniphier_pcie_irq_unmask, > }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17807C432BE for ; Mon, 30 Aug 2021 16:03:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC4E060FED for ; Mon, 30 Aug 2021 16:03:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC4E060FED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7p4BQhTk5qHLqgd0W7MXh4UUH7k6uiAL/ZgA2XQ9Pm4=; b=c3z33djsD4SNW4 vKA1sB6n8KlntJUfwnPTxD12icx8KePUs10cR0bnXOKe7ST9qTPINYbDx37tUTmYHCyzdJtbSsNQn NHHXj9U3oLixQu7WI/lg53iDU4Xmz/kKBpkTwrZ+nB3U9ypTFNiXIbusk+r8SA9aWITEE4qPEhRRT 7FIBbhs1LTAeiFQWNS0jOG6D++mHg8U0n34i4+n7IbPBVZR7h7VWVJRVO7R7cgXRupQEEhuOn+7xe QU0gzNmGJW4bxV/y7uWlGfQpgqzzgWAxP68fttcXOI0EFVJ+UvDlOg8y+v3ASS8Hx0NF5J84a1oMX fC0ZCN26q1nSuXUgi0TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKjiK-00HZkJ-NY; Mon, 30 Aug 2021 16:00:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKjhN-00HZSD-JV for linux-arm-kernel@lists.infradead.org; Mon, 30 Aug 2021 15:59:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D10A60F56; Mon, 30 Aug 2021 15:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630339188; bh=RKKJL2Oa462dloe2S2b4LJnqrOSFWbJ15BpzgjMEaKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XxR5WdMPVmngFeWeWo2gCYUQI+j4hJZNKUfhSAHJ5qMH+MD8/366tZOqAEVTd73gy aj4IDHh+My+406/Zcu0nw6f2nx3DZJmwEz2dcqTAdsmtOY1Xr3/6LQK1D3+F1HhfKL jzBv/27DFJ1cERXdkJXblORGMAk14ucEywveq7AOvfzBN7uS3U2hBR19MrkCSiJ6xM u4uOrbieaCo+ecNfTo117zz7ii474eYRIC3px17mUrgDdyHIIPxzTI/0xDd+/TjmAA Dlx3KOmpyUM9cURws+wVLTSljB18BoGsXBM1LvlbtUQplrdve3J9fVnHhEg3Oe0uU3 5agCrqJHMpXYw== Received: by pali.im (Postfix) id C8A537B8; Mon, 30 Aug 2021 17:59:45 +0200 (CEST) Date: Mon, 30 Aug 2021 17:59:45 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kunihiko Hayashi Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Marc Zyngier , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack function Message-ID: <20210830155945.yuirq5tsy2migovk@pali> References: <1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com> <1630290158-31264-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1630290158-31264-2-git-send-email-hayashi.kunihiko@socionext.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_085949_750437_85DC338F X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uZGF5IDMwIEF1Z3VzdCAyMDIxIDExOjIyOjM3IEt1bmloaWtvIEhheWFzaGkgd3JvdGU6 Cj4gSU5UWCBtYXNrIGFuZCB1bm1hc2sgZmllbGRzIGluIFBDTF9SQ1ZfSU5UWCByZWdpc3RlciBz aG91bGQgb25seSBiZQo+IHNldC9yZXNldCBmb3IgZWFjaCBiaXQuIENsZWFyaW5nIGJ5IFBDTF9S Q1ZfSU5UWF9BTExfTUFTSyBzaG91bGQgYmUKPiByZW1vdmVkLgo+IAo+IElOVFggc3RhdHVzIGZp ZWxkcyBpbiBQQ0xfUkNWX0lOVFggcmVnaXN0ZXIgb25seSBpbmRpY2F0ZXMgZWFjaCBJTlRYCj4g aW50ZXJydXB0IHN0YXR1cywgc28gdGhlIGhhbmRsZXIgY2FuJ3QgY2xlYXIgYnkgd3JpdGluZyAx IHRvIHRoZSBmaWVsZC4KPiBUaGUgc3RhdHVzIGlzIGV4cGVjdGVkIHRvIGJlIGNsZWFyZWQgYnkg dGhlIGludGVycnVwdCBvcmlnaW4uCj4gVGhlIGFjayBmdW5jdGlvbiBoYXMgbm8gbWVhbmluZywg c28gc2hvdWxkIHJlbW92ZSBpdC4KPiAKPiBGaXhlczogN2U2ZDVjZDg4YTZmICgiUENJOiB1bmlw aGllcjogQWRkIFVuaVBoaWVyIFBDSWUgaG9zdCBjb250cm9sbGVyIHN1cHBvcnQiKQo+IFNpZ25l ZC1vZmYtYnk6IEt1bmloaWtvIEhheWFzaGkgPGhheWFzaGkua3VuaWhpa29Ac29jaW9uZXh0LmNv bT4KCkFja2VkLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgoKPiAtLS0KPiAgZHJp dmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS11bmlwaGllci5jIHwgMTYgLS0tLS0tLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtdW5pcGhpZXIuYyBiL2RyaXZlcnMvcGNp L2NvbnRyb2xsZXIvZHdjL3BjaWUtdW5pcGhpZXIuYwo+IGluZGV4IGViZTQzZTkuLjI2ZjYzMGMg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS11bmlwaGllci5j Cj4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS11bmlwaGllci5jCj4gQEAg LTE4MSwxOSArMTgxLDYgQEAgc3RhdGljIHZvaWQgdW5pcGhpZXJfcGNpZV9pcnFfZW5hYmxlKHN0 cnVjdCB1bmlwaGllcl9wY2llX3ByaXYgKnByaXYpCj4gIAl3cml0ZWwoUENMX1JDVl9JTlRYX0FM TF9FTkFCTEUsIHByaXYtPmJhc2UgKyBQQ0xfUkNWX0lOVFgpOwo+ICB9Cj4gIAo+IC1zdGF0aWMg dm9pZCB1bmlwaGllcl9wY2llX2lycV9hY2soc3RydWN0IGlycV9kYXRhICpkKQo+IC17Cj4gLQlz dHJ1Y3QgcGNpZV9wb3J0ICpwcCA9IGlycV9kYXRhX2dldF9pcnFfY2hpcF9kYXRhKGQpOwo+IC0J c3RydWN0IGR3X3BjaWUgKnBjaSA9IHRvX2R3X3BjaWVfZnJvbV9wcChwcCk7Cj4gLQlzdHJ1Y3Qg dW5pcGhpZXJfcGNpZV9wcml2ICpwcml2ID0gdG9fdW5pcGhpZXJfcGNpZShwY2kpOwo+IC0JdTMy IHZhbDsKPiAtCj4gLQl2YWwgPSByZWFkbChwcml2LT5iYXNlICsgUENMX1JDVl9JTlRYKTsKPiAt CXZhbCAmPSB+UENMX1JDVl9JTlRYX0FMTF9TVEFUVVM7Cj4gLQl2YWwgfD0gQklUKGlycWRfdG9f aHdpcnEoZCkgKyBQQ0xfUkNWX0lOVFhfU1RBVFVTX1NISUZUKTsKPiAtCXdyaXRlbCh2YWwsIHBy aXYtPmJhc2UgKyBQQ0xfUkNWX0lOVFgpOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCB1bmlwaGll cl9wY2llX2lycV9tYXNrKHN0cnVjdCBpcnFfZGF0YSAqZCkKPiAgewo+ICAJc3RydWN0IHBjaWVf cG9ydCAqcHAgPSBpcnFfZGF0YV9nZXRfaXJxX2NoaXBfZGF0YShkKTsKPiBAQCAtMjAyLDcgKzE4 OSw2IEBAIHN0YXRpYyB2b2lkIHVuaXBoaWVyX3BjaWVfaXJxX21hc2soc3RydWN0IGlycV9kYXRh ICpkKQo+ICAJdTMyIHZhbDsKPiAgCj4gIAl2YWwgPSByZWFkbChwcml2LT5iYXNlICsgUENMX1JD Vl9JTlRYKTsKPiAtCXZhbCAmPSB+UENMX1JDVl9JTlRYX0FMTF9NQVNLOwo+ICAJdmFsIHw9IEJJ VChpcnFkX3RvX2h3aXJxKGQpICsgUENMX1JDVl9JTlRYX01BU0tfU0hJRlQpOwo+ICAJd3JpdGVs KHZhbCwgcHJpdi0+YmFzZSArIFBDTF9SQ1ZfSU5UWCk7Cj4gIH0KPiBAQCAtMjE1LDE0ICsyMDEs MTIgQEAgc3RhdGljIHZvaWQgdW5pcGhpZXJfcGNpZV9pcnFfdW5tYXNrKHN0cnVjdCBpcnFfZGF0 YSAqZCkKPiAgCXUzMiB2YWw7Cj4gIAo+ICAJdmFsID0gcmVhZGwocHJpdi0+YmFzZSArIFBDTF9S Q1ZfSU5UWCk7Cj4gLQl2YWwgJj0gflBDTF9SQ1ZfSU5UWF9BTExfTUFTSzsKPiAgCXZhbCAmPSB+ QklUKGlycWRfdG9faHdpcnEoZCkgKyBQQ0xfUkNWX0lOVFhfTUFTS19TSElGVCk7Cj4gIAl3cml0 ZWwodmFsLCBwcml2LT5iYXNlICsgUENMX1JDVl9JTlRYKTsKPiAgfQo+ICAKPiAgc3RhdGljIHN0 cnVjdCBpcnFfY2hpcCB1bmlwaGllcl9wY2llX2lycV9jaGlwID0gewo+ICAJLm5hbWUgPSAiUENJ IiwKPiAtCS5pcnFfYWNrID0gdW5pcGhpZXJfcGNpZV9pcnFfYWNrLAo+ICAJLmlycV9tYXNrID0g dW5pcGhpZXJfcGNpZV9pcnFfbWFzaywKPiAgCS5pcnFfdW5tYXNrID0gdW5pcGhpZXJfcGNpZV9p cnFfdW5tYXNrLAo+ICB9Owo+IC0tIAo+IDIuNy40Cj4gCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==