All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Machnikowski, Maciej" <maciej.machnikowski@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"abyagowi@fb.com" <abyagowi@fb.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	bsd@fb.com
Subject: Re: [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Mon, 30 Aug 2021 16:29:09 -0700	[thread overview]
Message-ID: <20210830162909.110753ec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210830205758.GA26230@hoboy.vegasvil.org>

On Mon, 30 Aug 2021 13:57:58 -0700 Richard Cochran wrote:
> > Please take a look at the 10.2 Operation modes of the G.8264 and at the Figure A.1
> > which depicts the EEC. This interface is to report the status of the EEC.  
> 
> Well, I read it, and it is still fairly high level with no mention at
> all of "DPLL".  I hope that the new RTNL states will cover other
> possible EEC implementations, too.
> 
> The "Reference source selection mechanism" is also quite vague.  Your
> patch is more specific:
> 
> +enum if_eec_src {
> +       IF_EEC_SRC_INVALID = 0,
> +       IF_EEC_SRC_UNKNOWN,
> +       IF_EEC_SRC_SYNCE,
> +       IF_EEC_SRC_GNSS,

Hmm, IDK if this really belongs in RTNL. The OCP time card that
Jonathan works on also wants to report signal lock, and it locks
to GNSS. It doesn't have any networking functionality whatsoever.

Can we add a genetlink family for clock info/configuration? From 
what I understood discussing this with Jonathan it sounded like most
clocks today have a vendor-specific character device for configuration
and reading status.

I'm happy to write the plumbing if this seems like an okay idea 
but too much work for anyone to commit.

> +       IF_EEC_SRC_PTP,
> +       IF_EEC_SRC_EXT,
> +       __IF_EEC_SRC_MAX,
> +};
> 
> But I guess your list is reasonable.  It can always be expanded, right?

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Mon, 30 Aug 2021 16:29:09 -0700	[thread overview]
Message-ID: <20210830162909.110753ec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210830205758.GA26230@hoboy.vegasvil.org>

On Mon, 30 Aug 2021 13:57:58 -0700 Richard Cochran wrote:
> > Please take a look at the 10.2 Operation modes of the G.8264 and at the Figure A.1
> > which depicts the EEC. This interface is to report the status of the EEC.  
> 
> Well, I read it, and it is still fairly high level with no mention at
> all of "DPLL".  I hope that the new RTNL states will cover other
> possible EEC implementations, too.
> 
> The "Reference source selection mechanism" is also quite vague.  Your
> patch is more specific:
> 
> +enum if_eec_src {
> +       IF_EEC_SRC_INVALID = 0,
> +       IF_EEC_SRC_UNKNOWN,
> +       IF_EEC_SRC_SYNCE,
> +       IF_EEC_SRC_GNSS,

Hmm, IDK if this really belongs in RTNL. The OCP time card that
Jonathan works on also wants to report signal lock, and it locks
to GNSS. It doesn't have any networking functionality whatsoever.

Can we add a genetlink family for clock info/configuration? From 
what I understood discussing this with Jonathan it sounded like most
clocks today have a vendor-specific character device for configuration
and reading status.

I'm happy to write the plumbing if this seems like an okay idea 
but too much work for anyone to commit.

> +       IF_EEC_SRC_PTP,
> +       IF_EEC_SRC_EXT,
> +       __IF_EEC_SRC_MAX,
> +};
> 
> But I guess your list is reasonable.  It can always be expanded, right?

  reply	other threads:[~2021-08-30 23:29 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29  8:05 [RFC v2 net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-29  8:05 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-29  8:05 ` [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-29  8:05   ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-29 15:10   ` Richard Cochran
2021-08-29 15:10     ` [Intel-wired-lan] " Richard Cochran
2021-08-29 16:42     ` Machnikowski, Maciej
2021-08-29 16:42       ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-29 20:16       ` Andrew Lunn
2021-08-29 20:16         ` [Intel-wired-lan] " Andrew Lunn
2021-08-30 20:57       ` Richard Cochran
2021-08-30 20:57         ` [Intel-wired-lan] " Richard Cochran
2021-08-30 23:29         ` Jakub Kicinski [this message]
2021-08-30 23:29           ` Jakub Kicinski
2021-08-31 10:20           ` Machnikowski, Maciej
2021-08-31 10:20             ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 13:33             ` Jakub Kicinski
2021-08-31 13:33               ` [Intel-wired-lan] " Jakub Kicinski
2021-08-31 14:07               ` Machnikowski, Maciej
2021-08-31 14:07                 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 14:18                 ` Jakub Kicinski
2021-08-31 14:18                   ` [Intel-wired-lan] " Jakub Kicinski
2021-08-31 15:19                   ` Machnikowski, Maciej
2021-08-31 15:19                     ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 15:32                     ` Jakub Kicinski
2021-08-31 15:32                       ` [Intel-wired-lan] " Jakub Kicinski
2021-08-31 16:00                       ` Machnikowski, Maciej
2021-08-31 16:00                         ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 16:19           ` Richard Cochran
2021-08-31 16:19             ` [Intel-wired-lan] " Richard Cochran
2021-08-31 22:09             ` Machnikowski, Maciej
2021-08-31 22:09               ` [Intel-wired-lan] " Machnikowski, Maciej
2021-09-01  2:02               ` Jakub Kicinski
2021-09-01  2:02                 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-01  2:56                 ` Richard Cochran
2021-09-01  2:56                   ` [Intel-wired-lan] " Richard Cochran
2021-09-01  1:58             ` Jakub Kicinski
2021-09-01  1:58               ` [Intel-wired-lan] " Jakub Kicinski
2021-09-01  2:55               ` Richard Cochran
2021-09-01  2:55                 ` [Intel-wired-lan] " Richard Cochran
2021-08-29  8:05 ` [RFC v2 net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-08-29  8:05   ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-29 11:11   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830162909.110753ec@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=abyagowi@fb.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bsd@fb.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maciej.machnikowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.