All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olga Kornievskaia <olga.kornievskaia@gmail.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
	chuck.level@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: [RFC 0/2] revisit RMDA XDR padding management
Date: Mon, 30 Aug 2021 12:53:00 -0400	[thread overview]
Message-ID: <20210830165302.60225-1-olga.kornievskaia@gmail.com> (raw)

From: Olga Kornievskaia <kolga@netapp.com>

We have previously revisited how XDR padding management was done
for the RDMA read chunks.

This patch series attempts to do the same for the RDMA read chunks
and altogether remove the options of doing an implicit roundup.

According to the RFC 8166 client "SHOULD NOT" include additional
space for XDR roundup padding. Furthermore, server MUST NOT write
XDR padding into the a write chunk. Given those two statement and
a patch "NFS: Always provide aligned buffers to the RPC read layers",
there is no reason for the client to look at the tail and assume
there is any padding data for which it needs to allocate space for.

The only operation that this patch series effects is an NFS read.
All non-read ops that might use a write chunk are setup to use
reply chunk if reply is larger than inline threshold, not a write
chunk.



*** SUBJECT HERE ***

*** BLURB HERE ***

Olga Kornievskaia (2):
  xprtrdma: xdr pad optimization revisted again
  xprtrdma: remove re_implicit_roundup xprt_rdma_pad_optimize

 net/sunrpc/xprtrdma/rpc_rdma.c  | 15 ---------------
 net/sunrpc/xprtrdma/transport.c |  8 --------
 net/sunrpc/xprtrdma/verbs.c     |  2 --
 net/sunrpc/xprtrdma/xprt_rdma.h |  6 ------
 4 files changed, 31 deletions(-)

-- 
2.27.0


             reply	other threads:[~2021-08-30 16:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 16:53 Olga Kornievskaia [this message]
2021-08-30 16:53 ` [RFC 1/2] xprtrdma: xdr pad optimization revisted again Olga Kornievskaia
2021-08-30 17:04   ` Chuck Lever III
2021-08-30 17:24     ` Olga Kornievskaia
2021-08-30 17:34       ` Trond Myklebust
2021-08-30 18:02         ` Chuck Lever III
2021-08-30 18:18           ` Trond Myklebust
2021-08-30 20:37             ` Chuck Lever III
2021-08-31 14:33               ` Chuck Lever III
2021-08-31 15:58                 ` Olga Kornievskaia
2021-08-31 16:11                   ` Chuck Lever III
2021-08-31 15:54               ` Olga Kornievskaia
2021-08-31 16:02                 ` Chuck Lever III
2021-08-30 17:35       ` Chuck Lever III
2021-08-30 16:53 ` [RFC 2/2] xprtrdma: remove re_implicit_roundup xprt_rdma_pad_optimize Olga Kornievskaia
2021-08-30 16:57   ` Chuck Lever III
2021-08-30 16:55 ` [RFC 0/2] revisit RMDA XDR padding management Olga Kornievskaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830165302.60225-1-olga.kornievskaia@gmail.com \
    --to=olga.kornievskaia@gmail.com \
    --cc=anna.schumaker@netapp.com \
    --cc=chuck.level@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.