From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mKkDr-0002Rp-Ar for mharc-grub-devel@gnu.org; Mon, 30 Aug 2021 12:33:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKkDo-0002P1-Do for grub-devel@gnu.org; Mon, 30 Aug 2021 12:33:20 -0400 Received: from cyberdimension.org ([80.67.179.20]:56790 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1mKkDl-0003dU-Fj for grub-devel@gnu.org; Mon, 30 Aug 2021 12:33:20 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id d87a268a; Mon, 30 Aug 2021 16:31:01 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id a6a72391; Mon, 30 Aug 2021 16:31:01 +0000 (UTC) Date: Mon, 30 Aug 2021 18:33:15 +0200 From: Denis 'GNUtoo' Carikli To: Daniel Kiper Cc: Glenn Washburn , grub-devel@gnu.org, ps@pks.im Subject: Re: [PATCH 00/12] Grub-shell improvements Message-ID: <20210830183315.65b020ab@primarylaptop.localdomain> In-Reply-To: <20210830152344.v6rgven6wnpnygcg@tomti.i.net-space.pl> References: <20210825180630.5378bb5c@crass-HP-ZBook-15-G2> <20210826180032.qf7z5ybrizro3wdt@tomti.i.net-space.pl> <20210826170821.040d202b@crass-HP-ZBook-15-G2> <20210830152344.v6rgven6wnpnygcg@tomti.i.net-space.pl> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Htcb.sBKtw4b0JNCrl..DoD"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 16:33:20 -0000 --Sig_/Htcb.sBKtw4b0JNCrl..DoD Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 30 Aug 2021 17:23:44 +0200 Daniel Kiper wrote: > CC-ing Denis and Patrick... >=20 > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > On Thu, 26 Aug 2021 20:00:32 +0200 > > Daniel Kiper wrote: > > > > > Hi Glenn, > > > > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > > > Hi Daniel, > > > > > > > > What are the chances this patch series can be reviewed in the > > > > near future? Some feedback would be greatly appreciated. > > > > > > I can see the following patches from you waiting in my review > > > queue: > > > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for > > > cryptodisks+luks2 and a few other things. > > > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html > > > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount > > > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.ht= ml > > > - [PATCH 0/5] Testing improvements > > > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.ht= ml > > > - [CI 00/17] Gitlab CI and test framework improvements > > > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.ht= ml > > > - [PROCFS 0/5] Add and improve (proc) entries > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.ht= ml > > > - [PATCH 0/4] Various LUKS2 improvements > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.ht= ml > > > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.ht= ml > > > - [PATCH] fs: Allow number of blocks in block list to be > > > optional, defaulting length to device length > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > > > dash-insensitive manner > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html > > > - [PATCH] command: Add silent mode to read command to suppress > > > input echo > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > > - [PATCH 0/2] Allow overriding commands > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.ht= ml > > > - [PATCH 00/12] Grub-shell improvements > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.ht= ml > > > - [PATCH v2 0/8] Various fixes/improvements for tests > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.ht= ml > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to > > > crypto modules > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > > > Please sort them in the order of importance/preference/... Then I > > > will be looking at them (more or less) in that order, one patch > > > set at a time. > > > > > > I hope I did not miss any of your patches. > > > > As far as I can tell, this is the full list. >=20 > Great! >=20 > > My order preference is as follows: > > > > These two patches are only first because it should be a quick > > review. > > - [PATCH] command: Add silent mode to read command to suppress > > input echo > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > - [PATCH] fs: Allow number of blocks in block list to be optional, > > defaulting length to device length > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html >=20 > OK. >=20 > > This is a high priority because I think it should be merged before > > the keyfile and detached header support patch series. If this is > > merged, I'll submit and updated keyfile and detached header patch > > series that works with this patch series. > > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > > modules > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html >=20 > Denis, Patrick, are you both OK with this? I'm OK with it. The "Refactor/improve cryptomount data passing to crypto modules" looks way cleaner than what we had before: it can scale better than the previous design because it's more generic, it can be extended more easily, and we can have more fine grained communication between the cryptodisk and the backends. Glenn Washburn wrote: > My intention is for this patch series to lay the foundation for an > improved patch series providing detached header and keyfile support > (I already have the series updated and ready to send once this is > accepted). Thanks a lot for that work and for taking care of the patch serie I sent. Denis. --Sig_/Htcb.sBKtw4b0JNCrl..DoD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmEtCE0ACgkQX138wUF3 4mNcNQ//WQCriF1tCCIPKnEB40HEfdLlGUcI+1CMTBTqBY7kAmJOgZ0VsyvV2OcR k/Wv8Hn9Em9C3lHERO0oZZ7UrhuxvZH3DB/q9imkRwqVxRvcuG745LJVxw4AyC3T nMY20xv4G2IcOezgexF31hiizkBABR/UF2wh89mn5xb0iJxg6lQ+XSpqBdnUsOMn wOY3TfaTBnNNblmqdJ8g9Zkk35vqZQ/3gckZs/srY3Fcw/VgmmHaU1uoqxmGkdnA GunQcGtuKH7aB3uDG5zE3I6MwcRJuYA90sNzCi8zFInBvOR3lVt0f9JGPXRM6Owv hEARAjuTqxGDMvZ0Vi2gOOERxPOMacWfiWAsn2wleOf929irLKqMIG3ZCRUgB5+a vT8DjrF23trE4NFZ4silZT1trMgzDt5cBUjn8fWrwaGJGzJ2LwmVoR3Vulz0RU41 TIcwaF/PVQ3qV1lgvZ1DHQip7YMW/Vg1Jr/GI1534YLFOsEZutmBQdkUMoBlDtt+ A+Y2xhm4iH/ZPGvWm+MPBve4LjuHoeC6ofFuuVexJDslYmq4m6kMSBBogRNJL3wt qu4n/1ng/Uw05QOO7pH8FutjL9zfWuByC39dA/crl57wlwClHUTt30uvNJgRfyaB Xy8AiPV9k4GT/0yy7yfEHEIn1860BtioLukQN15eILXz7IFWgfM= =yV8s -----END PGP SIGNATURE----- --Sig_/Htcb.sBKtw4b0JNCrl..DoD--