From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5806C432BE for ; Tue, 31 Aug 2021 02:51:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 156BE60FE8 for ; Tue, 31 Aug 2021 02:51:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 156BE60FE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56CC183406; Tue, 31 Aug 2021 04:51:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NrhSLyPs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 472B883403; Tue, 31 Aug 2021 04:51:37 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 214D1833FF for ; Tue, 31 Aug 2021 04:51:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id ay33so18025274qkb.10 for ; Mon, 30 Aug 2021 19:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dfILbl6bId2ac7uTfgaZO4mmwC5NCbbgyJsTnqvMBFQ=; b=NrhSLyPs3vmJkWNTFknRz130KQVL/IVdxdFiZ6RrWlVNofaaYYLN79BlvwKZk2Hr7g N3gz3oUH7pltoji2a7bowUOj7EC5befHoyMr7dQxd1csooxlsJxRGHFL6fSwo8Rddxgc Mw4Fqz85+c7CfkOWZINr+MMCfReLOg7mWBxWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dfILbl6bId2ac7uTfgaZO4mmwC5NCbbgyJsTnqvMBFQ=; b=bM/d2DPaOTtDHouNit0KHTrugD4QOl5nflgln9R5tSmmoLf85SMFmld98CaJvUkbm+ 5hI7HfL91mf3+2odf+LHjy9CMHiZ7sNpOMwcdzqiPPJ6jvcPjhbrwaVSchiRnKa7eQaQ rFgibI9HnZOWJclGm1fZb8DmfyCgPuL1bZbVUAo/xUtox3FOV42fee7zGlIForMOLeJD szOBmQ5mSWxQOuGYj5FXigG1UKWZrJa3Mn5SMtSNDcTQ+xUXdrh1sXwjXxEx4/8qWDlN Lw9paGMkr9p4hSYCd9q9xopev9YgSuS9ePJymm8i0JFAXyl3UrCZnVW2f/IrTJyxQs9l EWZg== X-Gm-Message-State: AOAM532uZEUDLGxGi3aYZHuWQ+Xif8iLbiBdCNYzcARccDyBF//FN0Pj Z6xINeEtvrCBkWzyWiox+RIMhg== X-Google-Smtp-Source: ABdhPJy/N6jeSK9/G5yDW3ubU4XYZMRlmKadxw2SZcPj1LoYS6aASCdKEUnslJ9SWgH1MEHai0Yw/w== X-Received: by 2002:a37:8183:: with SMTP id c125mr844686qkd.134.1630378290979; Mon, 30 Aug 2021 19:51:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-8d75-4e9a-efec-7167.res6.spectrum.com. [2603:6081:7b01:cbda:8d75:4e9a:efec:7167]) by smtp.gmail.com with ESMTPSA id i27sm12724253qkl.111.2021.08.30.19.51.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Aug 2021 19:51:30 -0700 (PDT) Date: Mon, 30 Aug 2021 22:51:28 -0400 From: Tom Rini To: Daniel Schwierzeck Cc: u-boot@lists.denx.de, Alexey Brodkin , Anup Patel , Atish Patra , Bin Meng , Leo , Palmer Dabbelt , Paul Walmsley , Rick Chen , Sean Anderson , Simon Glass Subject: Re: [PATCH] Finish converting CONFIG_SYS_CACHELINE_SIZE to Kconfig Message-ID: <20210831025128.GA858@bill-the-cat> References: <20210826154759.19731-1-trini@konsulko.com> <42196c51c9d36df50634b3c5f05b87891b00d1bd.camel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gwoyZRC6ZedlKsIt" Content-Disposition: inline In-Reply-To: <42196c51c9d36df50634b3c5f05b87891b00d1bd.camel@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --gwoyZRC6ZedlKsIt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2021 at 04:12:21AM +0200, Daniel Schwierzeck wrote: > Am Donnerstag, dem 26.08.2021 um 11:47 -0400 schrieb Tom Rini: > > We move the SYS_CACHE_SHIFT_N options from arch/arm/Kconfig to > > arch/Kconfig, and introduce SYS_CACHE_SHIFT_4 to provide a size of > > 16. > > Introduce select statements for other architectures based on current > > usage. For MIPS, we take the existing arch-specific symbol and > > migrate > > to the generic symbol. This lets us remove a little bit of otherwise > > unused code. > >=20 > > Cc: Alexey Brodkin > > Cc: Anup Patel > > Cc: Atish Patra > > Cc: Bin Meng > > Cc: Daniel Schwierzeck > > Cc: Leo > > Cc: Palmer Dabbelt > > Cc: Paul Walmsley > > Cc: Rick Chen > > Cc: Sean Anderson > > Cc: Simon Glass > > Signed-off-by: Tom Rini > > --- > > I'm Cc'ing a bunch of RISC-V folks since that's where I'm least > > confident and just put it per-board for now. > > --- > > arch/Kconfig | 25 +++++++++++++++++++++++++ > > arch/arc/include/asm/cache.h | 3 --- > > arch/arm/Kconfig | 15 --------------- > > arch/mips/Kconfig | 26 +++----------------------- > > arch/mips/include/asm/cache.h | 12 +----------- > > arch/mips/mach-bmips/Kconfig | 20 ++++++++++---------- > > arch/mips/mach-mtmips/Kconfig | 4 ++-- > > arch/mips/mach-pic32/Kconfig | 2 +- > > arch/powerpc/cpu/mpc83xx/Kconfig | 6 ++++++ > > arch/powerpc/cpu/mpc85xx/Kconfig | 15 +++++++++++++++ > > arch/powerpc/cpu/mpc8xx/Kconfig | 2 ++ > > arch/powerpc/include/asm/cache.h | 7 ------- > > arch/riscv/Kconfig | 2 ++ > > arch/sandbox/include/asm/cache.h | 1 - > > arch/x86/include/asm/cache.h | 7 +------ > > include/configs/M5208EVBE.h | 1 - > > include/configs/M5235EVB.h | 1 - > > include/configs/M5249EVB.h | 1 - > > include/configs/M5253DEMO.h | 1 - > > include/configs/M5272C3.h | 1 - > > include/configs/M5275EVB.h | 1 - > > include/configs/M5282EVB.h | 1 - > > include/configs/M53017EVB.h | 1 - > > include/configs/M5329EVB.h | 1 - > > include/configs/M5373EVB.h | 1 - > > include/configs/amcore.h | 1 - > > include/configs/astro_mcf5373l.h | 1 - > > include/configs/cobra5272.h | 1 - > > include/configs/eb_cpu5282.h | 1 - > > include/configs/mx7ulp_evk.h | 2 -- > > include/configs/rk3188_common.h | 2 -- > > include/configs/rk3368_common.h | 2 -- > > include/configs/sifive-unmatched.h | 2 -- > > include/configs/sipeed-maix.h | 1 - > > include/configs/stmark2.h | 1 - > > 35 files changed, 68 insertions(+), 103 deletions(-) > >=20 > > diff --git a/arch/Kconfig b/arch/Kconfig > > index b6f9e177b645..25f4a15b19f9 100644 > > --- a/arch/Kconfig > > +++ b/arch/Kconfig > > @@ -7,6 +7,27 @@ config HAVE_ARCH_IOREMAP > > config NEEDS_MANUAL_RELOC > > bool > > =20 > > +config SYS_CACHE_SHIFT_4 > > + bool > > + > > +config SYS_CACHE_SHIFT_5 > > + bool > > + > > +config SYS_CACHE_SHIFT_6 > > + bool > > + > > +config SYS_CACHE_SHIFT_7 > > + bool > > + > > +config SYS_CACHELINE_SIZE > > + int > > + default 128 if SYS_CACHE_SHIFT_7 > > + default 64 if SYS_CACHE_SHIFT_6 > > + default 32 if SYS_CACHE_SHIFT_5 > > + default 16 if SYS_CACHE_SHIFT_4 > > + # Fall-back for MIPS > > + default 32 if MIPS >=20 > can't we get rid of the SYS_ prefix? Also _CACHE_ is ambiguous, > L1_CACHE_SHIFT_* and L1_CACHELINE_SIZE are possibly more suitable. > Otherwise: I don't see a problem to a follow-up renaming things for further clarity (and using L1 in the name makes sense), but I am for now trying to (as you've probably noticed) plow through the CONFIG backlog and get everything migrated. --=20 Tom --gwoyZRC6ZedlKsIt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEtmTAACgkQFHw5/5Y0 tyzZNQwAmb40ivaMyot1QoNaNKsGnzrnOxOrl0bFHgmsM86zlzC+D2Ykb4sIC7JD GbOjxdougw40SlCWKlKE7H7aFrxyE36VZ7MKu811M6PdF26sONkhjbz3eYgVKILj oonDnR/6KmodVKsIRspFshyjE5XV7nlQKB7LF+bKHEPRQIOiuTtL6wrxI+OZ8a2d Uc875b8Z4s905+dWt59A5rNpcfoTs8YxwsdgbyA+sewlmU4asmmO39Jbq1Xo4k6g C3ezVMTF+Ro8UmbCm4llUZQaRxR5Rzxk4XgPpVcBhpyumj9RtVrsD90wwNXO5M4f ZnsNBmosD9Jkw2zz2/wZKspkRnCBn/BzwR43m7ViSCng7lu9LPx/ZMdyMI02cxQO JelTczrZCgu5mGmx1i9wUZ90ZAh+n3+5jbyBdcvBbxnaems21u5RkDqML7REXW9p snKdn/XRK7wuKMGJ6n+M8Hwuq6XwBV7CtmdSXWagWuVrvPjPXAvWTpBjKyUd9Cda R3cRD0gI =QfF4 -----END PGP SIGNATURE----- --gwoyZRC6ZedlKsIt--