From: Jakub Kicinski <kuba@kernel.org>
To: "Machnikowski, Maciej" <maciej.machnikowski@intel.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"abyagowi@fb.com" <abyagowi@fb.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>, "Jonathan Lemon" <bsd@fb.com>
Subject: Re: [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Tue, 31 Aug 2021 06:33:04 -0700 [thread overview]
Message-ID: <20210831063304.4bcacbe3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <SJ0PR11MB4958029CF18F93846B29F685EACC9@SJ0PR11MB4958.namprd11.prod.outlook.com>
On Tue, 31 Aug 2021 10:20:18 +0000 Machnikowski, Maciej wrote:
> > Hmm, IDK if this really belongs in RTNL. The OCP time card that
> > Jonathan works on also wants to report signal lock, and it locks
> > to GNSS. It doesn't have any networking functionality whatsoever.
> >
> > Can we add a genetlink family for clock info/configuration? From
> > what I understood discussing this with Jonathan it sounded like most
> > clocks today have a vendor-specific character device for configuration
> > and reading status.
> >
> > I'm happy to write the plumbing if this seems like an okay idea
> > but too much work for anyone to commit.
> >
>
> I agree that this also is useful for Time card, yet it's also useful here.
> PTP subsystem should implement a similar logic to this one for
> DPLL-driven timers which can lock its frequency to external sources.
Why would we have two APIs for doing the same thing? IIUC Richard does
not want this in the PTP ioctls which is fair, but we need to cater to
devices which do not have netdevs.
> The reasoning behind putting it here is to enable returning the lock
> to the GNSS receiver embedded on the NIC as a source for the
> SyncE frequency. It helps distinguishing the embedded GNSS
> from the external sources. As a result - the upper layer can report
> GNSS lock based only on this message without the need to put the
> embedded GNSS receiver in the config file. On the other hand - if
> sync to External source is reported such SW would need to read
> the source of external sync from the config file.
>
> And the list is expandable - if we need to define more embedded
> sync source types we can always add more to it.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status
Date: Tue, 31 Aug 2021 06:33:04 -0700 [thread overview]
Message-ID: <20210831063304.4bcacbe3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <SJ0PR11MB4958029CF18F93846B29F685EACC9@SJ0PR11MB4958.namprd11.prod.outlook.com>
On Tue, 31 Aug 2021 10:20:18 +0000 Machnikowski, Maciej wrote:
> > Hmm, IDK if this really belongs in RTNL. The OCP time card that
> > Jonathan works on also wants to report signal lock, and it locks
> > to GNSS. It doesn't have any networking functionality whatsoever.
> >
> > Can we add a genetlink family for clock info/configuration? From
> > what I understood discussing this with Jonathan it sounded like most
> > clocks today have a vendor-specific character device for configuration
> > and reading status.
> >
> > I'm happy to write the plumbing if this seems like an okay idea
> > but too much work for anyone to commit.
> >
>
> I agree that this also is useful for Time card, yet it's also useful here.
> PTP subsystem should implement a similar logic to this one for
> DPLL-driven timers which can lock its frequency to external sources.
Why would we have two APIs for doing the same thing? IIUC Richard does
not want this in the PTP ioctls which is fair, but we need to cater to
devices which do not have netdevs.
> The reasoning behind putting it here is to enable returning the lock
> to the GNSS receiver embedded on the NIC as a source for the
> SyncE frequency. It helps distinguishing the embedded GNSS
> from the external sources. As a result - the upper layer can report
> GNSS lock based only on this message without the need to put the
> embedded GNSS receiver in the config file. On the other hand - if
> sync to External source is reported such SW would need to read
> the source of external sync from the config file.
>
> And the list is expandable - if we need to define more embedded
> sync source types we can always add more to it.
next prev parent reply other threads:[~2021-08-31 13:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 8:05 [RFC v2 net-next 0/2] Add RTNL interface for SyncE Maciej Machnikowski
2021-08-29 8:05 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-29 8:05 ` [RFC v2 net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status Maciej Machnikowski
2021-08-29 8:05 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-29 15:10 ` Richard Cochran
2021-08-29 15:10 ` [Intel-wired-lan] " Richard Cochran
2021-08-29 16:42 ` Machnikowski, Maciej
2021-08-29 16:42 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-29 20:16 ` Andrew Lunn
2021-08-29 20:16 ` [Intel-wired-lan] " Andrew Lunn
2021-08-30 20:57 ` Richard Cochran
2021-08-30 20:57 ` [Intel-wired-lan] " Richard Cochran
2021-08-30 23:29 ` Jakub Kicinski
2021-08-30 23:29 ` [Intel-wired-lan] " Jakub Kicinski
2021-08-31 10:20 ` Machnikowski, Maciej
2021-08-31 10:20 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 13:33 ` Jakub Kicinski [this message]
2021-08-31 13:33 ` Jakub Kicinski
2021-08-31 14:07 ` Machnikowski, Maciej
2021-08-31 14:07 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 14:18 ` Jakub Kicinski
2021-08-31 14:18 ` [Intel-wired-lan] " Jakub Kicinski
2021-08-31 15:19 ` Machnikowski, Maciej
2021-08-31 15:19 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 15:32 ` Jakub Kicinski
2021-08-31 15:32 ` [Intel-wired-lan] " Jakub Kicinski
2021-08-31 16:00 ` Machnikowski, Maciej
2021-08-31 16:00 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-08-31 16:19 ` Richard Cochran
2021-08-31 16:19 ` [Intel-wired-lan] " Richard Cochran
2021-08-31 22:09 ` Machnikowski, Maciej
2021-08-31 22:09 ` [Intel-wired-lan] " Machnikowski, Maciej
2021-09-01 2:02 ` Jakub Kicinski
2021-09-01 2:02 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-01 2:56 ` Richard Cochran
2021-09-01 2:56 ` [Intel-wired-lan] " Richard Cochran
2021-09-01 1:58 ` Jakub Kicinski
2021-09-01 1:58 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-01 2:55 ` Richard Cochran
2021-09-01 2:55 ` [Intel-wired-lan] " Richard Cochran
2021-08-29 8:05 ` [RFC v2 net-next 2/2] ice: add support for reading SyncE DPLL state Maciej Machnikowski
2021-08-29 8:05 ` [Intel-wired-lan] " Maciej Machnikowski
2021-08-29 11:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831063304.4bcacbe3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=abyagowi@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bsd@fb.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.machnikowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.