Re: [RFC 4/4] Bluetooth: RFCOMM: Replace use of memcpy_from_msg with bt_skb_sendmmsg

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3028 bytes --]

Hi Luiz,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bluetooth-next/master]
[cannot apply to bluetooth/master v5.14 next-20210830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-Add-bt_skb_sendmsg-helper/20210831-091735
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a2468415c162f27c7def3dd53acdb62cf084afdd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luiz-Augusto-von-Dentz/Bluetooth-Add-bt_skb_sendmsg-helper/20210831-091735
        git checkout a2468415c162f27c7def3dd53acdb62cf084afdd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/bluetooth/rfcomm/sock.c: In function 'rfcomm_sock_sendmsg':
>> net/bluetooth/rfcomm/sock.c:561:16: warning: variable 'size' set but not used [-Wunused-but-set-variable]
     561 |         size_t size;
         |                ^~~~


vim +/size +561 net/bluetooth/rfcomm/sock.c

   555	
   556	static int rfcomm_sock_sendmsg(struct socket *sock, struct msghdr *msg,
   557				       size_t len)
   558	{
   559		struct sock *sk = sock->sk;
   560		struct rfcomm_dlc *d = rfcomm_pi(sk)->dlc;
 > 561		size_t size;
   562		struct sk_buff *skb;
   563		int sent;
   564	
   565		if (test_bit(RFCOMM_DEFER_SETUP, &d->flags))
   566			return -ENOTCONN;
   567	
   568		if (msg->msg_flags & MSG_OOB)
   569			return -EOPNOTSUPP;
   570	
   571		if (sk->sk_shutdown & SEND_SHUTDOWN)
   572			return -EPIPE;
   573	
   574		BT_DBG("sock %p, sk %p", sock, sk);
   575	
   576		lock_sock(sk);
   577	
   578		size = min_t(size_t, len, d->mtu);
   579	
   580		sent = bt_sock_wait_ready(sk, msg->msg_flags);
   581	
   582		release_sock(sk);
   583	
   584		if (sent)
   585			return sent;
   586	
   587		skb = bt_skb_sendmmsg(sk, msg, len, d->mtu, RFCOMM_SKB_RESERVE);
   588		if (IS_ERR_OR_NULL(skb))
   589			return PTR_ERR(skb);
   590	
   591		sent = rfcomm_dlc_send(d, skb);
   592		if (sent < 0)
   593			kfree_skb(skb);
   594	
   595		return sent;
   596	}
   597	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60756 bytes --]