All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH v2 0/3] softmmu/vl: Deprecate old and crufty display ui options
Date: Tue, 31 Aug 2021 14:21:35 +0200	[thread overview]
Message-ID: <20210831122135.ksdxstfnsyoatdje@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210825092023.81396-1-thuth@redhat.com>

On Wed, Aug 25, 2021 at 11:20:20AM +0200, Thomas Huth wrote:
> -display sdl uses a hand-crafted parser in vl.c, which is quite ugly
> since the other parts of -display have been QAPIfied already. A straight
> conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab"
> parameters are not the best solution anyway. So this patch series
> introduces a new "grab-mod" parameter as replacement instead and then
> deprecates the old and crufty options.
> 
> While we're at it, the third patch also suggests to deprecated the
> old -sdl and -curses top-level options.

Looks all sane to me.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd



      parent reply	other threads:[~2021-08-31 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  9:20 [PATCH v2 0/3] softmmu/vl: Deprecate old and crufty display ui options Thomas Huth
2021-08-25  9:20 ` [PATCH v2 1/3] softmmu/vl: Add a "grab-mod" parameter to the -display sdl option Thomas Huth
2021-08-25  9:20 ` [PATCH v2 2/3] softmmu/vl: Deprecate the old grab options Thomas Huth
2021-08-31 13:54   ` Paolo Bonzini
2021-08-25  9:20 ` [PATCH v2 3/3] softmmu/vl: Deprecate the -sdl and -curses option Thomas Huth
2021-08-31 13:53   ` Paolo Bonzini
2021-09-02 10:51     ` Thomas Huth
2021-09-02 10:58       ` Daniel P. Berrangé
2021-09-02 11:21         ` Thomas Huth
2021-09-02 11:37         ` Markus Armbruster
2021-09-02 13:21         ` Gerd Hoffmann
2021-08-31 12:21 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210831122135.ksdxstfnsyoatdje@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.