From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFD8C432BE for ; Tue, 31 Aug 2021 12:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7857B60F92 for ; Tue, 31 Aug 2021 12:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233827AbhHaNAE (ORCPT ); Tue, 31 Aug 2021 09:00:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50241 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233575AbhHaM75 (ORCPT ); Tue, 31 Aug 2021 08:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630414742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VFi9mk+JrNYqm9om9cI3aYM4Tz+JK5QNKRVw7UvYJXE=; b=IwsU7QwrwZoqqfg9gxTDolrNRIRtOe52u8LmNMVzPvrHIJzfyy4IXxpQKqM1/a+gVzqwf3 vR4HcfQkqG1h6fLP8I51z/HQd0DCS7rGr7pVtgki45qZk4ncbjPj4rnJ+EB378t8E1D53H UpXxmu0Uzki4PJ+t9kZYI/JXB6mtiHY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-rtbtUp0KOmG-B6ntOSwDCg-1; Tue, 31 Aug 2021 08:59:00 -0400 X-MC-Unique: rtbtUp0KOmG-B6ntOSwDCg-1 Received: by mail-wr1-f70.google.com with SMTP id q11-20020a5d61cb0000b02901550c3fccb5so4007836wrv.14 for ; Tue, 31 Aug 2021 05:59:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VFi9mk+JrNYqm9om9cI3aYM4Tz+JK5QNKRVw7UvYJXE=; b=jbNvcAlmhzRZP/PUycFVHBwR+HZQrRwaWQWwJsE2WOcliepgk7DjI5j7AFpsuB1pjJ uNr3Ae9Pb/IHbJR/3RYV8Yz1PXIXoAzfef6shNTXOmBkwwsC9aYDo0izS8yviGMjsg8U R11o0pe3NkVBSyC7PeKD9U0AYvZbzr/kyzZxbzW+SwavmGK5ZDga+GRwiNMjojJJ4MFW 9tkjNm42P+HT03AxV4q34YgOsZ5VxPj84dmuzOKceGfgIDcEifEEKjzdEEh5L271t+0+ unBEkXa3aYO+BScnAhO4MUNyTgovoguMsQ5Lw7H24zzJ6fO0X1VG4G9NvKcdcCDt3pzf TLDA== X-Gm-Message-State: AOAM530kBMwYgdRMZDSC31YcH/OphC7zhnNc2cOnfZTA2P2dXhjzn+Di dB9Ngz3pErlfLbgulTAA0KNnblU7WvijeN76j96DbwOhe0GIWIqVMswTOkiuD/wK87adPL83oms kdWlm4YmaTw8m/6bAIfrMad4l X-Received: by 2002:a5d:6e84:: with SMTP id k4mr30756122wrz.426.1630414739547; Tue, 31 Aug 2021 05:58:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzflIax6tFxvMs9mjbd8B1Mb2iEt9SCQmR/++VhwuAoQyhS9HpVASDt6bCiXW4+7etv8yFh8w== X-Received: by 2002:a5d:6e84:: with SMTP id k4mr30756112wrz.426.1630414739351; Tue, 31 Aug 2021 05:58:59 -0700 (PDT) Received: from vian.redhat.com ([2a0c:5a80:3c08:b500:afb2:5ebc:3fd2:26de]) by smtp.gmail.com with ESMTPSA id a133sm2553199wme.5.2021.08.31.05.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 05:58:59 -0700 (PDT) From: Nicolas Saenz Julienne To: robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan.wahren@i2se.com, Nicolas Saenz Julienne , Rob Herring Subject: [PATCH v2 2/2] ARM: dts: bcm2711-rpi-4-b: Fix usb's unit address Date: Tue, 31 Aug 2021 14:58:43 +0200 Message-Id: <20210831125843.1233488-2-nsaenzju@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210831125843.1233488-1-nsaenzju@redhat.com> References: <20210831125843.1233488-1-nsaenzju@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The unit address is supposed to represent ','. Which are both 0 for RPi4b's XHCI controller. On top of that although OpenFirmware states bus number goes in the high part of the last reg parameter, FDT doesn't seem to care for it[1], so remove it. [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633 Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") Suggested-by: Rob Herring Signed-off-by: Nicolas Saenz Julienne --- Chages since v1: - Add patch as per robh suggestion arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index 8377dc14b7b5..50530cc91876 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -225,8 +225,8 @@ pci@0,0 { reg = <0 0 0 0 0>; - usb@1,0 { - reg = <0x10000 0 0 0 0>; + usb@0,0 { + reg = <0 0 0 0 0>; resets = <&reset RASPBERRYPI_FIRMWARE_RESET_ID_USB>; }; }; -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC9BC432BE for ; Tue, 31 Aug 2021 13:01:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EABD60E98 for ; Tue, 31 Aug 2021 13:01:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7EABD60E98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGKRA4IXvrqgrPBksgtRSgqP75Jrfg+Y2f4R9ygRDtU=; b=ROtJSx9djD5jAL QRX+5rWfeKkcaiXozrjlmsRdeGAsa6txaK4xwOa+5MkDQKjnUEJbca93LxnmiRNw8EcAV4CkLu3vJ 6H/bTUeEW/V8QisfY0h+pEj8mmQjXgOUP/lApC98UjP6AxpfnyIeM9NX/kfUAE0OsQp1UMBLmu0bw 0HgjwkDnwlINSl64cvTbj/NfNTaG6NDwX/bp/LpzKLUN601rfKfxNMcwBY9dRVcEn8p3FkkvJMalc Qh00HH49oAh17aL4l/WhLJzxEBV8ueKLvdXbptmtKOUmobXQlizJNEQD1SOyVmH0mpqlv4llOOn2c hFJFS73rpIP27b0GQERQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mL3M5-002GuM-Of; Tue, 31 Aug 2021 12:59:09 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mL3M1-002Grq-9C for linux-arm-kernel@lists.infradead.org; Tue, 31 Aug 2021 12:59:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630414742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VFi9mk+JrNYqm9om9cI3aYM4Tz+JK5QNKRVw7UvYJXE=; b=X0Ls1UZ8/Hv4aGqMEO9ZXme27VI9ogy4PDiPT9e3q5KBpwgUeTZcfUnLZetWZ3R/6w9j5L 87NfYXrjyYv40xGA/YxY95D/O14BoAxSHbcBEM9gYEIm04UT5a3e7Jl0yoZl4qHdQH4Hkn 7SdKYQ/VoWSCH1F3R7jUwCl+wioHRCE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-S36P1dUlMimG5wpsYj2uWA-1; Tue, 31 Aug 2021 08:59:00 -0400 X-MC-Unique: S36P1dUlMimG5wpsYj2uWA-1 Received: by mail-wr1-f69.google.com with SMTP id 102-20020adf82ef000000b001576e345169so4006875wrc.7 for ; Tue, 31 Aug 2021 05:59:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VFi9mk+JrNYqm9om9cI3aYM4Tz+JK5QNKRVw7UvYJXE=; b=RWxRYix7fLM7xtUucwxlFJYa196qA2ZWxM+JtCrELrcPnPYSTu9hI9CuV7h2acFAnL 2HwzswGJRw7EK2FC66Y2KEAvCzFMZQgzKGaqG1Oxs79F3tz1UhIX/B0YNvqxasbM0eqn fppPDhqKfiuENQh7x+6wSJ2YB7NdFkmKNK8wP4BTZ7aqf4da/7RFnsNDdX94QFGN40Es ABRq4BTPKahRlHjryRBcDGnj50TaCb2xYAj2rQKmOW2/ZpkvAczimzYPaOaWPGJhsDbU kVtppcPeuEk3XHNRMegTrDs3lOk4PAV7q47y3qpSVQ/wQywuc3ismkmeTztqY497i56e Y1QQ== X-Gm-Message-State: AOAM533+Wb1L13mPlF1jaMYX1/g3m9sxNEhx4TF90ZQ/g4agg9E8mSbm WzIsQJ53+8p9Ph7ziTHk0KLk5JBWVxCzNJ+NQ20nejfAIHo4BlnwoX0n7Wm/iQERcYEcnzPNkKA fvUDEouiDHD6tpNXyAnpZ3MldFsgFOICqfOA= X-Received: by 2002:a5d:6e84:: with SMTP id k4mr30756124wrz.426.1630414739547; Tue, 31 Aug 2021 05:58:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzflIax6tFxvMs9mjbd8B1Mb2iEt9SCQmR/++VhwuAoQyhS9HpVASDt6bCiXW4+7etv8yFh8w== X-Received: by 2002:a5d:6e84:: with SMTP id k4mr30756112wrz.426.1630414739351; Tue, 31 Aug 2021 05:58:59 -0700 (PDT) Received: from vian.redhat.com ([2a0c:5a80:3c08:b500:afb2:5ebc:3fd2:26de]) by smtp.gmail.com with ESMTPSA id a133sm2553199wme.5.2021.08.31.05.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 05:58:59 -0700 (PDT) From: Nicolas Saenz Julienne To: robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan.wahren@i2se.com, Nicolas Saenz Julienne , Rob Herring Subject: [PATCH v2 2/2] ARM: dts: bcm2711-rpi-4-b: Fix usb's unit address Date: Tue, 31 Aug 2021 14:58:43 +0200 Message-Id: <20210831125843.1233488-2-nsaenzju@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210831125843.1233488-1-nsaenzju@redhat.com> References: <20210831125843.1233488-1-nsaenzju@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=nsaenzju@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_055905_447312_C1305C88 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The unit address is supposed to represent ','. Which are both 0 for RPi4b's XHCI controller. On top of that although OpenFirmware states bus number goes in the high part of the last reg parameter, FDT doesn't seem to care for it[1], so remove it. [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633 Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") Suggested-by: Rob Herring Signed-off-by: Nicolas Saenz Julienne --- Chages since v1: - Add patch as per robh suggestion arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index 8377dc14b7b5..50530cc91876 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -225,8 +225,8 @@ pci@0,0 { reg = <0 0 0 0 0>; - usb@1,0 { - reg = <0x10000 0 0 0 0>; + usb@0,0 { + reg = <0 0 0 0 0>; resets = <&reset RASPBERRYPI_FIRMWARE_RESET_ID_USB>; }; }; -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel