From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev
Cc: Kari Argillander <kari.argillander@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] fs/ntfs3: Fix various styling issues
Date: Tue, 31 Aug 2021 21:15:00 +0300 [thread overview]
Message-ID: <20210831181505.1074767-1-kari.argillander@gmail.com> (raw)
Many new checkpatch warnings have been introduce to ntfs3. These could
have been prevent if checkpatch is used. One thing that worrys me is
that Konstantin puts new code without code reviewing process to ntfs3.
Patch commit message says one thing, but one huge patch address that and
lot of just refactoring code. Also with review process we can prevent
these kind of silly checkpatch mistakes.
Kmalloc_array was my fault for some reason checkpatch did not show
those. I have no idea how, but I just fix it now and be very ashamed.
You should also Konstantin use checkpatch always before push so you can
spot these things before hand. I will try to get CI going for patches.
Kari Argillander (5):
fs/ntfs3: Use kmalloc_array over kmalloc with multiply
fs/ntfs3: Use consistent spacing around '+'
fs/ntfs3: Place Comparisons constant right side of the test
fs/ntfs3: Remove braces from single statment block
fs/ntfs3: Remove tabs before spaces from comment
fs/ntfs3/bitmap.c | 2 +-
fs/ntfs3/frecord.c | 8 ++++----
fs/ntfs3/index.c | 4 ++--
fs/ntfs3/lznt.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
base-commit: d3624466b56dd5b1886c1dff500525b544c19c83
--
2.25.1
next reply other threads:[~2021-08-31 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 18:15 Kari Argillander [this message]
2021-08-31 18:15 ` [PATCH 1/5] fs/ntfs3: Use kmalloc_array over kmalloc with multiply Kari Argillander
2021-09-01 2:40 ` Joe Perches
2021-09-01 13:24 ` Kari Argillander
2021-09-02 14:03 ` David Laight
2021-08-31 18:15 ` [PATCH 2/5] fs/ntfs3: Use consistent spacing around '+' Kari Argillander
2021-09-02 4:22 ` Joe Perches
2021-09-02 8:10 ` Kari Argillander
2021-09-07 16:23 ` Konstantin Komarov
2021-09-07 16:25 ` Kari Argillander
2021-08-31 18:15 ` [PATCH 3/5] fs/ntfs3: Place Comparisons constant right side of the test Kari Argillander
2021-08-31 18:15 ` [PATCH 4/5] fs/ntfs3: Remove braces from single statment block Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831181505.1074767-1-kari.argillander@gmail.com \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.