From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D00EC432BE for ; Tue, 31 Aug 2021 18:33:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEC460FE6 for ; Tue, 31 Aug 2021 18:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BEC460FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6C658311F; Tue, 31 Aug 2021 20:33:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="R+Vlm+Z6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 316538310F; Tue, 31 Aug 2021 20:33:03 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20626.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::626]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DAC228310F for ; Tue, 31 Aug 2021 20:32:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oh2NpBKlkKfEb76Atg2nrbUxFSNIIL+25moo4DIUGVyGDqBP61KFfJnWs4jxeijpeuGmMD3C6dUTLWrA+a+O2Z1BjgyGvCwFRHHykf5DdaV8N0POBF77xkxE7YvZXASHVBZTtQL0x2uUK4nCTtsDzeVpNbxaa7BTtOhyAriuAZ9a4FtEvl5rfCtJDzvfGNsggxyHJLO2muPrlX4RRxNyDp/exoKxNBz4/FnzhpMndu6WuYK9pQVjoEnVRMQyeg+DpcxGK2UbQf6qmHtYNeg7wC7xfzDy1PLlCd2XzLanZgGhWbWoy/tk8oLbBH7KIXFvsBvMbo8iZbrEKTwQoweyfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MPcE1+vnceUD07Y/HNfIlr1wOVf0AGeKOUDStF3KWtI=; b=NNjkPtq7H69p/M/TgMzWBYZXk4M3IfYiKEtoO80hHRX8i4OLbhTJk48w7pMQgoiT0hcxMQlPN4rPz/PDw3z7tKQuin/rjtrblpQ0NOr26IhwCnoEAGQO2XzUQ3q0fEgqYNYPnEwWxRMi71C82BqrrlU6eZMs1cuYEvyFViiTZLDyjIo6Iexq2QhXvwvDCqtdKcXUKuczf52XNOaxlrmDQNtHysLV0x7+kZwUbAXtpuZtBoOv7Kao5cdPXEkDAduVDymHsXQEhHYrkMtvu0/G4oSCY9fmdkoDVXMXyMzTNxfl/0R17MC5UFi43C8HSlWXRdIS1UmetvvqQuzg6IJdEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MPcE1+vnceUD07Y/HNfIlr1wOVf0AGeKOUDStF3KWtI=; b=R+Vlm+Z6nNA83NrMDIlLoPi2NXUaNT64B90P6nRDQ3+QAk/2XiFh5ea/fg9vX/kLLOA2RWedhEkE5jVlHk2kYHgZ8nV+x3c6A4gUH9KDgLH7+fiYa3/ZLZJf6barYZhiswoQRrBx62hNcDNFtF5z2ZiezbdatyJidyo4dbkn2FI= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB3069.eurprd04.prod.outlook.com (2603:10a6:802:9::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 31 Aug 2021 18:32:56 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Tue, 31 Aug 2021 18:32:56 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi Thread-Topic: [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi Thread-Index: AQHXnn6W3rcCyYHz5kKng5a8JC6EPquN8D2A Date: Tue, 31 Aug 2021 18:32:56 +0000 Message-ID: <20210831183255.uilwjpci63nv7znw@skbuf> References: <20210831154028.1649864-1-michael@walle.cc> <20210831154028.1649864-7-michael@walle.cc> In-Reply-To: <20210831154028.1649864-7-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c6ef092-b181-4c60-9bd8-08d96cadc0ca x-ms-traffictypediagnostic: VI1PR04MB3069: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2mUy8/9evsrTlyQX8IhuqfXCwy1NQm/4s0JXfh++uj6HecvBz12Uu6xAYAL/U7L3d+TGnD9oXJKvDEDz8TvEZRlhuzGUxDuNA+Lu8fh7BbTWZZE6lniEi7eR9IWs5iTDG2kcJ+2c0Mi81yOECVApLKlpyRsuupanx25vT2h8DYOgVgZPU4NkPT12Qqyo0VNg9x4sEVf4725wruk3xpfd3oROCojIL+E8P/eopUx9ON9ylMXxiTIXlDWeAQkRi4hMObwjscqDwPvOxX2uB+tm49jNzvSKfcd0II2gyFZtvgpQY2rstIy9ZWkKhPMRdeLkW2bqOSJAXiBhfZ1GzQk680zf8y6PAMhm6OL1EkahRa+YRX3EJzIul69eq1J72f5GUyzxlq1MixSjy8ROcTElPYZBzHuAx0rRynRfFMtP0F7ZlofB71T/yiVwmkQ9TqJ1iLq4fCfGD5eGKlGQGswaCnmBMBBorffMEyEt7cU22Pq1TymO3tfkMyzFm5yi0v9zaaDTQuXl1hYMpGM++/JRpKtVLRrvjXieBsWuJKTTd08CfPhsaFl1IdXLbg17oZEguRoRPohN+uimuO36xy198j7UHSbqXxaX30vNFzgcKkNPDkLBIFhKfeQgdGh0baVgzWzmjHbKHFZ1JjXyixifOTXndH3M2agt833AOLMMiTOZsSVl8ZvazLEg6Pt1yBy/ghm88O1MAPJ1ONix+vw7Pw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(86362001)(83380400001)(44832011)(5660300002)(38100700002)(38070700005)(1076003)(316002)(33716001)(8936002)(2906002)(54906003)(6486002)(8676002)(122000001)(66476007)(64756008)(66556008)(66946007)(71200400001)(6506007)(4326008)(66446008)(478600001)(9686003)(6512007)(91956017)(76116006)(186003)(6916009)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x+mw5qhBrXp4YgrEiHb+Sb7TRmR2awetJeFp5qhZvA4B3OT7sy6vrXrQVhAh?= =?us-ascii?Q?h/0P+GljWJkNcTj7FpTIV+8nbZK8C7+LNxrWhhWc2IPsQwGZRZL2sAjkDfRY?= =?us-ascii?Q?9jdp+WpL5H54+R1z6puGb1cB9pOUw9rycWLIaUvUnbxssPpJXL7UI7eLANAT?= =?us-ascii?Q?PrifRL128Ltu8t+cBo2HUGjFzURtmZ2fcDYRpAGQwDmoTpal9zJKtfCBgqvn?= =?us-ascii?Q?aMejzpAouHqTCM2e69ADk4AUO3qMgmKYVzGSY39YoZAe/93M8IJEiwAy06Ds?= =?us-ascii?Q?G95M4WHG3kfV6EahQrgXeJfoJltPx6PxJNNv+aN4y97s5WmShGmtbxAvarLw?= =?us-ascii?Q?Tq0YMfm9VdB3hTyzXuqL+OiR7uI0g/o/PxSj9YS5UJNFBdoDPjvtN0BZL7Gf?= =?us-ascii?Q?CjpIFaTfoqxrTH33G9/bycyd+V5Ag8Hc8cA5hIK80cmlkDe7taYmDvx5GV8O?= =?us-ascii?Q?wnHcfrogPcVe8SfKwiHWyJYbiLL/hfCxN0o7ylG0RnCs7qsx8c4ACo2o5BEe?= =?us-ascii?Q?XWHYUPeqd6NVHhuN6FVuOgFADYrZL3YbJCNDEneIV9nIcTdLnbl5qcp2qDlC?= =?us-ascii?Q?a6yZZtH9BqP+OvNvgBeb5Rig3M6dH4alLbPM6gvxNrENWjchc+/39Yh43whw?= =?us-ascii?Q?yQ7fihAVZi4+5c66Y9zWlUull37bVtZG8NNMyz1rihSXB40wgvEIa2XUzoIm?= =?us-ascii?Q?e4obqMzmXJ9/sLc54kvEpL3Map/xCV3PVF8fO/3aNq2UQSvfCdhxE/hO9qKR?= =?us-ascii?Q?q9L+KmKk7eWI6WBWRIc+0EA/dFJ2H1lTaUFuYk2pLA7Nk+BF9rTUDbpdkue/?= =?us-ascii?Q?tyIdQtFVY9IrG9npfrhFsL2N2Sx3ymTe9wXH9LD2GmCs2mhyCJvHPQx7u2zp?= =?us-ascii?Q?LL8GKRNHdghQJmLMibeUEd4TtHkVFf264MBjee8z3J78I4dWcecuKTkpRDbo?= =?us-ascii?Q?MTStyARmSd5QzYjfqOzvcXO4N7t4ALvRUQ4iKAlNR6qxD19a3IVNqmTfwgu1?= =?us-ascii?Q?tWANYoWi1NraJcCKy2HYWV/BEQARdFnCWbB3AzodIoriFYXmzy5SSVJuHBPD?= =?us-ascii?Q?ZtCSIq1aBSU3Lzq9sGB5lTVa6CRVGnd59mlmyq4i4zyAvoImwAXU3jmPTJ0F?= =?us-ascii?Q?uptmXeM/ACQJLmCb4FzeRMkeYZnImhpgG8kzt5Mk3Mpr5fD0LwgIl0x//Eky?= =?us-ascii?Q?4N7lADccQKN5EaWQAMHY9EZVCYd+6froGP+xYh49rTRsZNm3A3h0M41GVi3M?= =?us-ascii?Q?x/8mjgnh/KRFWAtmQQ27+eB2vG3yNh+ecMY7WKapRG0BmOhuT2tahBRN2TID?= =?us-ascii?Q?LvM5FZc6beOV1CXPxpuwkvTFg/JS+vTgLIN/S/MLspKZYQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c6ef092-b181-4c60-9bd8-08d96cadc0ca X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 18:32:56.8651 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hopjlLciFPBMWJ0h4g8F649Y1zK915ENLM6IkA2G7fHtEwL/mZuZ0FbHdDBMT2hdh5r0ZjMwMuEzb1Se1vPmHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3069 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 31, 2021 at 05:40:25PM +0200, Michael Walle wrote: > The offical ls1028a binding of the driver uses the following as Same typo as before. > compatibles: > compatible =3D "fsl,ls1028a-dspi", "fsl,ls1021a-v1.0-dspi"; >=20 > Add the missing compatible to the driver and update the device tree. >=20 > Signed-off-by: Michael Walle > --- > diff --git a/drivers/spi/fsl_dspi.c b/drivers/spi/fsl_dspi.c > index 8fe3508c64..23d812f476 100644 > --- a/drivers/spi/fsl_dspi.c > +++ b/drivers/spi/fsl_dspi.c > @@ -654,6 +654,7 @@ static const struct dm_spi_ops fsl_dspi_ops =3D { > =20 > static const struct udevice_id fsl_dspi_ids[] =3D { > { .compatible =3D "fsl,vf610-dspi" }, > + { .compatible =3D "fsl,ls1021a-v1.0-dspi" }, Okay, so you say it is pointless to add the "fsl,ls1028a-dspi" compatible string as well, since the U-Boot driver will match on the fallback compatible, and that is absolutely sufficient, since U-Boot will never implement any of the LS1028A specifics (DMA) anyway. I'm fine with that. Reviewed-by: Vladimir Oltean > { } > }; > =20 > --=20 > 2.30.2 >=20