From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC58FC432BE for ; Tue, 31 Aug 2021 21:39:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA6E26101B for ; Tue, 31 Aug 2021 21:39:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA6E26101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D1E0C82E03; Tue, 31 Aug 2021 23:39:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="d6ZmdVL/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B78548310F; Tue, 31 Aug 2021 23:39:44 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20603.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::603]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6755E82C84 for ; Tue, 31 Aug 2021 23:39:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KE3SDf+KUABlK72InSZgdagub7SKx1NtJEq/tQ9g5wYnEmwu7AGFzbjC2OFAOajPyjk7p8Sq61Usrjn0Jf3yjALWCWiOEUGuTe4dJN3inpEryFqhMhj7vy4+pofQcKLs6zOYMHhYAYPo23Hjwi6f0BFcYUKzOXsbY65nCuH0HoQrAPw33XdcZ3w8ACM3WJbblO/gpQsaMQ5277byFr/PTmfKZ80P1mNbhCkelQXWc8TKgU+LJk5H0uwpbfd0IqA7+F56pDklWLd5RLrMPwQVtG9v6cmFR+oKlQ6ql8ZENyiXRFSOKeP5ISZM+BjnQBFfmz6mIX0U66FugJTwsBc+7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yLfyVB4XwSHG3Jw4SOVSlVRqhbOYS8HQcxGx7nTxabY=; b=UtrKLk296ziwE9rc9ab4FNkUhuJUMkCO21P7nnU5mGqgwtG9DKWF2eWFwV5GWz2QEvtzipOKIaFcjpd2m5X0144f92iFmw6CgFk0OEpt4VEOyenP3ud/vG1y/ACo6WI1iv3PfrKvGXKjHhSM+uuR20wB2q+O9BwYiWA/0VPx3Hc/HT6BWfSKm0W4ZpKt7slMGUD6WkRnZR0E5pC4rHNJvmHfbucl+rudIFOKci/nj68a35iV/QhG8mNJfaUuMTDNpjN62K7Jjg6bEEnNHdo7fSexyOD4ab9fYrAYc4FcdI8i9ercxnJj51p/FqMTCmG4IA0zZ2yvhg/+wvOl05+3lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLfyVB4XwSHG3Jw4SOVSlVRqhbOYS8HQcxGx7nTxabY=; b=d6ZmdVL/t6ltPhmPxcs8JYpD0pdsqcl4jzCl6pTIcT6f4NgWApWaSdg3XrPWKT6DcB/Uqj/wKMCDfzwo+k8Dt+3qUb/JCJtA0QT39uH7XrZp+j9w6ytwhT338xaLStwyeC1k06csG7ni8g0FPtDNtR3T+9+wnkfPiqbOrEJnPsk= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0401MB2512.eurprd04.prod.outlook.com (2603:10a6:800:4e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 31 Aug 2021 21:39:38 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Tue, 31 Aug 2021 21:39:38 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi Thread-Topic: [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi Thread-Index: AQHXnn6W3rcCyYHz5kKng5a8JC6EPquN8D2AgAAy/YCAAAEtgA== Date: Tue, 31 Aug 2021 21:39:38 +0000 Message-ID: <20210831213937.blpy74kmk6s2r3gy@skbuf> References: <20210831154028.1649864-1-michael@walle.cc> <20210831154028.1649864-7-michael@walle.cc> <20210831183255.uilwjpci63nv7znw@skbuf> <068143935074f09ce366cc1b760e6b57@walle.cc> In-Reply-To: <068143935074f09ce366cc1b760e6b57@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 71d26df8-9df9-4924-a97e-08d96cc7d598 x-ms-traffictypediagnostic: VI1PR0401MB2512: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qcAF7gE7C+pX2s7eJ/N/dRFTRJZXbk7tSD2Qls0T8iCQNZUKfWGgTBJBAi5Rm+p/eyHMyziSRL+J818Mgz8L7ShbUNYzAUqtUzwfMZQPDbdn3xl/R+mv+5+2VMiibQdr4rIFtbuJAQ5tC+8yc/SmL4O+OFKtBzfSdMaFBWeB1XYLmW3kNxvpO3HhZ0xGq6fWoncgBsiFY56NTS9JyN6gx0eCFq2JwbpqlJrKbZXoIQcZUdc/+16PRUEIM3Oe1RcU7MKXIi3yhw39ipTup6CeniW7bsNXhwWbaewt59JDwp0FYYsrn7P4ctPCi8pz8GZlMizPIkd8HOSwm1CRBDduPxIVPwva74c3ld8jrQoDb5NybR5jGuVdgbOKaG6x2bS/JxMjxW0dY8uwDjh39IRNfZKuh49rs0CF7QnGAkzyeETb+9n1oH4twprvUI8JEz0EA49UqG27leN7XJ8hwW90ZKe+Ov5tk0tVaKXOli0bnd4gPyFSvycOvDo0SPvknSYc+Vb22pGAfMAHMKaSKgh3yS5j7gL6J5pyK8M9qvdM3HK2YB16xKyAauTjDmxspMmRIa9P0cow5btURKNJMI+6aNuL3lwnSe7gJHP3RExdqOF5mMpDd3Gbv6wND1r+k/iQxbf+u1WpRDMgeRCl3BuByKrtO23j4awsu14Cj2T+7XSA9LT/XYQ3XX8p38pScpukUhPZAGQuBuzVsN37sH8URw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(366004)(54906003)(64756008)(66476007)(66946007)(71200400001)(66556008)(66446008)(5660300002)(26005)(9686003)(83380400001)(6512007)(316002)(186003)(76116006)(91956017)(6506007)(44832011)(33716001)(38070700005)(38100700002)(8676002)(1076003)(122000001)(508600001)(8936002)(4326008)(6486002)(86362001)(2906002)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?21QauPa5EYDKAHWk3jVTe6vrHXiOlF+R/HyG8Wrd5zL3eFqvEx0LD9/knuip?= =?us-ascii?Q?Heql862vQi1sh2mv52q1YIbqGh0VuVyshSP4j9Ftd52kgIwKF6ZVPNrcuHxC?= =?us-ascii?Q?ypKi1DJJb9aEpT1I89px88bDQYS7tyuEUloaeD0l3e2ETM/cD8ceSKPJS6ca?= =?us-ascii?Q?LuND0GH8YagBrwa7riXT/UuNRF0hbCNuB16DoUg8XC5JFC9Ba00knsgmou9y?= =?us-ascii?Q?ACoW3ExYi4YkXSoLpLjt2ejkMqDRbFgLpZsMT+1tV3uyMAmr84RTtG22pH20?= =?us-ascii?Q?k8INjeFWbPCStTYeF+X3CyCHinMItaI4FunnW5hIDeFng3DbL0mMgyfnHoYC?= =?us-ascii?Q?I94KDTSAzboYDmVi1beUuAp+v7dj+GWGasCIw81UNGoXl28OHCdf56y922+H?= =?us-ascii?Q?nm/y8k5ikOqAYXnHyHFvRYzwgZpgvNgiyqOePNkI7kxEXGRaqWt+Yjbe4NIR?= =?us-ascii?Q?lEWS+EAJc4AOZ49MkTXGRzlXDYDzDiGa3CRwIwpO/Nnnm/0s8JOkckkqU4cc?= =?us-ascii?Q?Yrzy+PxEiyxlhquOhnk3nhRR+IWi3Ivpl8pEoaqtepV//Sl8DvqUC1XgyCg/?= =?us-ascii?Q?qvPZjaHZmxd+wXpjkvs6goxLtpe7l1IiOoe/iqUzuhWLKtvHds1lM0jGvvqv?= =?us-ascii?Q?UCizbTxglIyc0/7fb825lpEE4HThMjCvJ7DgMtna5+G5r5sHNiMIxfjRWCJ2?= =?us-ascii?Q?xXQtFNwgkxyuVkSHoEGjfi2LaCF5uXCAN50FhRXukqNpxA8ybnaherV5CGuo?= =?us-ascii?Q?JRf+2vWahwD+0hSD/Fe9ubJOU/2C9JX/4ELijCbA67D/3uAL3ut+T85x3cpm?= =?us-ascii?Q?n1O7so+QQ3Zjt9E1CsdvssD9V/rKd+Dj4ONIzjX+NfDkVxUE9IAigsOfxiZl?= =?us-ascii?Q?L3bbeY94mPVH1InMNrCHWnHVhHRuMnFlFNsSr88oj8vOcDHe0QnH/ATl4skI?= =?us-ascii?Q?3wLRXJMpWlKUe8atuCwaFcqXAmpWwad1xno4NAZCyEYMo3A/SAL4SAqwXJHj?= =?us-ascii?Q?UusfSnPkIjq5oz81d4t636RyJOOHJd2Fm43/ynpWyIa0O2Jl1p8uPTEm+TKv?= =?us-ascii?Q?MqtcxTfe+EmohI9Qd4bxfMvB+GZr67LzHeSRMWAtlb5Aa1GnohACamr/F+6C?= =?us-ascii?Q?4qA5Eu7MCE2cmUrsfkSuDU0g9aegCTeKQV/2iYmLcNTDS56kPVak8XDHiB6I?= =?us-ascii?Q?ZjQz/utlKhCm929dsXJvj0sm9d/RpbUGiwlhGEl87uSTcojGA/NAJV0u54EL?= =?us-ascii?Q?8q9fyrTS0wFj4l8VIHHFQB18VHtksbBMuInbyMy6E2A8XhjhLh/yYf8XIZbD?= =?us-ascii?Q?qXGZS9w/917EUK/AXTZDHAJt?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71d26df8-9df9-4924-a97e-08d96cc7d598 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 21:39:38.6450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Tm0g1XOCAPVpjAFiy+iojrGPstg7kprFykO4rPkeW/BC95q/Qnp5pRrqn3cokFaHeIwUP4OybUj9UGasVYf34Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2512 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 31, 2021 at 11:35:25PM +0200, Michael Walle wrote: > Am 2021-08-31 20:32, schrieb Vladimir Oltean: > > On Tue, Aug 31, 2021 at 05:40:25PM +0200, Michael Walle wrote: > > > The offical ls1028a binding of the driver uses the following as > >=20 > > Same typo as before. > >=20 > > > compatibles: > > > compatible =3D "fsl,ls1028a-dspi", "fsl,ls1021a-v1.0-dspi"; > > >=20 > > > Add the missing compatible to the driver and update the device tree. > > >=20 > > > Signed-off-by: Michael Walle > > > --- > > > diff --git a/drivers/spi/fsl_dspi.c b/drivers/spi/fsl_dspi.c > > > index 8fe3508c64..23d812f476 100644 > > > --- a/drivers/spi/fsl_dspi.c > > > +++ b/drivers/spi/fsl_dspi.c > > > @@ -654,6 +654,7 @@ static const struct dm_spi_ops fsl_dspi_ops =3D { > > >=20 > > > static const struct udevice_id fsl_dspi_ids[] =3D { > > > { .compatible =3D "fsl,vf610-dspi" }, > > > + { .compatible =3D "fsl,ls1021a-v1.0-dspi" }, > >=20 > > Okay, so you say it is pointless to add the "fsl,ls1028a-dspi" > > compatible string as well, since the U-Boot driver will match on the > > fallback compatible, and that is absolutely sufficient, since U-Boot > > will never implement any of the LS1028A specifics (DMA) anyway. > > I'm fine with that. >=20 > I'll add that to the commit message in the next version. There is a subtler point to be made. While in the case of lpuart, there is that difference between Linux and U-Boot, in that: - Linux sets endianness based on compatible string - U-Boot sets endianness based on "little-endian" property For the dspi, it is different. Both Linux and U-Boot set endianness based on the "big-endian" property. So that's why both the LS1021A and LS1028A DSPI modules work with the same compatible string. Quite inconsistent, but it is what it is.=