From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6729DC432BE for ; Wed, 1 Sep 2021 03:31:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A82060BD3 for ; Wed, 1 Sep 2021 03:31:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1A82060BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLGyV-0002cx-B5 for qemu-devel@archiver.kernel.org; Tue, 31 Aug 2021 23:31:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLGur-0003BD-S1; Tue, 31 Aug 2021 23:27:57 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:36757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLGua-0007Ln-VW; Tue, 31 Aug 2021 23:27:57 -0400 Received: by mail-pf1-x42c.google.com with SMTP id m26so968461pff.3; Tue, 31 Aug 2021 20:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DnvfBbmV9W5QaBw9cjpxj3O1smfoTH7OnL+gTgkQoPM=; b=ExY3FnHZhAO1HlfjWHvbyrQlEXCi4N4NiX169sAGQ5e9TY0hXuMvLxgMvnQ8Bc2mEf kHvXY96klRE6cyUj9B+jkGzPLWoSaPw2PmYz5OZFh7lah9W5r24JKfX4pcFbkGrdYwGE aIKCUvnyKGR/QA2Bknb7oH+U9cVRlXOQOMZRe2igIcAHF1lLeC1OITnOzpg9a8yGwKY8 txAamI7YuyNnUIuoX33m4zJMyO1ihhw2suq6LN3jKMCi4jnU+qX9rGkIepDG2pCJg7q1 gDX9j1zqHYkvtX9kUNy6mwXa5+VWgUeMafi+3+sQ5GJ8Nb403878fLyTN06KcJFv1u0y 2Qyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DnvfBbmV9W5QaBw9cjpxj3O1smfoTH7OnL+gTgkQoPM=; b=XdUEfgCu0ijg2HLcVGc8GM3ePUvh71gnCg9q7HBux+ZCqqATzTjx0sqfwrMOZXBipT +rFhuvPQfOzGqjnYsHttx/aRfY21H1aQU31fiXipN5NszJ60UA+lTEcyeiLra9MpqNpv wEeFVd5WCL5IyY63CdI/f5ofuMaK7Rfz50bL2Qe7yBsg+dIh+sYlEEyBpnXZP7zSZLd2 vS2Om/glVFEBLJmU6oybSkeGhLQYvuCM5MpfQAEphxHr7CW/b2yAZJe1ZiAwdoxEGSnK 7ZV68h1/ekTaVn0py1Luia9CbEOx6l+7UELNKi2aqfcbCYWmKSlL/neJOkpkGYefOOnM 9zww== X-Gm-Message-State: AOAM53210W2/KkFSWa0pFpEDTSDX0YiscHP7owxX9JwmiCHG2D/85OIx wxRvzeJicSsU31plQjdQD24= X-Google-Smtp-Source: ABdhPJwxEwau+/yCmebBkT+0dgQOhLphqpVDZGSGrYhNidz7WthZJNIYmPKJ8Vcn77NJMZ8Doaql4g== X-Received: by 2002:a63:3c5d:: with SMTP id i29mr29623631pgn.147.1630466858033; Tue, 31 Aug 2021 20:27:38 -0700 (PDT) Received: from i9-aorus-gtx1080.localdomain (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id g2sm7174467pfo.154.2021.08.31.20.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 20:27:37 -0700 (PDT) From: Bin Meng To: Damien Hedde , "Edgar E . Iglesias" , Alistair Francis , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 2/5] hw/char: cadence_uart: Disable transmit when input clock is disabled Date: Wed, 1 Sep 2021 11:27:21 +0800 Message-Id: <20210901032724.23256-3-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210901032724.23256-1-bmeng.cn@gmail.com> References: <20210901032724.23256-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=bmeng.cn@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" At present when input clock is disabled, any character transmitted to tx fifo can still show on the serial line, which is wrong. Fixes: b636db306e06 ("hw/char/cadence_uart: add clock support") Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1) hw/char/cadence_uart.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index b4b5e8a3ee..154be34992 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -327,6 +327,11 @@ static gboolean cadence_uart_xmit(void *do_not_use, GIOCondition cond, static void uart_write_tx_fifo(CadenceUARTState *s, const uint8_t *buf, int size) { + /* ignore characters when unclocked or in reset */ + if (!clock_is_enabled(s->refclk) || device_is_in_reset(DEVICE(s))) { + return; + } + if ((s->r[R_CR] & UART_CR_TX_DIS) || !(s->r[R_CR] & UART_CR_TX_EN)) { return; } -- 2.25.1