All of lore.kernel.org
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1 0/3] Promote some API to stable
@ 2021-09-01  5:07 Haiyue Wang
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote " Haiyue Wang
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Haiyue Wang @ 2021-09-01  5:07 UTC (permalink / raw)
  To: dev; +Cc: mdr, thomas, Haiyue Wang

According to DPDK ABI Policy, section 3.5.3.
https://doc.dpdk.org/guides/contributing/abi_policy.html

Promote some API reported by DPDK Symbol Bot to stable.

Haiyue Wang (3):
  net/ixgbe: promote some API to stable
  net/ice: promote some API to stable
  ethdev: promote burst mode API to stable

 drivers/net/ice/rte_pmd_ice.h     |  3 ---
 drivers/net/ice/version.map       | 11 ++++-------
 drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
 drivers/net/ixgbe/version.map     | 10 +++++-----
 lib/ethdev/rte_ethdev.h           |  2 --
 lib/ethdev/version.map            |  4 ++--
 6 files changed, 11 insertions(+), 24 deletions(-)

-- 
2.33.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable
  2021-09-01  5:07 [dpdk-dev] [PATCH v1 0/3] Promote some API to stable Haiyue Wang
@ 2021-09-01  5:07 ` Haiyue Wang
  2021-09-01  9:02   ` Ferruh Yigit
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 2/3] net/ice: " Haiyue Wang
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 12+ messages in thread
From: Haiyue Wang @ 2021-09-01  5:07 UTC (permalink / raw)
  To: dev; +Cc: mdr, thomas, Haiyue Wang

The DPDK Symbol Bot reports:
Please note the symbols listed below have expired. In line with the
DPDK ABI policy, they should be scheduled for removal, in the next
DPDK release.

Symbol
rte_pmd_ixgbe_mdio_lock
rte_pmd_ixgbe_mdio_unlock
rte_pmd_ixgbe_mdio_unlocked_read
rte_pmd_ixgbe_mdio_unlocked_write
rte_pmd_ixgbe_upd_fctrl_sbp

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index 90fc8160b1..7fcdbe7452 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
@@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
@@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data);
@@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data);
@@ -725,7 +721,6 @@ enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
index bca5cc5826..f0f29d8749 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -16,6 +16,10 @@ DPDK_22 {
 	rte_pmd_ixgbe_macsec_enable;
 	rte_pmd_ixgbe_macsec_select_rxsa;
 	rte_pmd_ixgbe_macsec_select_txsa;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
 	rte_pmd_ixgbe_ping_vf;
 	rte_pmd_ixgbe_set_all_queues_drop_en;
 	rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@ EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };
-- 
2.33.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v1 2/3] net/ice: promote some API to stable
  2021-09-01  5:07 [dpdk-dev] [PATCH v1 0/3] Promote some API to stable Haiyue Wang
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote " Haiyue Wang
@ 2021-09-01  5:07 ` Haiyue Wang
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode " Haiyue Wang
  2021-09-06  5:56 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
  3 siblings, 0 replies; 12+ messages in thread
From: Haiyue Wang @ 2021-09-01  5:07 UTC (permalink / raw)
  To: dev; +Cc: mdr, thomas, Haiyue Wang, Qiming Yang, Qi Zhang

The DPDK Symbol Bot reports:
Please note the symbols listed below have expired. In line with the
DPDK ABI policy, they should be scheduled for removal, in the next
DPDK release.

Symbol
rte_net_ice_dynfield_proto_xtr_metadata_offs
rte_net_ice_dynflag_proto_xtr_vlan_mask
rte_net_ice_dynflag_proto_xtr_ipv4_mask
rte_net_ice_dynflag_proto_xtr_ipv6_mask
rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask
rte_net_ice_dynflag_proto_xtr_tcp_mask

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/rte_pmd_ice.h |  3 ---
 drivers/net/ice/version.map   | 11 ++++-------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ice/rte_pmd_ice.h b/drivers/net/ice/rte_pmd_ice.h
index 9a436a140b..c0f19fcc89 100644
--- a/drivers/net/ice/rte_pmd_ice.h
+++ b/drivers/net/ice/rte_pmd_ice.h
@@ -149,7 +149,6 @@ extern uint64_t rte_net_ice_dynflag_proto_xtr_ip_offset_mask;
  * @return
  *   True if registered, false otherwise.
  */
-__rte_experimental
 static __rte_always_inline int
 rte_net_ice_dynf_proto_xtr_metadata_avail(void)
 {
@@ -164,7 +163,6 @@ rte_net_ice_dynf_proto_xtr_metadata_avail(void)
  * @return
  *   The saved protocol extraction metadata.
  */
-__rte_experimental
 static __rte_always_inline uint32_t
 rte_net_ice_dynf_proto_xtr_metadata_get(struct rte_mbuf *m)
 {
@@ -177,7 +175,6 @@ rte_net_ice_dynf_proto_xtr_metadata_get(struct rte_mbuf *m)
  * @param m
  *    The pointer to the mbuf.
  */
-__rte_experimental
 static inline void
 rte_net_ice_dump_proto_xtr_metadata(struct rte_mbuf *m)
 {
diff --git a/drivers/net/ice/version.map b/drivers/net/ice/version.map
index cc837f1c00..1a633fd95e 100644
--- a/drivers/net/ice/version.map
+++ b/drivers/net/ice/version.map
@@ -1,16 +1,13 @@
 DPDK_22 {
-	local: *;
-};
-
-EXPERIMENTAL {
 	global:
 
-	# added in 19.11
 	rte_net_ice_dynfield_proto_xtr_metadata_offs;
-	rte_net_ice_dynflag_proto_xtr_vlan_mask;
+	rte_net_ice_dynflag_proto_xtr_ip_offset_mask;
 	rte_net_ice_dynflag_proto_xtr_ipv4_mask;
 	rte_net_ice_dynflag_proto_xtr_ipv6_mask;
 	rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask;
 	rte_net_ice_dynflag_proto_xtr_tcp_mask;
-	rte_net_ice_dynflag_proto_xtr_ip_offset_mask;
+	rte_net_ice_dynflag_proto_xtr_vlan_mask;
+
+	local: *;
 };
-- 
2.33.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable
  2021-09-01  5:07 [dpdk-dev] [PATCH v1 0/3] Promote some API to stable Haiyue Wang
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote " Haiyue Wang
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 2/3] net/ice: " Haiyue Wang
@ 2021-09-01  5:07 ` Haiyue Wang
  2021-09-01  9:07   ` Ferruh Yigit
  2021-09-06  5:56 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
  3 siblings, 1 reply; 12+ messages in thread
From: Haiyue Wang @ 2021-09-01  5:07 UTC (permalink / raw)
  To: dev; +Cc: mdr, thomas, Haiyue Wang, Ferruh Yigit, Andrew Rybchenko

The DPDK Symbol Bot reports:
Please note the symbols listed below have expired. In line with the
DPDK ABI policy, they should be scheduled for removal, in the next
DPDK release.

Symbol
rte_eth_rx_burst_mode_get
rte_eth_tx_burst_mode_get

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 lib/ethdev/rte_ethdev.h | 2 --
 lib/ethdev/version.map  | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index d2b27c351f..3277e8f8fb 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -4361,7 +4361,6 @@ int rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
  *   - -ENOTSUP: routine is not supported by the device PMD.
  *   - -EINVAL:  The queue_id is out of range.
  */
-__rte_experimental
 int rte_eth_rx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
 	struct rte_eth_burst_mode *mode);
 
@@ -4383,7 +4382,6 @@ int rte_eth_rx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
  *   - -ENOTSUP: routine is not supported by the device PMD.
  *   - -EINVAL:  The queue_id is out of range.
  */
-__rte_experimental
 int rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
 	struct rte_eth_burst_mode *mode);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 3eece75b72..6a12b0664a 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -87,6 +87,7 @@ DPDK_22 {
 	rte_eth_promiscuous_get;
 	rte_eth_remove_rx_callback;
 	rte_eth_remove_tx_callback;
+	rte_eth_rx_burst_mode_get;
 	rte_eth_rx_queue_info_get;
 	rte_eth_rx_queue_setup;
 	rte_eth_set_queue_rate_limit;
@@ -104,6 +105,7 @@ DPDK_22 {
 	rte_eth_tx_buffer_drop_callback;
 	rte_eth_tx_buffer_init;
 	rte_eth_tx_buffer_set_err_callback;
+	rte_eth_tx_burst_mode_get;
 	rte_eth_tx_done_cleanup;
 	rte_eth_tx_queue_info_get;
 	rte_eth_tx_queue_setup;
@@ -166,9 +168,7 @@ EXPERIMENTAL {
 
 	# added in 19.11
 	rte_eth_dev_hairpin_capability_get;
-	rte_eth_rx_burst_mode_get;
 	rte_eth_rx_hairpin_queue_setup;
-	rte_eth_tx_burst_mode_get;
 	rte_eth_tx_hairpin_queue_setup;
 	rte_flow_dynf_metadata_offs;
 	rte_flow_dynf_metadata_mask;
-- 
2.33.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote " Haiyue Wang
@ 2021-09-01  9:02   ` Ferruh Yigit
  2021-09-01 11:13     ` Wang, Haiyue
  0 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2021-09-01  9:02 UTC (permalink / raw)
  To: Haiyue Wang, dev; +Cc: mdr, thomas

On 9/1/2021 6:07 AM, Haiyue Wang wrote:
> The DPDK Symbol Bot reports:
> Please note the symbols listed below have expired. In line with the
> DPDK ABI policy, they should be scheduled for removal, in the next
> DPDK release.
> 
> Symbol
> rte_pmd_ixgbe_mdio_lock
> rte_pmd_ixgbe_mdio_unlock
> rte_pmd_ixgbe_mdio_unlocked_read
> rte_pmd_ixgbe_mdio_unlocked_write
> rte_pmd_ixgbe_upd_fctrl_sbp

I wonder if we should keep PMD specific APIs as experimental (Not talking about
mbuf 'dynfield' / 'dynflag' APIs, we can promote them).

If an application is using PMD specific API, not sure if it will concern about
PMD specific APIs.
And keeping PMD specific APIs lets us remove them as soon as we can, also adds
additional discourage for users to use them.

> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>


<...>



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode " Haiyue Wang
@ 2021-09-01  9:07   ` Ferruh Yigit
  2021-09-01 13:49     ` Kinsella, Ray
  0 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2021-09-01  9:07 UTC (permalink / raw)
  To: Haiyue Wang, dev; +Cc: mdr, thomas, Andrew Rybchenko

On 9/1/2021 6:07 AM, Haiyue Wang wrote:
> The DPDK Symbol Bot reports:
> Please note the symbols listed below have expired. In line with the
> DPDK ABI policy, they should be scheduled for removal, in the next
> DPDK release.
> 
> Symbol
> rte_eth_rx_burst_mode_get
> rte_eth_tx_burst_mode_get
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable
  2021-09-01  9:02   ` Ferruh Yigit
@ 2021-09-01 11:13     ` Wang, Haiyue
  2021-09-01 13:55       ` Kinsella, Ray
  0 siblings, 1 reply; 12+ messages in thread
From: Wang, Haiyue @ 2021-09-01 11:13 UTC (permalink / raw)
  To: Yigit, Ferruh, dev; +Cc: mdr, thomas

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Wednesday, September 1, 2021 17:02
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Cc: mdr@ashroe.eu; thomas@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable
> 
> On 9/1/2021 6:07 AM, Haiyue Wang wrote:
> > The DPDK Symbol Bot reports:
> > Please note the symbols listed below have expired. In line with the
> > DPDK ABI policy, they should be scheduled for removal, in the next
> > DPDK release.
> >
> > Symbol
> > rte_pmd_ixgbe_mdio_lock
> > rte_pmd_ixgbe_mdio_unlock
> > rte_pmd_ixgbe_mdio_unlocked_read
> > rte_pmd_ixgbe_mdio_unlocked_write
> > rte_pmd_ixgbe_upd_fctrl_sbp
> 
> I wonder if we should keep PMD specific APIs as experimental (Not talking about
> mbuf 'dynfield' / 'dynflag' APIs, we can promote them).

Yes, makes sense.

> 
> If an application is using PMD specific API, not sure if it will concern about
> PMD specific APIs.
> And keeping PMD specific APIs lets us remove them as soon as we can, also adds
> additional discourage for users to use them.

Can update this to DPDK ABI Policy, section 3.5.3.
https://doc.dpdk.org/guides/contributing/abi_policy.html

> 
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> 
> 
> <...>
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable
  2021-09-01  9:07   ` Ferruh Yigit
@ 2021-09-01 13:49     ` Kinsella, Ray
  0 siblings, 0 replies; 12+ messages in thread
From: Kinsella, Ray @ 2021-09-01 13:49 UTC (permalink / raw)
  To: Ferruh Yigit, Haiyue Wang, dev; +Cc: thomas, Andrew Rybchenko



On 01/09/2021 10:07, Ferruh Yigit wrote:
> On 9/1/2021 6:07 AM, Haiyue Wang wrote:
>> The DPDK Symbol Bot reports:
>> Please note the symbols listed below have expired. In line with the
>> DPDK ABI policy, they should be scheduled for removal, in the next
>> DPDK release.
>>
>> Symbol
>> rte_eth_rx_burst_mode_get
>> rte_eth_tx_burst_mode_get
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable
  2021-09-01 11:13     ` Wang, Haiyue
@ 2021-09-01 13:55       ` Kinsella, Ray
  0 siblings, 0 replies; 12+ messages in thread
From: Kinsella, Ray @ 2021-09-01 13:55 UTC (permalink / raw)
  To: Wang, Haiyue, Yigit, Ferruh, dev; +Cc: thomas, David Marchand



On 01/09/2021 12:13, Wang, Haiyue wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Wednesday, September 1, 2021 17:02
>> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
>> Cc: mdr@ashroe.eu; thomas@monjalon.net
>> Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable
>>
>> On 9/1/2021 6:07 AM, Haiyue Wang wrote:
>>> The DPDK Symbol Bot reports:
>>> Please note the symbols listed below have expired. In line with the
>>> DPDK ABI policy, they should be scheduled for removal, in the next
>>> DPDK release.
>>>
>>> Symbol
>>> rte_pmd_ixgbe_mdio_lock
>>> rte_pmd_ixgbe_mdio_unlock
>>> rte_pmd_ixgbe_mdio_unlocked_read
>>> rte_pmd_ixgbe_mdio_unlocked_write
>>> rte_pmd_ixgbe_upd_fctrl_sbp
>>
>> I wonder if we should keep PMD specific APIs as experimental (Not talking about
>> mbuf 'dynfield' / 'dynflag' APIs, we can promote them).
> 
> Yes, makes sense.
> 
>>
>> If an application is using PMD specific API, not sure if it will concern about
>> PMD specific APIs.
>> And keeping PMD specific APIs lets us remove them as soon as we can, also adds
>> additional discourage for users to use them.
> 
> Can update this to DPDK ABI Policy, section 3.5.3.
> https://doc.dpdk.org/guides/contributing/abi_policy.html

I understand and agree.
However we never made any exceptions for PMD specific APIs in the policy.

Leave them as experimental for the moment.
I will add a clause to the policy ....

Thomas / David - any opinion?

> 
>>
>>>
>>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>>
>>
>> <...>
>>
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable
  2021-09-01  5:07 [dpdk-dev] [PATCH v1 0/3] Promote some API to stable Haiyue Wang
                   ` (2 preceding siblings ...)
  2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode " Haiyue Wang
@ 2021-09-06  5:56 ` Haiyue Wang
  2021-09-06  6:36   ` Andrew Rybchenko
  3 siblings, 1 reply; 12+ messages in thread
From: Haiyue Wang @ 2021-09-06  5:56 UTC (permalink / raw)
  To: dev
  Cc: Haiyue Wang, Ferruh Yigit, Ray Kinsella, Thomas Monjalon,
	Andrew Rybchenko

The DPDK Symbol Bot reports:
Please note the symbols listed below have expired. In line with the
DPDK ABI policy, they should be scheduled for removal, in the next
DPDK release.

Symbol
rte_eth_rx_burst_mode_get
rte_eth_tx_burst_mode_get

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
---

v2: Drop the PMD API promote to stable

---
 lib/ethdev/rte_ethdev.h | 2 --
 lib/ethdev/version.map  | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index d2b27c351f..3277e8f8fb 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -4361,7 +4361,6 @@ int rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
  *   - -ENOTSUP: routine is not supported by the device PMD.
  *   - -EINVAL:  The queue_id is out of range.
  */
-__rte_experimental
 int rte_eth_rx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
 	struct rte_eth_burst_mode *mode);
 
@@ -4383,7 +4382,6 @@ int rte_eth_rx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
  *   - -ENOTSUP: routine is not supported by the device PMD.
  *   - -EINVAL:  The queue_id is out of range.
  */
-__rte_experimental
 int rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
 	struct rte_eth_burst_mode *mode);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 3eece75b72..6a12b0664a 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -87,6 +87,7 @@ DPDK_22 {
 	rte_eth_promiscuous_get;
 	rte_eth_remove_rx_callback;
 	rte_eth_remove_tx_callback;
+	rte_eth_rx_burst_mode_get;
 	rte_eth_rx_queue_info_get;
 	rte_eth_rx_queue_setup;
 	rte_eth_set_queue_rate_limit;
@@ -104,6 +105,7 @@ DPDK_22 {
 	rte_eth_tx_buffer_drop_callback;
 	rte_eth_tx_buffer_init;
 	rte_eth_tx_buffer_set_err_callback;
+	rte_eth_tx_burst_mode_get;
 	rte_eth_tx_done_cleanup;
 	rte_eth_tx_queue_info_get;
 	rte_eth_tx_queue_setup;
@@ -166,9 +168,7 @@ EXPERIMENTAL {
 
 	# added in 19.11
 	rte_eth_dev_hairpin_capability_get;
-	rte_eth_rx_burst_mode_get;
 	rte_eth_rx_hairpin_queue_setup;
-	rte_eth_tx_burst_mode_get;
 	rte_eth_tx_hairpin_queue_setup;
 	rte_flow_dynf_metadata_offs;
 	rte_flow_dynf_metadata_mask;
-- 
2.33.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable
  2021-09-06  5:56 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
@ 2021-09-06  6:36   ` Andrew Rybchenko
  2021-09-15  8:46     ` Ferruh Yigit
  0 siblings, 1 reply; 12+ messages in thread
From: Andrew Rybchenko @ 2021-09-06  6:36 UTC (permalink / raw)
  To: Haiyue Wang, dev; +Cc: Ferruh Yigit, Ray Kinsella, Thomas Monjalon

On 9/6/21 8:56 AM, Haiyue Wang wrote:
> The DPDK Symbol Bot reports:
> Please note the symbols listed below have expired. In line with the
> DPDK ABI policy, they should be scheduled for removal, in the next
> DPDK release.
> 
> Symbol
> rte_eth_rx_burst_mode_get
> rte_eth_tx_burst_mode_get
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable
  2021-09-06  6:36   ` Andrew Rybchenko
@ 2021-09-15  8:46     ` Ferruh Yigit
  0 siblings, 0 replies; 12+ messages in thread
From: Ferruh Yigit @ 2021-09-15  8:46 UTC (permalink / raw)
  To: Andrew Rybchenko, Haiyue Wang, dev; +Cc: Ray Kinsella, Thomas Monjalon

On 9/6/2021 7:36 AM, Andrew Rybchenko wrote:
> On 9/6/21 8:56 AM, Haiyue Wang wrote:
>> The DPDK Symbol Bot reports:
>> Please note the symbols listed below have expired. In line with the
>> DPDK ABI policy, they should be scheduled for removal, in the next
>> DPDK release.
>>
>> Symbol
>> rte_eth_rx_burst_mode_get
>> rte_eth_tx_burst_mode_get
>>
>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-09-15  8:46 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01  5:07 [dpdk-dev] [PATCH v1 0/3] Promote some API to stable Haiyue Wang
2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote " Haiyue Wang
2021-09-01  9:02   ` Ferruh Yigit
2021-09-01 11:13     ` Wang, Haiyue
2021-09-01 13:55       ` Kinsella, Ray
2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 2/3] net/ice: " Haiyue Wang
2021-09-01  5:07 ` [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode " Haiyue Wang
2021-09-01  9:07   ` Ferruh Yigit
2021-09-01 13:49     ` Kinsella, Ray
2021-09-06  5:56 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
2021-09-06  6:36   ` Andrew Rybchenko
2021-09-15  8:46     ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.