All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: mediatek-gen3: Make use of the helper function devm_platform_ioremap_resource_byname()
@ 2021-09-01  7:40 ` Cai Huoqing
  0 siblings, 0 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-01  7:40 UTC (permalink / raw)
  To: caihuoqing
  Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
	Krzysztof Wilczyński, Bjorn Helgaas, Matthias Brugger,
	linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 17c59b0d6978..014747c6dcd4 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -715,10 +715,7 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port)
 	struct resource *regs;
 	int ret;
 
-	regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac");
-	if (!regs)
-		return -EINVAL;
-	port->base = devm_ioremap_resource(dev, regs);
+	port->base = devm_platform_ioremap_resource_byname(pdev, "pcie-mac");
 	if (IS_ERR(port->base)) {
 		dev_err(dev, "failed to map register base\n");
 		return PTR_ERR(port->base);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] PCI: mediatek-gen3: Make use of the helper function devm_platform_ioremap_resource_byname()
@ 2021-09-01  7:40 ` Cai Huoqing
  0 siblings, 0 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-01  7:40 UTC (permalink / raw)
  To: caihuoqing
  Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
	Krzysztof Wilczyński, Bjorn Helgaas, Matthias Brugger,
	linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 17c59b0d6978..014747c6dcd4 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -715,10 +715,7 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port)
 	struct resource *regs;
 	int ret;
 
-	regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac");
-	if (!regs)
-		return -EINVAL;
-	port->base = devm_ioremap_resource(dev, regs);
+	port->base = devm_platform_ioremap_resource_byname(pdev, "pcie-mac");
 	if (IS_ERR(port->base)) {
 		dev_err(dev, "failed to map register base\n");
 		return PTR_ERR(port->base);
-- 
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] PCI: mediatek-gen3: Make use of the helper function devm_platform_ioremap_resource_byname()
@ 2021-09-01  7:40 ` Cai Huoqing
  0 siblings, 0 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-09-01  7:40 UTC (permalink / raw)
  To: caihuoqing
  Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
	Krzysztof Wilczyński, Bjorn Helgaas, Matthias Brugger,
	linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 17c59b0d6978..014747c6dcd4 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -715,10 +715,7 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port)
 	struct resource *regs;
 	int ret;
 
-	regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac");
-	if (!regs)
-		return -EINVAL;
-	port->base = devm_ioremap_resource(dev, regs);
+	port->base = devm_platform_ioremap_resource_byname(pdev, "pcie-mac");
 	if (IS_ERR(port->base)) {
 		dev_err(dev, "failed to map register base\n");
 		return PTR_ERR(port->base);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: mediatek-gen3: Make use of the helper function devm_platform_ioremap_resource_byname()
  2021-09-01  7:40 ` Cai Huoqing
  (?)
  (?)
@ 2021-09-01 11:46 ` Jianjun Wang (王建军)
  -1 siblings, 0 replies; 4+ messages in thread
From: Jianjun Wang (王建军) @ 2021-09-01 11:46 UTC (permalink / raw)
  To: caihuoqing
  Cc: linux-mediatek, linux-kernel, lorenzo.pieralisi, robh, kw,
	linux-arm-kernel, matthias.bgg, bhelgaas,
	Ryder Lee (李庚諺),
	linux-pci

On Wed, 2021-09-01 at 15:40 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/pci/controller/pcie-mediatek-gen3.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c
> b/drivers/pci/controller/pcie-mediatek-gen3.c
> index 17c59b0d6978..014747c6dcd4 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -715,10 +715,7 @@ static int mtk_pcie_parse_port(struct
> mtk_pcie_port *port)
>  	struct resource *regs;
>  	int ret;
>  
> -	regs = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "pcie-mac");
> -	if (!regs)
> -		return -EINVAL;
> -	port->base = devm_ioremap_resource(dev, regs);
> +	port->base = devm_platform_ioremap_resource_byname(pdev, "pcie-
> mac");
>  	if (IS_ERR(port->base)) {
>  		dev_err(dev, "failed to map register base\n");
>  		return PTR_ERR(port->base);

This "regs" will be used by port->reg_base as follows:

	port->reg_base = regs->start;

Please don't remove it directly.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-01 13:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01  7:40 [PATCH] PCI: mediatek-gen3: Make use of the helper function devm_platform_ioremap_resource_byname() Cai Huoqing
2021-09-01  7:40 ` Cai Huoqing
2021-09-01  7:40 ` Cai Huoqing
2021-09-01 11:46 ` Jianjun Wang (王建军)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.