* [PATCH] x86: make setup.c build again
@ 2021-09-01 7:12 Christoph Hellwig
2021-09-01 7:33 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-09-01 7:12 UTC (permalink / raw)
To: torvalds, x86; +Cc: linux-kernel
Add a <linux/acpi.h> include to setup.c to ensure it compiles without
any config-dependent implicit includes of that header.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/x86/kernel/setup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 63b20536c8d23..6edec9a28293e 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -22,6 +22,7 @@
#include <linux/usb/xhci-dbgp.h>
#include <linux/static_call.h>
#include <linux/swiotlb.h>
+#include <linux/acpi.h>
#include <uapi/linux/mount.h>
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: make setup.c build again
2021-09-01 7:12 [PATCH] x86: make setup.c build again Christoph Hellwig
@ 2021-09-01 7:33 ` Borislav Petkov
2021-09-01 7:42 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-09-01 7:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: torvalds, x86, linux-kernel
On Wed, Sep 01, 2021 at 09:12:32AM +0200, Christoph Hellwig wrote:
> Add a <linux/acpi.h> include to setup.c to ensure it compiles without
> any config-dependent implicit includes of that header.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/x86/kernel/setup.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 63b20536c8d23..6edec9a28293e 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -22,6 +22,7 @@
> #include <linux/usb/xhci-dbgp.h>
> #include <linux/static_call.h>
> #include <linux/swiotlb.h>
> +#include <linux/acpi.h>
>
> #include <uapi/linux/mount.h>
>
> --
There's an identical fix
https://lkml.kernel.org/r/20210901021510.1561219-1-nathan@kernel.org
which explains why it happens but I'm fine with whichever one Linus
picks up.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: make setup.c build again
2021-09-01 7:33 ` Borislav Petkov
@ 2021-09-01 7:42 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-09-01 7:42 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Christoph Hellwig, torvalds, x86, linux-kernel
On Wed, Sep 01, 2021 at 09:33:08AM +0200, Borislav Petkov wrote:
> There's an identical fix
>
> https://lkml.kernel.org/r/20210901021510.1561219-1-nathan@kernel.org
>
> which explains why it happens but I'm fine with whichever one Linus
> picks up.
Yeahm the changelog from Nathan looks better. I'm fine as long as we
get this fixed ASAP.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-01 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 7:12 [PATCH] x86: make setup.c build again Christoph Hellwig
2021-09-01 7:33 ` Borislav Petkov
2021-09-01 7:42 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.