All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH bpf-next RFC v1 1/8] bpf: Introduce BPF support for kernel module function calls
@ 2021-09-01  1:16 kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-09-01  1:16 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 34745 bytes --]

CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210830173424.1385796-2-memxor@gmail.com>
References: <20210830173424.1385796-2-memxor@gmail.com>
TO: Kumar Kartikeya Dwivedi <memxor@gmail.com>

Hi Kumar,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/Support-kernel-module-function-calls-from-eBPF/20210831-013531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
:::::: branch date: 32 hours ago
:::::: commit date: 32 hours ago
config: i386-randconfig-c001-20210830 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e868250a992dc2f10616aa6e2882072bb42bb1c5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kumar-Kartikeya-Dwivedi/Support-kernel-module-function-calls-from-eBPF/20210831-013531
        git checkout e868250a992dc2f10616aa6e2882072bb42bb1c5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 clang-analyzer 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


clang-analyzer warnings: (new ones prefixed by >>)
   drivers/acpi/acpica/dspkginit.c:94:3: note: Taking false branch
                   if (!obj_desc) {
                   ^
   drivers/acpi/acpica/dspkginit.c:101:6: note: Assuming the condition is false
           if (obj_desc->package.flags & AOPOBJ_DATA_VALID) {      /* Just in case */
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:101:2: note: Taking false branch
           if (obj_desc->package.flags & AOPOBJ_DATA_VALID) {      /* Just in case */
           ^
   drivers/acpi/acpica/dspkginit.c:111:6: note: Assuming field 'elements' is non-null
           if (!obj_desc->package.elements) {
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:111:2: note: Taking false branch
           if (!obj_desc->package.elements) {
           ^
   drivers/acpi/acpica/dspkginit.c:138:6: note: 'module_level_code' is 0
           if (module_level_code) {
               ^~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:138:2: note: Taking false branch
           if (module_level_code) {
           ^
   drivers/acpi/acpica/dspkginit.c:153:14: note: Assuming 'arg' is non-null
           for (i = 0; arg && (i < element_count); i++) {
                       ^~~
   drivers/acpi/acpica/dspkginit.c:153:14: note: Left side of '&&' is true
   drivers/acpi/acpica/dspkginit.c:153:22: note: Assuming 'i' is < 'element_count'
           for (i = 0; arg && (i < element_count); i++) {
                               ^~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:153:2: note: Loop condition is true.  Entering loop body
           for (i = 0; arg && (i < element_count); i++) {
           ^
   drivers/acpi/acpica/dspkginit.c:154:7: note: Assuming field 'aml_opcode' is not equal to AML_INT_RETURN_VALUE_OP
                   if (arg->common.aml_opcode == AML_INT_RETURN_VALUE_OP) {
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:154:3: note: Taking false branch
                   if (arg->common.aml_opcode == AML_INT_RETURN_VALUE_OP) {
                   ^
   drivers/acpi/acpica/dspkginit.c:205:8: note: Assuming the condition is false
                           if (status == AE_NOT_FOUND) {
                               ^~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:205:4: note: Taking false branch
                           if (status == AE_NOT_FOUND) {
                           ^
   drivers/acpi/acpica/dspkginit.c:210:9: note: 'module_level_code' is 0
                           if (!module_level_code) {
                                ^~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:210:4: note: Taking true branch
                           if (!module_level_code) {
                           ^
   drivers/acpi/acpica/dspkginit.c:219:26: note: Passing null pointer value via 3rd parameter 'state'
                                                                elements[i], NULL,
                                                                             ^
   include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
   #define NULL ((void *)0)
                ^~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:217:5: note: Calling 'acpi_ds_init_package_element'
                                   acpi_ds_init_package_element(0,
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:332:6: note: Assuming 'source_object' is non-null
           if (!source_object) {
               ^~~~~~~~~~~~~~
   drivers/acpi/acpica/dspkginit.c:332:2: note: Taking false branch
           if (!source_object) {
           ^
   drivers/acpi/acpica/dspkginit.c:342:6: note: Assuming 'context' is null
           if (context) {
               ^~~~~~~
   drivers/acpi/acpica/dspkginit.c:342:2: note: Taking false branch
           if (context) {
           ^
   drivers/acpi/acpica/dspkginit.c:350:17: note: Dereference of null pointer
                   element_ptr = state->pkg.this_target_obj;
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   4 warnings generated.
   Suppressed 4 warnings (4 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   26 warnings generated.
   Suppressed 26 warnings (26 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   4 warnings generated.
   Suppressed 4 warnings (4 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   5 warnings generated.
   kernel/trace/trace_probe.c:195:3: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
                   strcpy(p, trace_probe_log.argv[i]);
                   ^~~~~~
   kernel/trace/trace_probe.c:195:3: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
                   strcpy(p, trace_probe_log.argv[i]);
                   ^~~~~~
   Suppressed 4 warnings (4 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   3 warnings generated.
   Suppressed 3 warnings (2 in non-user code, 1 with check filters).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   5 warnings generated.
   Suppressed 5 warnings (4 in non-user code, 1 with check filters).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   6 warnings generated.
>> kernel/bpf/syscall.c:2286:14: warning: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
                           mod_btf = btf_get_by_fd(fds[i]);
                                     ^             ~~~~~~
   kernel/bpf/syscall.c:2170:6: note: Assuming the condition is false
           if (CHECK_ATTR(BPF_PROG_LOAD))
               ^
   kernel/bpf/syscall.c:716:2: note: expanded from macro 'CHECK_ATTR'
           memchr_inv((void *) &attr->CMD##_LAST_FIELD + \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2170:2: note: Taking false branch
           if (CHECK_ATTR(BPF_PROG_LOAD))
           ^
   kernel/bpf/syscall.c:2173:6: note: Assuming the condition is false
           if (attr->prog_flags & ~(BPF_F_STRICT_ALIGNMENT |
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2173:2: note: Taking false branch
           if (attr->prog_flags & ~(BPF_F_STRICT_ALIGNMENT |
           ^
   kernel/bpf/syscall.c:2180:58: note: Left side of '&&' is false
           if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) &&
                                                                   ^
   kernel/bpf/syscall.c:2186:6: note: Assuming the condition is false
           if (strncpy_from_bpfptr(license,
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2186:2: note: Taking false branch
           if (strncpy_from_bpfptr(license,
           ^
   kernel/bpf/syscall.c:2195:6: note: Assuming field 'insn_cnt' is not equal to 0
           if (attr->insn_cnt == 0 ||
               ^~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2195:6: note: Left side of '||' is false
   kernel/bpf/syscall.c:2196:24: note: Assuming the condition is false
               attr->insn_cnt > (bpf_capable() ? BPF_COMPLEXITY_LIMIT_INSNS : BPF_MAXINSNS))
                                 ^~~~~~~~~~~~~
   kernel/bpf/syscall.c:2196:24: note: '?' condition is false
   kernel/bpf/syscall.c:2196:6: note: Assuming the condition is false
               attr->insn_cnt > (bpf_capable() ? BPF_COMPLEXITY_LIMIT_INSNS : BPF_MAXINSNS))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2195:2: note: Taking false branch
           if (attr->insn_cnt == 0 ||
           ^
   kernel/bpf/syscall.c:2198:6: note: Assuming 'type' is equal to BPF_PROG_TYPE_SOCKET_FILTER
           if (type != BPF_PROG_TYPE_SOCKET_FILTER &&
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2198:42: note: Left side of '&&' is false
           if (type != BPF_PROG_TYPE_SOCKET_FILTER &&
                                                   ^
   kernel/bpf/syscall.c:2203:6: note: Calling 'is_net_admin_prog_type'
           if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN) && !capable(CAP_SYS_ADMIN))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2111:2: note: Control jumps to the 'default' case at line 2135
           switch (prog_type) {
           ^
   kernel/bpf/syscall.c:2136:3: note: Returning zero, which participates in a condition later
                   return false;
                   ^~~~~~~~~~~~
   kernel/bpf/syscall.c:2203:6: note: Returning from 'is_net_admin_prog_type'
           if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN) && !capable(CAP_SYS_ADMIN))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2203:35: note: Left side of '&&' is false
           if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN) && !capable(CAP_SYS_ADMIN))
                                            ^
   kernel/bpf/syscall.c:2205:6: note: Calling 'is_perfmon_prog_type'
           if (is_perfmon_prog_type(type) && !perfmon_capable())
               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2142:2: note: Control jumps to the 'default' case at line 2153
           switch (prog_type) {
           ^
   kernel/bpf/syscall.c:2154:3: note: Returning zero, which participates in a condition later
                   return false;
                   ^~~~~~~~~~~~
   kernel/bpf/syscall.c:2205:6: note: Returning from 'is_perfmon_prog_type'
           if (is_perfmon_prog_type(type) && !perfmon_capable())
               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2205:33: note: Left side of '&&' is false
           if (is_perfmon_prog_type(type) && !perfmon_capable())
                                          ^
   kernel/bpf/syscall.c:2207:6: note: Assuming field 'kfunc_btf_fds_cnt' is <= MAX_KFUNC_DESCS
           if (attr->kfunc_btf_fds_cnt > MAX_KFUNC_DESCS)
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2207:2: note: Taking false branch
           if (attr->kfunc_btf_fds_cnt > MAX_KFUNC_DESCS)
           ^
   kernel/bpf/syscall.c:2213:6: note: Assuming field 'attach_prog_fd' is 0
           if (attr->attach_prog_fd) {
               ^~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2213:2: note: Taking false branch
           if (attr->attach_prog_fd) {
           ^
   kernel/bpf/syscall.c:2228:13: note: Assuming field 'attach_btf_id' is 0
           } else if (attr->attach_btf_id) {
                      ^~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:2228:9: note: Taking false branch
           } else if (attr->attach_btf_id) {
                  ^
   kernel/bpf/syscall.c:2238:2: note: Calling 'bpf_prog_load_fixup_attach_type'
           bpf_prog_load_fixup_attach_type(attr);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/bpf/syscall.c:1994:2: note: 'Default' branch taken. Execution continues on line 1994
           switch (attr->prog_type) {
           ^

vim +2286 kernel/bpf/syscall.c

09756af46893c1 Alexei Starovoitov      2014-09-26  2160  
af2ac3e13e4575 Alexei Starovoitov      2021-05-13  2161  static int bpf_prog_load(union bpf_attr *attr, bpfptr_t uattr)
09756af46893c1 Alexei Starovoitov      2014-09-26  2162  {
09756af46893c1 Alexei Starovoitov      2014-09-26  2163  	enum bpf_prog_type type = attr->prog_type;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2164  	struct bpf_prog *prog, *dst_prog = NULL;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2165  	struct btf *attach_btf = NULL;
09756af46893c1 Alexei Starovoitov      2014-09-26  2166  	char license[128];
09756af46893c1 Alexei Starovoitov      2014-09-26  2167  	bool is_gpl;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2168  	int err;
09756af46893c1 Alexei Starovoitov      2014-09-26  2169  
09756af46893c1 Alexei Starovoitov      2014-09-26  2170  	if (CHECK_ATTR(BPF_PROG_LOAD))
09756af46893c1 Alexei Starovoitov      2014-09-26  2171  		return -EINVAL;
09756af46893c1 Alexei Starovoitov      2014-09-26  2172  
c240eff63a1cf1 Jiong Wang              2019-05-24  2173  	if (attr->prog_flags & ~(BPF_F_STRICT_ALIGNMENT |
c240eff63a1cf1 Jiong Wang              2019-05-24  2174  				 BPF_F_ANY_ALIGNMENT |
10d274e880eb20 Alexei Starovoitov      2019-08-22  2175  				 BPF_F_TEST_STATE_FREQ |
1e6c62a8821557 Alexei Starovoitov      2020-08-27  2176  				 BPF_F_SLEEPABLE |
c240eff63a1cf1 Jiong Wang              2019-05-24  2177  				 BPF_F_TEST_RND_HI32))
e07b98d9bffe41 David S. Miller         2017-05-10  2178  		return -EINVAL;
e07b98d9bffe41 David S. Miller         2017-05-10  2179  
e9ee9efc0d1765 David Miller            2018-11-30  2180  	if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) &&
e9ee9efc0d1765 David Miller            2018-11-30  2181  	    (attr->prog_flags & BPF_F_ANY_ALIGNMENT) &&
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2182  	    !bpf_capable())
e9ee9efc0d1765 David Miller            2018-11-30  2183  		return -EPERM;
e9ee9efc0d1765 David Miller            2018-11-30  2184  
09756af46893c1 Alexei Starovoitov      2014-09-26  2185  	/* copy eBPF program license from user space */
af2ac3e13e4575 Alexei Starovoitov      2021-05-13  2186  	if (strncpy_from_bpfptr(license,
af2ac3e13e4575 Alexei Starovoitov      2021-05-13  2187  				make_bpfptr(attr->license, uattr.is_kernel),
09756af46893c1 Alexei Starovoitov      2014-09-26  2188  				sizeof(license) - 1) < 0)
09756af46893c1 Alexei Starovoitov      2014-09-26  2189  		return -EFAULT;
09756af46893c1 Alexei Starovoitov      2014-09-26  2190  	license[sizeof(license) - 1] = 0;
09756af46893c1 Alexei Starovoitov      2014-09-26  2191  
09756af46893c1 Alexei Starovoitov      2014-09-26  2192  	/* eBPF programs must be GPL compatible to use GPL-ed functions */
09756af46893c1 Alexei Starovoitov      2014-09-26  2193  	is_gpl = license_is_gpl_compatible(license);
09756af46893c1 Alexei Starovoitov      2014-09-26  2194  
c04c0d2b968ac4 Alexei Starovoitov      2019-04-01  2195  	if (attr->insn_cnt == 0 ||
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2196  	    attr->insn_cnt > (bpf_capable() ? BPF_COMPLEXITY_LIMIT_INSNS : BPF_MAXINSNS))
ef0915cacd04c9 Daniel Borkmann         2016-12-07  2197  		return -E2BIG;
80b7d81912d807 Chenbo Feng             2017-05-31  2198  	if (type != BPF_PROG_TYPE_SOCKET_FILTER &&
80b7d81912d807 Chenbo Feng             2017-05-31  2199  	    type != BPF_PROG_TYPE_CGROUP_SKB &&
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2200  	    !bpf_capable())
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2201  		return -EPERM;
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2202  
b338cb921e6739 Maciej Żenczykowski     2020-06-20  2203  	if (is_net_admin_prog_type(type) && !capable(CAP_NET_ADMIN) && !capable(CAP_SYS_ADMIN))
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2204  		return -EPERM;
2c78ee898d8f10 Alexei Starovoitov      2020-05-13  2205  	if (is_perfmon_prog_type(type) && !perfmon_capable())
1be7f75d1668d6 Alexei Starovoitov      2015-10-07  2206  		return -EPERM;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2207  	if (attr->kfunc_btf_fds_cnt > MAX_KFUNC_DESCS)
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2208  		return -E2BIG;
1be7f75d1668d6 Alexei Starovoitov      2015-10-07  2209  
290248a5b7d829 Andrii Nakryiko         2020-12-03  2210  	/* attach_prog_fd/attach_btf_obj_fd can specify fd of either bpf_prog
290248a5b7d829 Andrii Nakryiko         2020-12-03  2211  	 * or btf, we need to check which one it is
290248a5b7d829 Andrii Nakryiko         2020-12-03  2212  	 */
290248a5b7d829 Andrii Nakryiko         2020-12-03  2213  	if (attr->attach_prog_fd) {
290248a5b7d829 Andrii Nakryiko         2020-12-03  2214  		dst_prog = bpf_prog_get(attr->attach_prog_fd);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2215  		if (IS_ERR(dst_prog)) {
290248a5b7d829 Andrii Nakryiko         2020-12-03  2216  			dst_prog = NULL;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2217  			attach_btf = btf_get_by_fd(attr->attach_btf_obj_fd);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2218  			if (IS_ERR(attach_btf))
290248a5b7d829 Andrii Nakryiko         2020-12-03  2219  				return -EINVAL;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2220  			if (!btf_is_kernel(attach_btf)) {
8bdd8e275ede97 Andrii Nakryiko         2020-12-07  2221  				/* attaching through specifying bpf_prog's BTF
8bdd8e275ede97 Andrii Nakryiko         2020-12-07  2222  				 * objects directly might be supported eventually
8bdd8e275ede97 Andrii Nakryiko         2020-12-07  2223  				 */
290248a5b7d829 Andrii Nakryiko         2020-12-03  2224  				btf_put(attach_btf);
8bdd8e275ede97 Andrii Nakryiko         2020-12-07  2225  				return -ENOTSUPP;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2226  			}
290248a5b7d829 Andrii Nakryiko         2020-12-03  2227  		}
290248a5b7d829 Andrii Nakryiko         2020-12-03  2228  	} else if (attr->attach_btf_id) {
290248a5b7d829 Andrii Nakryiko         2020-12-03  2229  		/* fall back to vmlinux BTF, if BTF type ID is specified */
290248a5b7d829 Andrii Nakryiko         2020-12-03  2230  		attach_btf = bpf_get_btf_vmlinux();
290248a5b7d829 Andrii Nakryiko         2020-12-03  2231  		if (IS_ERR(attach_btf))
290248a5b7d829 Andrii Nakryiko         2020-12-03  2232  			return PTR_ERR(attach_btf);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2233  		if (!attach_btf)
290248a5b7d829 Andrii Nakryiko         2020-12-03  2234  			return -EINVAL;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2235  		btf_get(attach_btf);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2236  	}
290248a5b7d829 Andrii Nakryiko         2020-12-03  2237  
aac3fc320d9404 Andrey Ignatov          2018-03-30  2238  	bpf_prog_load_fixup_attach_type(attr);
ccfe29eb29c2ed Alexei Starovoitov      2019-10-15  2239  	if (bpf_prog_load_check_attach(type, attr->expected_attach_type,
290248a5b7d829 Andrii Nakryiko         2020-12-03  2240  				       attach_btf, attr->attach_btf_id,
290248a5b7d829 Andrii Nakryiko         2020-12-03  2241  				       dst_prog)) {
290248a5b7d829 Andrii Nakryiko         2020-12-03  2242  		if (dst_prog)
290248a5b7d829 Andrii Nakryiko         2020-12-03  2243  			bpf_prog_put(dst_prog);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2244  		if (attach_btf)
290248a5b7d829 Andrii Nakryiko         2020-12-03  2245  			btf_put(attach_btf);
5e43f899b03a34 Andrey Ignatov          2018-03-30  2246  		return -EINVAL;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2247  	}
5e43f899b03a34 Andrey Ignatov          2018-03-30  2248  
09756af46893c1 Alexei Starovoitov      2014-09-26  2249  	/* plain bpf_prog allocation */
09756af46893c1 Alexei Starovoitov      2014-09-26  2250  	prog = bpf_prog_alloc(bpf_prog_size(attr->insn_cnt), GFP_USER);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2251  	if (!prog) {
290248a5b7d829 Andrii Nakryiko         2020-12-03  2252  		if (dst_prog)
290248a5b7d829 Andrii Nakryiko         2020-12-03  2253  			bpf_prog_put(dst_prog);
290248a5b7d829 Andrii Nakryiko         2020-12-03  2254  		if (attach_btf)
290248a5b7d829 Andrii Nakryiko         2020-12-03  2255  			btf_put(attach_btf);
09756af46893c1 Alexei Starovoitov      2014-09-26  2256  		return -ENOMEM;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2257  	}
09756af46893c1 Alexei Starovoitov      2014-09-26  2258  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2259  	if (attr->kfunc_btf_fds_cnt) {
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2260  		struct bpf_kfunc_btf_tab *tab;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2261  		int fds[MAX_KFUNC_DESCS], i;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2262  		bpfptr_t kfunc_btf_fds;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2263  		u32 kfunc_btf_size, n;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2264  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2265  		kfunc_btf_size = min_t(u32, MAX_KFUNC_DESCS, attr->kfunc_btf_fds_cnt);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2266  		kfunc_btf_fds = make_bpfptr(attr->kfunc_btf_fds, uattr.is_kernel);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2267  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2268  		err = -EFAULT;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2269  		if (copy_from_bpfptr(fds, kfunc_btf_fds, kfunc_btf_size * sizeof(int)))
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2270  			goto free_prog;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2271  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2272  		err = -ENOMEM;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2273  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2274  		n = kfunc_btf_size;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2275  		kfunc_btf_size *= sizeof(prog->aux->kfunc_btf_tab->btfs[0]);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2276  		kfunc_btf_size += sizeof(*prog->aux->kfunc_btf_tab);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2277  		prog->aux->kfunc_btf_tab = kzalloc(kfunc_btf_size, GFP_KERNEL);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2278  		if (!prog->aux->kfunc_btf_tab)
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2279  			goto free_prog;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2280  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2281  		tab = prog->aux->kfunc_btf_tab;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2282  		for (i = 0; i < n; i++) {
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2283  			struct btf_mod_pair *p;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2284  			struct btf *mod_btf;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2285  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30 @2286  			mod_btf = btf_get_by_fd(fds[i]);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2287  			if (IS_ERR(mod_btf)) {
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2288  				err = PTR_ERR(mod_btf);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2289  				goto free_prog;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2290  			}
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2291  			if (!btf_is_module(mod_btf)) {
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2292  				err = -EINVAL;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2293  				btf_put(mod_btf);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2294  				goto free_prog;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2295  			}
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2296  
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2297  			p = &tab->btfs[tab->nr_btfs];
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2298  			p->module = btf_try_get_module(mod_btf);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2299  			if (!p->module) {
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2300  				btf_put(mod_btf);
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2301  				goto free_prog;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2302  			}
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2303  			p->btf = mod_btf;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2304  			tab->nr_btfs++;
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2305  		}
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2306  	}
e868250a992dc2 Kumar Kartikeya Dwivedi 2021-08-30  2307  
5e43f899b03a34 Andrey Ignatov          2018-03-30  2308  	prog->expected_attach_type = attr->expected_attach_type;
290248a5b7d829 Andrii Nakryiko         2020-12-03  2309  	prog->aux->attach_btf = attach_btf;
ccfe29eb29c2ed Alexei Starovoitov      2019-10-15  2310  	prog->aux->attach_btf_id = attr->attach_btf_id;
3aac1ead5eb6b7 Toke Høiland-Jørgensen  2020-09-29  2311  	prog->aux->dst_prog = dst_prog;
9a18eedb145d08 Jakub Kicinski          2017-12-27  2312  	prog->aux->offload_requested = !!attr->prog_ifindex;
1e6c62a8821557 Alexei Starovoitov      2020-08-27  2313  	prog->aux->sleepable = attr->prog_flags & BPF_F_SLEEPABLE;
9a18eedb145d08 Jakub Kicinski          2017-12-27  2314  
afdb09c720b62b Chenbo Feng             2017-10-18  2315  	err = security_bpf_prog_alloc(prog->aux);
aaac3ba95e4c8b Alexei Starovoitov      2015-10-07  2316  	if (err)
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2317  		goto free_prog;
afdb09c720b62b Chenbo Feng             2017-10-18  2318  
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2319  	prog->aux->user = get_current_user();
09756af46893c1 Alexei Starovoitov      2014-09-26  2320  	prog->len = attr->insn_cnt;
09756af46893c1 Alexei Starovoitov      2014-09-26  2321  
09756af46893c1 Alexei Starovoitov      2014-09-26  2322  	err = -EFAULT;
af2ac3e13e4575 Alexei Starovoitov      2021-05-13  2323  	if (copy_from_bpfptr(prog->insns,
af2ac3e13e4575 Alexei Starovoitov      2021-05-13  2324  			     make_bpfptr(attr->insns, uattr.is_kernel),
aafe6ae9cee32d Daniel Borkmann         2016-12-18  2325  			     bpf_prog_insn_size(prog)) != 0)
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2326  		goto free_prog_sec;
09756af46893c1 Alexei Starovoitov      2014-09-26  2327  
09756af46893c1 Alexei Starovoitov      2014-09-26  2328  	prog->orig_prog = NULL;
a91263d520246b Daniel Borkmann         2015-09-30  2329  	prog->jited = 0;
09756af46893c1 Alexei Starovoitov      2014-09-26  2330  
85192dbf4de087 Andrii Nakryiko         2019-11-17  2331  	atomic64_set(&prog->aux->refcnt, 1);
a91263d520246b Daniel Borkmann         2015-09-30  2332  	prog->gpl_compatible = is_gpl ? 1 : 0;
09756af46893c1 Alexei Starovoitov      2014-09-26  2333  
9a18eedb145d08 Jakub Kicinski          2017-12-27  2334  	if (bpf_prog_is_dev_bound(prog->aux)) {
ab3f0063c48c26 Jakub Kicinski          2017-11-03  2335  		err = bpf_prog_offload_init(prog, attr);
ab3f0063c48c26 Jakub Kicinski          2017-11-03  2336  		if (err)
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2337  			goto free_prog_sec;
ab3f0063c48c26 Jakub Kicinski          2017-11-03  2338  	}
ab3f0063c48c26 Jakub Kicinski          2017-11-03  2339  
09756af46893c1 Alexei Starovoitov      2014-09-26  2340  	/* find program type: socket_filter vs tracing_filter */
09756af46893c1 Alexei Starovoitov      2014-09-26  2341  	err = find_prog_type(type, prog);
09756af46893c1 Alexei Starovoitov      2014-09-26  2342  	if (err < 0)
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2343  		goto free_prog_sec;
09756af46893c1 Alexei Starovoitov      2014-09-26  2344  
9285ec4c8b61d4 Jason A. Donenfeld      2019-06-21  2345  	prog->aux->load_time = ktime_get_boottime_ns();
8e7ae2518f5265 Martin KaFai Lau        2020-03-13  2346  	err = bpf_obj_name_cpy(prog->aux->name, attr->prog_name,
8e7ae2518f5265 Martin KaFai Lau        2020-03-13  2347  			       sizeof(attr->prog_name));
8e7ae2518f5265 Martin KaFai Lau        2020-03-13  2348  	if (err < 0)
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2349  		goto free_prog_sec;
cb4d2b3f03d8ee Martin KaFai Lau        2017-09-27  2350  
09756af46893c1 Alexei Starovoitov      2014-09-26  2351  	/* run eBPF verifier */
838e96904ff3fc Yonghong Song           2018-11-19  2352  	err = bpf_check(&prog, attr, uattr);
09756af46893c1 Alexei Starovoitov      2014-09-26  2353  	if (err < 0)
09756af46893c1 Alexei Starovoitov      2014-09-26  2354  		goto free_used_maps;
09756af46893c1 Alexei Starovoitov      2014-09-26  2355  
d1c55ab5e41fcd Daniel Borkmann         2016-05-13  2356  	prog = bpf_prog_select_runtime(prog, &err);
04fd61ab36ec06 Alexei Starovoitov      2015-05-19  2357  	if (err < 0)
04fd61ab36ec06 Alexei Starovoitov      2015-05-19  2358  		goto free_used_maps;
09756af46893c1 Alexei Starovoitov      2014-09-26  2359  
dc4bb0e2356149 Martin KaFai Lau        2017-06-05  2360  	err = bpf_prog_alloc_id(prog);
dc4bb0e2356149 Martin KaFai Lau        2017-06-05  2361  	if (err)
dc4bb0e2356149 Martin KaFai Lau        2017-06-05  2362  		goto free_used_maps;
dc4bb0e2356149 Martin KaFai Lau        2017-06-05  2363  
c751798aa224fa Daniel Borkmann         2019-08-23  2364  	/* Upon success of bpf_prog_alloc_id(), the BPF prog is
c751798aa224fa Daniel Borkmann         2019-08-23  2365  	 * effectively publicly exposed. However, retrieving via
c751798aa224fa Daniel Borkmann         2019-08-23  2366  	 * bpf_prog_get_fd_by_id() will take another reference,
c751798aa224fa Daniel Borkmann         2019-08-23  2367  	 * therefore it cannot be gone underneath us.
c751798aa224fa Daniel Borkmann         2019-08-23  2368  	 *
c751798aa224fa Daniel Borkmann         2019-08-23  2369  	 * Only for the time /after/ successful bpf_prog_new_fd()
c751798aa224fa Daniel Borkmann         2019-08-23  2370  	 * and before returning to userspace, we might just hold
c751798aa224fa Daniel Borkmann         2019-08-23  2371  	 * one reference and any parallel close on that fd could
c751798aa224fa Daniel Borkmann         2019-08-23  2372  	 * rip everything out. Hence, below notifications must
c751798aa224fa Daniel Borkmann         2019-08-23  2373  	 * happen before bpf_prog_new_fd().
c751798aa224fa Daniel Borkmann         2019-08-23  2374  	 *
c751798aa224fa Daniel Borkmann         2019-08-23  2375  	 * Also, any failure handling from this point onwards must
c751798aa224fa Daniel Borkmann         2019-08-23  2376  	 * be using bpf_prog_put() given the program is exposed.
b16d9aa4c2b90a Martin KaFai Lau        2017-06-05  2377  	 */
74451e66d516c5 Daniel Borkmann         2017-02-16  2378  	bpf_prog_kallsyms_add(prog);
6ee52e2a3fe4ea Song Liu                2019-01-17  2379  	perf_event_bpf_event(prog, PERF_BPF_EVENT_PROG_LOAD, 0);
bae141f54be83b Daniel Borkmann         2019-12-06  2380  	bpf_audit_prog(prog, BPF_AUDIT_LOAD);
c751798aa224fa Daniel Borkmann         2019-08-23  2381  
c751798aa224fa Daniel Borkmann         2019-08-23  2382  	err = bpf_prog_new_fd(prog);
c751798aa224fa Daniel Borkmann         2019-08-23  2383  	if (err < 0)
c751798aa224fa Daniel Borkmann         2019-08-23  2384  		bpf_prog_put(prog);
09756af46893c1 Alexei Starovoitov      2014-09-26  2385  	return err;
09756af46893c1 Alexei Starovoitov      2014-09-26  2386  
09756af46893c1 Alexei Starovoitov      2014-09-26  2387  free_used_maps:
cd7455f1013ef9 Daniel Borkmann         2019-10-22  2388  	/* In case we have subprogs, we need to wait for a grace
cd7455f1013ef9 Daniel Borkmann         2019-10-22  2389  	 * period before we can tear down JIT memory since symbols
cd7455f1013ef9 Daniel Borkmann         2019-10-22  2390  	 * are already exposed under kallsyms.
cd7455f1013ef9 Daniel Borkmann         2019-10-22  2391  	 */
cd7455f1013ef9 Daniel Borkmann         2019-10-22  2392  	__bpf_prog_put_noref(prog, prog->aux->func_cnt);
cd7455f1013ef9 Daniel Borkmann         2019-10-22  2393  	return err;
afdb09c720b62b Chenbo Feng             2017-10-18  2394  free_prog_sec:
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2395  	free_uid(prog->aux->user);
afdb09c720b62b Chenbo Feng             2017-10-18  2396  	security_bpf_prog_free(prog->aux);
3ac1f01b43b6e2 Roman Gushchin          2020-12-01  2397  free_prog:
22dc4a0f5ed11b Andrii Nakryiko         2020-12-03  2398  	if (prog->aux->attach_btf)
22dc4a0f5ed11b Andrii Nakryiko         2020-12-03  2399  		btf_put(prog->aux->attach_btf);
09756af46893c1 Alexei Starovoitov      2014-09-26  2400  	bpf_prog_free(prog);
09756af46893c1 Alexei Starovoitov      2014-09-26  2401  	return err;
09756af46893c1 Alexei Starovoitov      2014-09-26  2402  }
09756af46893c1 Alexei Starovoitov      2014-09-26  2403  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32870 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH bpf-next RFC v1 0/8] Support kernel module function calls from eBPF
@ 2021-08-30 17:34 Kumar Kartikeya Dwivedi
  2021-08-30 17:34 ` [PATCH bpf-next RFC v1 1/8] bpf: Introduce BPF support for kernel module function calls Kumar Kartikeya Dwivedi
  0 siblings, 1 reply; 5+ messages in thread
From: Kumar Kartikeya Dwivedi @ 2021-08-30 17:34 UTC (permalink / raw)
  To: bpf
  Cc: Kumar Kartikeya Dwivedi, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
	Jesper Dangaard Brouer, Toke Høiland-Jørgensen, netdev

This set enables kernel module function calls, and also modifies verifier logic
to permit invalid kernel function calls as long as they are pruned as part of
dead code elimination. This is done to provide better runtime portability for
BPF objects, which can conditionally disable parts of code that are pruned later
by the verifier (e.g. const volatile vars, kconfig options). libbpf
modifications are made along with kernel changes to support module function
calls.

It also converts TCP congestion control objects to use the module kfunc support
instead of relying on IS_BUILTIN ifdef.

Kumar Kartikeya Dwivedi (8):
  bpf: Introduce BPF support for kernel module function calls
  bpf: Be conservative during verification for invalid kfunc calls
  libbpf: Support kernel module function calls
  libbpf: Resolve invalid kfunc calls with imm = 0, off = 0
  tools: Allow specifying base BTF file in resolve_btfids
  bpf: btf: Introduce helpers for dynamic BTF set registration
  bpf: enable TCP congestion control kfunc from modules
  bpf, selftests: Add basic test for module kfunc call

 include/linux/bpf.h                           |   1 +
 include/linux/bpfptr.h                        |   1 +
 include/linux/btf.h                           |  18 +++
 include/linux/filter.h                        |   9 ++
 include/uapi/linux/bpf.h                      |   3 +-
 kernel/bpf/btf.c                              |  37 +++++++
 kernel/bpf/core.c                             |  14 +++
 kernel/bpf/syscall.c                          |  55 +++++++++-
 kernel/bpf/verifier.c                         | 103 ++++++++++++++----
 kernel/trace/bpf_trace.c                      |   1 +
 net/ipv4/bpf_tcp_ca.c                         |  34 +-----
 net/ipv4/tcp_bbr.c                            |  28 ++++-
 net/ipv4/tcp_cubic.c                          |  26 ++++-
 net/ipv4/tcp_dctcp.c                          |  26 ++++-
 scripts/Makefile.modfinal                     |   1 +
 tools/bpf/resolve_btfids/main.c               |  19 +++-
 tools/include/uapi/linux/bpf.h                |   3 +-
 tools/lib/bpf/bpf.c                           |   3 +
 tools/lib/bpf/libbpf.c                        |  91 ++++++++++++++--
 tools/lib/bpf/libbpf_internal.h               |   2 +
 tools/testing/selftests/bpf/Makefile          |   3 +-
 .../selftests/bpf/bpf_testmod/bpf_testmod.c   |  23 +++-
 .../selftests/bpf/prog_tests/ksyms_module.c   |  10 +-
 .../selftests/bpf/progs/test_ksyms_module.c   |   9 ++
 24 files changed, 446 insertions(+), 74 deletions(-)

-- 
2.33.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-01  1:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01  1:16 [PATCH bpf-next RFC v1 1/8] bpf: Introduce BPF support for kernel module function calls kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-08-30 17:34 [PATCH bpf-next RFC v1 0/8] Support kernel module function calls from eBPF Kumar Kartikeya Dwivedi
2021-08-30 17:34 ` [PATCH bpf-next RFC v1 1/8] bpf: Introduce BPF support for kernel module function calls Kumar Kartikeya Dwivedi
2021-08-30 20:01   ` Alexei Starovoitov
2021-08-30 20:03   ` kernel test robot
2021-08-30 22:19   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.