From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CCEB72 for ; Wed, 1 Sep 2021 09:44:34 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 9E9435C0211; Wed, 1 Sep 2021 05:44:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 01 Sep 2021 05:44:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ObGIxgtavz3gno3t76LBvmoj5Ql 2fJX6NjBj+UThj6Q=; b=fD9vSbiQMjsju5Wr/6YMldqR0dR7nVHim4kMKlkpg6e N/ddGyhhZs7fQOS46tNWmUZvVhrJRwuj5C1DGlqdF4XjYnL+EJ/13Kgsi4m9O6/E Qu1JHnkKlgykl1gBYgGHzjaly7yN4yQgkqiMRaVk4iGeRg7H5RfRi2oRrrjeJaWh ntH7ve8skERGo5Kn1Ju9i028n2WWnUSq2D1N2j2NDFWryNAxxCt0DpvpjSjACqcC 2WngnQ0ZRtEJTQrw7gs3MCZcadQ5UwZ4M0sPTcSoAhVzwNaqbpt7kqymUIB5lZOW 0nrYtHCLkx6A8okEnYzRVAEMFfOozKKIdzPlA9WnfBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ObGIxg tavz3gno3t76LBvmoj5Ql2fJX6NjBj+UThj6Q=; b=Kf+ltLw9cRH78lTyx0wdM0 +wXcWBGj3THi5181qi7Z/j5L2e0Omvf1dNrNjnf2Cv4wEIIbeT8/jGm6QZoCPjXd yzRQUwNeUgq9I8wLNkP6l09eVakoyzbHvyltddc3wANztx+AW4M9pAWzberFmF7J X8IVj990Agr2L/6CQaR3kON1bjTCo75RCMOIfJsiOEtwEXhd8p4lB5s2Vr8kWr16 eqVvfWrIFSBgoVhzAaTbiy8xsPV1ShYdBGszZVzA83VibdaJNvJZ6/WVU00p2N4Q 2kL83GgVm/EfAvf+NusQINP9AwHLtxM014jWQpsaNzvL+a5yVvWRrQJAm5p6oZwA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvfedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Sep 2021 05:44:33 -0400 (EDT) Date: Wed, 1 Sep 2021 11:44:32 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , stable , Roman Stratiienko Subject: Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h Message-ID: <20210901094432.5kc33m2bnmkbjahq@gilmour> References: <20210831184819.93670-1-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jscf64iuvdbjnile" Content-Disposition: inline In-Reply-To: --jscf64iuvdbjnile Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 11:13:01AM +0800, Chen-Yu Tsai wrote: > On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec = wrote: > > > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > > recommendation of having arguments enclosed in parenthesis. While that > > didn't change anything for quiet sometime, it actually become important >=20 > ^ Typo >=20 > > after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: > > Remove redundant CSC matrices"). > > > > Without this fix, colours are completely off for supported YVU formats > > on SoCs with DE2 (A64, H3, R40, etc.). > > > > Fix the issue by enclosing macro arguments in parenthesis. > > > > Cc: stable@vger.kernel.org # 5.12+ > > Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library") > > Reported-by: Roman Stratiienko > > Signed-off-by: Jernej Skrabec >=20 > Otherwise, >=20 > Reviewed-by: Chen-Yu Tsai Fixed the typo and applied, thanks Maxime --jscf64iuvdbjnile Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYS9LgAAKCRDj7w1vZxhR xQCQAP4rfWKEyPEnTNdnRgDKYsiznnq7wZw/kcJzMyysWVHTCAD/Th6T6Tj85KFX yNQia6HiL+VmJWmGWJtFXjh0G495iwc= =nV88 -----END PGP SIGNATURE----- --jscf64iuvdbjnile-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66851C432BE for ; Wed, 1 Sep 2021 11:08:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B54E60F3A for ; Wed, 1 Sep 2021 11:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2B54E60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U0fJeKuBg8W35rvaGKU4/60JGe8/d2NdOUdavdqsBgk=; b=OKWfn/jeFf3qfVPGyJI4ieMCT2 t/nTee5XwPEP5+h9L6EvJGgoqhNqcxVtxRwe1sivHVa/JEM8qRh2AW1ikKcaonF7cHHq+GN29jnCb rM0SLupmmdw+kLcBAZBcLjaiGu9RIs1Yq5rPPOaIRwy0b9Y8mfAia6ccveNif0UFWijrGqIh+5RQf J3M6AzTrmBvu7Ent8GIvFHq/bf1pu1fJ7gu4Szg4bqkdrcUEQ6cFgLk+InfO0EiXb8Ufp3UknxoOt hACCGbzk74pRT5i7tk+kWUaV/ugD3KiorxcYbUZKIqNi4hBEWFEgh23FFSY9qskb9CPuz2E0nF/n/ 8rBaSYZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLO3l-005RJY-Q3; Wed, 01 Sep 2021 11:05:39 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLMnK-004ycV-Lw for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 09:44:39 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 9E9435C0211; Wed, 1 Sep 2021 05:44:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 01 Sep 2021 05:44:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ObGIxgtavz3gno3t76LBvmoj5Ql 2fJX6NjBj+UThj6Q=; b=fD9vSbiQMjsju5Wr/6YMldqR0dR7nVHim4kMKlkpg6e N/ddGyhhZs7fQOS46tNWmUZvVhrJRwuj5C1DGlqdF4XjYnL+EJ/13Kgsi4m9O6/E Qu1JHnkKlgykl1gBYgGHzjaly7yN4yQgkqiMRaVk4iGeRg7H5RfRi2oRrrjeJaWh ntH7ve8skERGo5Kn1Ju9i028n2WWnUSq2D1N2j2NDFWryNAxxCt0DpvpjSjACqcC 2WngnQ0ZRtEJTQrw7gs3MCZcadQ5UwZ4M0sPTcSoAhVzwNaqbpt7kqymUIB5lZOW 0nrYtHCLkx6A8okEnYzRVAEMFfOozKKIdzPlA9WnfBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ObGIxg tavz3gno3t76LBvmoj5Ql2fJX6NjBj+UThj6Q=; b=Kf+ltLw9cRH78lTyx0wdM0 +wXcWBGj3THi5181qi7Z/j5L2e0Omvf1dNrNjnf2Cv4wEIIbeT8/jGm6QZoCPjXd yzRQUwNeUgq9I8wLNkP6l09eVakoyzbHvyltddc3wANztx+AW4M9pAWzberFmF7J X8IVj990Agr2L/6CQaR3kON1bjTCo75RCMOIfJsiOEtwEXhd8p4lB5s2Vr8kWr16 eqVvfWrIFSBgoVhzAaTbiy8xsPV1ShYdBGszZVzA83VibdaJNvJZ6/WVU00p2N4Q 2kL83GgVm/EfAvf+NusQINP9AwHLtxM014jWQpsaNzvL+a5yVvWRrQJAm5p6oZwA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvfedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Sep 2021 05:44:33 -0400 (EDT) Date: Wed, 1 Sep 2021 11:44:32 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , stable , Roman Stratiienko Subject: Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h Message-ID: <20210901094432.5kc33m2bnmkbjahq@gilmour> References: <20210831184819.93670-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_024434_851128_91308162 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1966411261640332672==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1966411261640332672== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jscf64iuvdbjnile" Content-Disposition: inline --jscf64iuvdbjnile Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 11:13:01AM +0800, Chen-Yu Tsai wrote: > On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec = wrote: > > > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > > recommendation of having arguments enclosed in parenthesis. While that > > didn't change anything for quiet sometime, it actually become important >=20 > ^ Typo >=20 > > after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: > > Remove redundant CSC matrices"). > > > > Without this fix, colours are completely off for supported YVU formats > > on SoCs with DE2 (A64, H3, R40, etc.). > > > > Fix the issue by enclosing macro arguments in parenthesis. > > > > Cc: stable@vger.kernel.org # 5.12+ > > Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library") > > Reported-by: Roman Stratiienko > > Signed-off-by: Jernej Skrabec >=20 > Otherwise, >=20 > Reviewed-by: Chen-Yu Tsai Fixed the typo and applied, thanks Maxime --jscf64iuvdbjnile Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYS9LgAAKCRDj7w1vZxhR xQCQAP4rfWKEyPEnTNdnRgDKYsiznnq7wZw/kcJzMyysWVHTCAD/Th6T6Tj85KFX yNQia6HiL+VmJWmGWJtFXjh0G495iwc= =nV88 -----END PGP SIGNATURE----- --jscf64iuvdbjnile-- --===============1966411261640332672== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1966411261640332672==--