From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0AEEC432BE for ; Wed, 1 Sep 2021 10:06:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2BAF60234 for ; Wed, 1 Sep 2021 10:06:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2BAF60234 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 80AAA8348F; Wed, 1 Sep 2021 12:06:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="OO4biaJT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 44B3F83492; Wed, 1 Sep 2021 12:06:08 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0628.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::628]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D92C18328F for ; Wed, 1 Sep 2021 12:06:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bebnt1TvQVUdysS5WjGVgsxS14TuPVJUUxK0D4Wpd3NHSncqynT5j2BPilauB3yrGlmy/TdApnIpgvOztCAuNXJdip77v3MEvjJ8geBN0kRzslPOhDouZRYx6oMvWkDkgZy0ho+c2pD4jgglSD4PGpPqJ/5yag6EuCZz/1uNnrRmDbFgP0/GDGRrqV0gjmW/ZbWcGaqlubVeoR7KBbubOqJ2McQIwNIwPFlVIJPPHZpG8wGGuDug/9jBhdRcIom7qYp2uPRRvnJ/QW2wBNqaAKp+4EmPjeD072HqsLPU+OrALOMlcijCOxpvQHBBFWcTPzthC4whByQV7iirBslZ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S9JU4KR4nUrxEUoTbbG4hDuhSIuLbFfSBlkNWDrE6Fo=; b=WFgDCJCp5WM08+fDkeWQAPMJBg1IFmQfe7Zerut3MUN+0l8drVyEQsg2wDCCKZ0JBjgrYHXIsi/5szp7+/6DZhdttQo/fsiVHgAuukstQ0RtStvCmnEKs84ImF8SGJao5GM0m6HM9Ij6xe+55xJhfkUvuYXdtSbH+auNOFj/PVYOct+AUt/FUBMon46PJbqOVEveIse/j0H5Z0tqKpz7oFU1uDDFDkgem249Lc0GotczfzmfNFg6p8r1Xn+oyKIfzDvv1BFiQMsAHLgBblqsLYe1ObQoI5MpdQKm338VgGejZQtXBEqwSrwinxpa58KFOAxH4euJJ7DUhFldKTcsrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S9JU4KR4nUrxEUoTbbG4hDuhSIuLbFfSBlkNWDrE6Fo=; b=OO4biaJT+t+9KdYc/9edBGPDQMT0tn4UA4mja4akFanw/XFdL/SUTIEnHhZ/V211YSR/jJXcJMqfXYTTyRM3bFGJUrZXaZhWV4Gm0BwaYVZznWlcYRlS0lltCbK72h3GETGCaGoNX56nJvvjemXyvkQ3hgdRA5rvGdro6aSzvt8= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Wed, 1 Sep 2021 10:05:55 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 10:05:55 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 2/9] arm: dts: ls1028a: move devices into /soc Thread-Topic: [PATCH v2 2/9] arm: dts: ls1028a: move devices into /soc Thread-Index: AQHXnw8spBctoRE5B0a0md4H0PMGcquO88gA Date: Wed, 1 Sep 2021 10:05:55 +0000 Message-ID: <20210901100554.dsveg5ql2jyetvlh@skbuf> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-3-michael@walle.cc> In-Reply-To: <20210901085522.1712104-3-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67f06e7e-6451-461d-4d0b-08d96d301689 x-ms-traffictypediagnostic: VI1PR04MB6944: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DQbmuf7c+1uqqBqr8ttDzIiOCDawKDgVmhfq5xFaNfAnwDnjSyETnJpemH2Lb1CUsvKlhtqsX7PkIxDqFnYtHeIZorZFyPIrmSMqCIazr34/iJ+1EKQOHFIc2t5s5mn86zasT9iPwCPuesrrx/KGGq1dNT8+sK0ZeZMFzayXLC7Df7axSiMfdWa0lPVRw8YkZX52GCLmoRsQbJUnlvUC9kVLec97LwwIc45lTBk76lNWWsRlvO0SVEXDE4OjQcuaqoElsxgCvLOEpPbqakP9PDbeii0cAI0k/90b5LTeH+JmHE31U8KJa/8Xt6AjvjqgwMp33HSx86iFG8ffAkd3d8K82INwZ0dmrVWz0VrmXrLE8Uf/XsgwZ38JvYaPhfGb3FdBmAXY2aGdQy1UeaFh13bx/VfFzunRaPptCBP4HgBEmUaHtaA7VaRcVennTv/0PW9Cs+U87ih6dKyGnsxH5Un+0mu7HL66wNxOqIXAxBimq2e8pQl237iAp23HW4CLIYTtfRMasdOorb7iCUEKIL6vRKbm203+DCf3E9WtI6tU/DaUy4XePj+rn/V46o5sKnnYIaAVN24uz85FFoXYBg/vlrvukcogwL2wezIIcUIZxZVitskCfqeBQVrRHzDdpVOwg8qtGfwJhlC7R5Y7uSDDAo31T4NyWe9Mhw9jDNQrtwuSGX6FQZl/1AgIbYNu x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(366004)(376002)(39860400002)(346002)(136003)(396003)(6916009)(91956017)(8676002)(5660300002)(76116006)(6506007)(186003)(64756008)(6486002)(9686003)(6512007)(66476007)(26005)(38070700005)(83380400001)(122000001)(38100700002)(478600001)(33716001)(66946007)(54906003)(71200400001)(1076003)(4326008)(8936002)(66556008)(66446008)(86362001)(44832011)(2906002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r5V41Sa6mzJeR8xHumgdgjfIv6RBvp8HMOB1DdBw8I2XRBquEkivfxjojr8j?= =?us-ascii?Q?W7UjWImei4w67c8QUUM65zUlAXgOfWvcNdruHA98PeHpwIbY26IwXMb9Ntcz?= =?us-ascii?Q?FR9QduQCW7uHr/PE9xgl1czInUJkpaLR4wmT1dZroIxfo2A2yWywzkypImFj?= =?us-ascii?Q?aB7uQjIDDurLZgPVTjpGsJCVBlIRUznG/Z+x+IwRAzFx5mheBrhayd1Jhkkb?= =?us-ascii?Q?SiZ39dKb1uIZE+94ASpX23ZzN1Pcy4n7brKue6twdZAbCFBUWz1qYzedyrxI?= =?us-ascii?Q?JLaKZBLEryeWXKtkYRzkPvHKV1uh+Da6BoRrCxRVGXFfcsnvwuHjfGZjSv/n?= =?us-ascii?Q?AqZHBPNCUnayMKnEsZEVuq91oAYO7sD7yjlCqviANWJQP78wlFoATluTNVQo?= =?us-ascii?Q?9TK+aDgahbCxKKCkvLuBVLA6mJLlRq5YHCH+ZlYXfq/YggLvtUZFQQ/nBj6f?= =?us-ascii?Q?JCGfPkWMeAk7humZ4z/JURH96o2gST588QAPKosrUSqDSs2r8Uja6TkIqFy2?= =?us-ascii?Q?mkdn3rMgaq61+ZkP6Rbf92g3qqgoA9pgCVnadgVMe1gAbmBO1L8B5lJNebkk?= =?us-ascii?Q?Uekx+1QGN9J9zJs7LkJHi05aYWYkbCXwK7Huems+aAfDdO/JXKf/WReFyQdL?= =?us-ascii?Q?+XWsc8pCuNOXbL6OSzREflQ/HCvyuPmM/UUY1A7WO7WnBtsGLdikUdmQ8z6U?= =?us-ascii?Q?fuhDHFBF7P0aO555c6+JtuLESXcMV7bwDccERb5U79Na8Fpchp+lX4p9sXd3?= =?us-ascii?Q?FDpmoGnfgjL5gFH8Bl6RoDPWxFCTAk3iO4dtqcMtyJ9s6GW4iM3ZazhALTLj?= =?us-ascii?Q?PQMz3ZgxtIztQyC50d1D23icLlmNzoPDmg51ZCAdrXKIO+SKvFdO0NFuof/8?= =?us-ascii?Q?/zw1YUwrXyGUP0iAkuUGdthLon77hu7hhDx2t0Z530ho+gBleErpOENeDU1L?= =?us-ascii?Q?vI92cXgBOnrP3zVpGWzePQ2pXq8FTC3QtBxqeFhg+dhDCpgz7Ju93y24q31v?= =?us-ascii?Q?GzjEWOSXSh+8cZ4upQbEggPDgM17gZQLg9wrD/0DhRXPYsS/XFepsHY+uLTr?= =?us-ascii?Q?hwoF9fs3eAe0RRA/864z3vES5apJldOoQ+VVhdWrdt2h3rg+YHxQe2V3Jpn5?= =?us-ascii?Q?Tdlpv41V4svvXNTZ9EIAbVQiqwTjEy9NMCPueq0GY6KGGx/EhpmLISeG6RO2?= =?us-ascii?Q?kV4HX2B/zs6xam1izU5yY1tyGTbI+Qbr2wsnVajwuMxABa3F9a+JQPlByWAw?= =?us-ascii?Q?7OmFSGgnZbdZMZtMg8hhDP69XlHv2B5ziBdfA/swI/FV0ejiuMH8YoLMFUmX?= =?us-ascii?Q?a0VzwvWRxscieC1HhLilPdZR?= Content-Type: text/plain; charset="us-ascii" Content-ID: <0B4FE1FD484A2E4DA985504094CB0A68@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67f06e7e-6451-461d-4d0b-08d96d301689 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 10:05:55.2261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FA6SQWguCRNfeJwYJq3l2Z0a/CtDWpuN/sDSpIXNMFYN+KDBNLEpAr0RNW3SUdzD4tMu2ellWtliUhMY3kgBJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 01, 2021 at 10:55:15AM +0200, Michael Walle wrote: > - fspi: flexspi@20c0000 { > - compatible =3D "nxp,lx2160a-fspi"; > - #address-cells =3D <1>; > - #size-cells =3D <0>; > - reg =3D <0x0 0x20c0000 0x0 0x10000>, > - <0x0 0x20000000 0x0 0x10000000>; > - reg-names =3D "fspi_base", "fspi_mmap"; > - clocks =3D <&clockgen 4 3>, <&clockgen 4 3>; > - clock-names =3D "fspi_en", "fspi"; > - interrupts =3D ; > - status =3D "disabled"; > - }; > - > - serial0: serial@21c0500 { > - device_type =3D "serial"; > - compatible =3D "fsl,ns16550", "ns16550a"; > - reg =3D <0x0 0x21c0500 0x0 0x100>; > - interrupts =3D ; > - status =3D "disabled"; > - }; > - > - serial1: serial@21c0600 { > - device_type =3D "serial"; > - compatible =3D "fsl,ns16550", "ns16550a"; > - reg =3D <0x0 0x21c0600 0x0 0x100>; > - interrupts =3D ; > - status =3D "disabled"; > - }; > - > - pcie1: pcie@3400000 { > - compatible =3D "fsl,ls-pcie", "fsl,ls1028-pcie", "snps,dw-pcie"; > - reg =3D <0x00 0x03400000 0x0 0x80000 > - 0x00 0x03480000 0x0 0x40000 /* lut registers */ > - 0x00 0x034c0000 0x0 0x40000 /* pf controls registers */ > - 0x80 0x00000000 0x0 0x20000>; /* configuration space */ > - reg-names =3D "dbi", "lut", "ctrl", "config"; > - #address-cells =3D <3>; > - #size-cells =3D <2>; > - device_type =3D "pci"; > - num-lanes =3D <4>; > - bus-range =3D <0x0 0xff>; > - ranges =3D <0x81000000 0x0 0x00000000 0x80 0x00020000 0x0 0x0001= 0000 /* downstream I/O */ > - 0x82000000 0x0 0x40000000 0x80 0x40000000 0x0 0x40000000>; /* n= on-prefetchable memory */ > - }; > + soc: soc { > + compatible =3D "simple-bus"; > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; > =20 > - pcie2: pcie@3500000 { > - compatible =3D "fsl,ls-pcie", "fsl,ls1028-pcie", "snps,dw-pcie"; > - reg =3D <0x00 0x03500000 0x0 0x80000 > - 0x00 0x03580000 0x0 0x40000 /* lut registers */ > - 0x00 0x035c0000 0x0 0x40000 /* pf controls registers */ > - 0x88 0x00000000 0x0 0x20000>; /* configuration space */ > - reg-names =3D "dbi", "lut", "ctrl", "config"; > - #address-cells =3D <3>; > - #size-cells =3D <2>; > - device_type =3D "pci"; > - num-lanes =3D <4>; > - bus-range =3D <0x0 0xff>; > - ranges =3D <0x81000000 0x0 0x00000000 0x88 0x00020000 0x0 0x0001= 0000 /* downstream I/O */ > - 0x82000000 0x0 0x40000000 0x88 0x40000000 0x0 0x40000000>; /* n= on-prefetchable memory */ > - }; > + clockgen: clocking@1300000 { > + compatible =3D "fsl,ls1028a-clockgen"; > + reg =3D <0x0 0x1300000 0x0 0xa0000>; > + #clock-cells =3D <2>; > + clocks =3D <&sysclk>; > + }; > =20 > - pcie@1f0000000 { > - compatible =3D "pci-host-ecam-generic"; > - /* ECAM bus 0, HW has more space reserved but not populated */ > - bus-range =3D <0x0 0x0>; > - reg =3D <0x01 0xf0000000 0x0 0x100000>; > - #address-cells =3D <3>; > - #size-cells =3D <2>; > - device_type =3D "pci"; > - ranges=3D <0x82000000 0x0 0x00000000 0x1 0xf8000000 0x0 0x160000>; > - enetc0: pci@0,0 { > - reg =3D <0x000000 0 0 0 0>; > + fspi: flexspi@20c0000 { > + compatible =3D "nxp,lx2160a-fspi"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0x0 0x20c0000 0x0 0x10000>, > + <0x0 0x20000000 0x0 0x10000000>; This is indented worse than where you took it from. > + reg-names =3D "fspi_base", "fspi_mmap"; > + clocks =3D <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names =3D "fspi_en", "fspi"; > + interrupts =3D ; > status =3D "disabled"; > }; > - enetc1: pci@0,1 { > - reg =3D <0x000100 0 0 0 0>; > + > + serial0: serial@21c0500 { > + device_type =3D "serial"; > + compatible =3D "fsl,ns16550", "ns16550a"; > + reg =3D <0x0 0x21c0500 0x0 0x100>; > + interrupts =3D ; > status =3D "disabled"; > }; > - enetc2: pci@0,2 { > - reg =3D <0x000200 0 0 0 0>; > - status =3D "disabled"; > - phy-mode =3D "internal"; > =20 > - fixed-link { > - speed =3D <2500>; > - full-duplex; > - }; > - }; > - mdio0: pci@0,3 { > - #address-cells=3D<0>; > - #size-cells=3D<1>; > - reg =3D <0x000300 0 0 0 0>; > + serial1: serial@21c0600 { > + device_type =3D "serial"; > + compatible =3D "fsl,ns16550", "ns16550a"; > + reg =3D <0x0 0x21c0600 0x0 0x100>; > + interrupts =3D ; > status =3D "disabled"; > - > - fixed-link { > - speed =3D <1000>; > - full-duplex; > - }; > }; > =20 > - mscc_felix: pci@0,5 { > - reg =3D <0x000500 0 0 0 0>; > - status =3D "disabled"; > + pcie1: pcie@3400000 { > + compatible =3D "fsl,ls-pcie", "fsl,ls1028-pcie", "snps,dw-pcie"; > + reg =3D <0x00 0x03400000 0x0 0x80000 > + 0x00 0x03480000 0x0 0x40000 /* lut registers */ > + 0x00 0x034c0000 0x0 0x40000 /* pf controls registers */ > + 0x80 0x00000000 0x0 0x20000>; /* configuration space */ You could take the opportunity to reindent this badly indented thing right now. > + reg-names =3D "dbi", "lut", "ctrl", "config"; > + #address-cells =3D <3>; > + #size-cells =3D <2>; > + device_type =3D "pci"; > + num-lanes =3D <4>; > + bus-range =3D <0x0 0xff>; > + ranges =3D <0x81000000 0x0 0x00000000 0x80 0x00020000 0x0 0x000100= 00 /* downstream I/O */ > + 0x82000000 0x0 0x40000000 0x80 0x40000000 0x0 0x40000000>; /* non= -prefetchable memory */ > + }; > =20 > - ports { > - #address-cells =3D <1>; > - #size-cells =3D <0>; > + pcie2: pcie@3500000 { > + compatible =3D "fsl,ls-pcie", "fsl,ls1028-pcie", "snps,dw-pcie"; > + reg =3D <0x00 0x03500000 0x0 0x80000 > + 0x00 0x03580000 0x0 0x40000 /* lut registers */ > + 0x00 0x035c0000 0x0 0x40000 /* pf controls registers */ > + 0x88 0x00000000 0x0 0x20000>; /* configuration space */ > + reg-names =3D "dbi", "lut", "ctrl", "config"; > + #address-cells =3D <3>; > + #size-cells =3D <2>; > + device_type =3D "pci"; > + num-lanes =3D <4>; > + bus-range =3D <0x0 0xff>; > + ranges =3D <0x81000000 0x0 0x00000000 0x88 0x00020000 0x0 0x000100= 00 /* downstream I/O */ > + 0x82000000 0x0 0x40000000 0x88 0x40000000 0x0 0x40000000>; /* non= -prefetchable memory */ > + }; > =20 > - mscc_felix_port0: port@0 { > - reg =3D <0>; > - status =3D "disabled"; > + pcie@1f0000000 { If you keep the nodes sorted by reg value, which is the norm anyway, I think there should be less churn, both in this patch as well as when you import the Linux device tree. The ENETC PCIe ECAM is at an address higher than a lot of other peripherals, it shouldn't come immediately after the external PCIe controllers. I won't comment on all the nodes that are not sorted by address, but you get the point.=