From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B20AC432BE for ; Wed, 1 Sep 2021 17:12:59 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 1D75360F4B for ; Wed, 1 Sep 2021 17:12:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D75360F4B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74941410E8; Wed, 1 Sep 2021 19:12:58 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id A37A640F35 for ; Wed, 1 Sep 2021 19:12:57 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id n18so74640pgm.12 for ; Wed, 01 Sep 2021 10:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1egIlfHixIf4wZobW1AKovlimHJB+Tre8fwpPtpbHZU=; b=U66tlZ0teFmLK72uPCUD+l6gzVU1fPiTjhuaHLuz7XnCTsy9dju6AoVE2Mf9FizLjj b5Bksj5ITghj7lmqoSopjg/ZS/oCMFkK5YakALu/o0C8uI5ItusyowyJZ28Br3PlwE8Q tdCRdNtois7EL8BsPixkbVclxOEJpBRxU76XCnnwj3yohjaaSi/Zovoj433yDNiD3ZIx euyLm/ruw+hyNsphxHYWr0pVW9t58o8GhqZrLhGwKzIB7gjLVaSbAkhYlz5cfrndy2bx 9s6fL3QIvqbTdwnUpkUCvZ2V50oemVut0V96HjdTvZAY9B1eUeQcbSf1Z9ZhrgA1xGl3 BsPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1egIlfHixIf4wZobW1AKovlimHJB+Tre8fwpPtpbHZU=; b=RAo0nX5jjmM9q0wsy1zi0CCVbeykeR/eNdn+Cu+r5eEWUnXAXJ1Wbpmmz8Ru+gd+Xe yDrSocxjU/Fha9wcDWCzp5+MICWuXe6GkvD5gpwjykk/mwO+kAraaOiATJHaT0yDTdLH 14XY67cXse+WUohCmehPpilguXgpTcyTrsEsH3t6xj0qVZyRKo0jblbS2S2QcsqrlGIQ U/0UDxqMqsbIA0JKHy4CmHrxgowb9V1BVILzgQOukc4IyJ49mCW6/xS9OW1X9zhA2vKG b6B74IdaA7/aizf/dr0GoD0ig9ijJ0akDZFCdTjd/cgSbcp/AxieyokZfGoGb5/oF15t V6Sg== X-Gm-Message-State: AOAM532YQ7tPF+RZVkAJa3DkD7dONeiFET0k78RO4FQZJ6eG9B1AV5oh kr2qdpN4rg/c7XxdQp2ysEhTij08ursn4A== X-Google-Smtp-Source: ABdhPJzp1Aa0lrNkcCzEUnc9+4giVOeoNzwAHyTnvtLpukGll4M7Jr2lwokcDWr72MI+ydBHT/0CYg== X-Received: by 2002:a63:df16:: with SMTP id u22mr154338pgg.150.1630516376750; Wed, 01 Sep 2021 10:12:56 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id k12sm143134pjg.6.2021.09.01.10.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 10:12:56 -0700 (PDT) Date: Wed, 1 Sep 2021 10:12:53 -0700 From: Stephen Hemminger To: Aman Singh Cc: dev@dpdk.org Message-ID: <20210901101253.6991a2f6@hermes.local> In-Reply-To: <20210901061821.5259-1-aman.deep.singh@intel.com> References: <20210901061821.5259-1-aman.deep.singh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 1 Sep 2021 11:48:21 +0530 Aman Singh wrote: > From the logs it is difficult to get the DPDK version > that was used. So added a debug log to print the same. > The log has been added in eal_init so it gets printed > at startup for any application. > > Signed-off-by: Aman Singh > --- > lib/eal/freebsd/eal.c | 2 +- > lib/eal/linux/eal.c | 2 +- > lib/eal/windows/eal.c | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > index 6cee5ae369..a14a205f4d 100644 > --- a/lib/eal/freebsd/eal.c > +++ b/lib/eal/freebsd/eal.c > @@ -958,7 +958,7 @@ rte_eal_init(int argc, char **argv) > } > > eal_mcfg_complete(); > - > + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); > return fctret; > } > > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index 3577eaeaa4..a50960cc78 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -1332,7 +1332,7 @@ rte_eal_init(int argc, char **argv) > } > > eal_mcfg_complete(); > - > + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); > return fctret; > } > > diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c > index 3d8c520412..5e6d5d8930 100644 > --- a/lib/eal/windows/eal.c > +++ b/lib/eal/windows/eal.c > @@ -419,6 +419,7 @@ rte_eal_init(int argc, char **argv) > */ > rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MAIN); > rte_eal_mp_wait_lcore(); > + rte_log(RTE_LOG_DEBUG, RTE_LOGTYPE_EAL, "DPDK version: %s\n", rte_version()); > return fctret; > } > NAK DPDK is already too chatty at startup. If your application needs it then do-it-yourself.