From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D12C432BE for ; Wed, 1 Sep 2021 11:27:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 076E760F6C for ; Wed, 1 Sep 2021 11:27:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 076E760F6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 88B008349C; Wed, 1 Sep 2021 13:27:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="dctJp4WV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1221A8349C; Wed, 1 Sep 2021 13:27:38 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on0615.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0a::615]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0DB7282D93 for ; Wed, 1 Sep 2021 13:27:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRAlVrk6E2fdoWSvqYaloqZBSp4kAhga0lvc9JP7r7pBjHaT/niVTmq9VIAMPi5XjJA8E2jZRUe+Nsf6Vwd88A7VHfiVXRfeIHVps813DFt8vZ2+/P1hskBEOJ+N1FqwFTUNq4Rv3y4/0zDJ48Hg7dq2ec06mgIcM7ZNmcfFwPEeNbWpsqZ5CO9UigS71nZwudGQVt41Sd+/7QDS/PkCI/rhzgeU0x5YhuxYHI8AzjePE9DJZGKBSUDAulcL+G9K/dlgmsOjiUdBF7YTgiKD6TysQ5MwFKJWZfsXgH9St/w7eu/2aWJOfnSQwihxA9xVlSEb+HbYVV8M2Kqe4yiU/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RzjdKA9fIJkd5T6OSL8SP3WJxVatA+wk4SeDXGVbe84=; b=NTf2RVXWhY/iI/4u71uCZqx/Jf3QF0YjeKEemLgr2jA/BqBGcrmFC3dBeP5Eya4kHSeL10cfQ74bQQMRZwyODogz1yomwoV6HEDOIWcvZT/NOaGWBYRxvR8N0POqekKpnOKcbCguoPSD+HByIddC843SWBhm2BqP2Od7BVyvR8OTZFCYpiZ+IkMxCICFaNlZQLeQ38SVVWPXh2r0HPhyG9LSp/IyTTSDkyHCJr27ZZuQOP01LHTiSSCLEbWhtV51ViGBtwRc17BXamzOKI6CUhPZ75JSEqqMdpXvkBD0F1fe6lJ2RAejSi9d8MfpxXzuQfOOKnTXscspCQwt/RUjRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RzjdKA9fIJkd5T6OSL8SP3WJxVatA+wk4SeDXGVbe84=; b=dctJp4WV34bel/Eku47om3337bzrwi5pJQWu179KhJYoaAvwSA3DgGW+FRPlVJgXs4pUje1y3hIFCXc6MUV6nUARJ4S37sq/umueoYRSP3UP4nAnwFJR79NtADdgZ8lGyGsyIp2GXQi9PB1KVhQINlh5g8G9xFSImqoJauQEg0w= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB3071.eurprd04.prod.outlook.com (2603:10a6:802:3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.21; Wed, 1 Sep 2021 11:27:32 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 11:27:32 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Thread-Topic: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Thread-Index: AQHXnw8zF5C1Uvh2g0iSq7vYJL/03quPCpWA Date: Wed, 1 Sep 2021 11:27:32 +0000 Message-ID: <20210901112731.n477uhjgj34r4jtg@skbuf> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-9-michael@walle.cc> In-Reply-To: <20210901085522.1712104-9-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 584e7388-36ab-4f80-c039-08d96d3b7d8b x-ms-traffictypediagnostic: VI1PR04MB3071: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1265; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 83WB/OZdC7jVvqtxG5hGAxllvDU0+kRKexWjtjyT06CQVKNC5tErOPqTbn2JEj4hfGVxa+k0vMtMXQJsFWDx2+REzvMKxWXvxvWD4VuU9YV+knd4uzgGv6ou+3nt5BLClWqO0MSWXLwm96oHPcMDHUx+GvcIahTN96zfs6foklWvHCVDsLpj+FQMg8XIANEBX77INDDWNZvCclxn8mec2HHS4XY/qgu76UgEeeXhZotkjM721aOFWTP1GmEmeOXe9AlJTI8nG33TR1FD2fqjKXpjshsyqU2bLzK1gdBqey3dFVgfi48XnmLxTD6vEIIwbic7JswdKgGV5CrIsxgNwQEf3Rj6oqViL/HuhQ7ug4GOADFSqHjiuW7GsivYdko5fAd5u03mK09HCKQiuFi4V28wfe/IwEIQwQ0Ro2mj4wTwxUUBKLWBGUb2Q5P2GYMoHKgH7AS/+kc3BH3Esi8eVkhEMBRAAWerbrYdPSr5PdhMgxqwHAxNKeTZtXBTKuZ9fvN5KCm62kczcyXOPCuOrQPsgOpZtipf2LiqiKo7h7oCgZu5bv1EjG72WlY8uvz9N2+xBtl++mnmb6fvcpoGHJka/3ifU2Unp9VNLoKBM7xi6JUuHzuXxlDri4Mp8J4MBq/UseD3MqBnXw5z0Im1pJ3XQBJqVirCnl2LrDEW/uhUFrR4HxlFYwMveWWayL7T/47cZOlJoXgVGPYnK79rHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(478600001)(76116006)(26005)(8676002)(5660300002)(91956017)(4744005)(44832011)(186003)(86362001)(6486002)(66476007)(122000001)(6512007)(9686003)(54906003)(4326008)(66946007)(66556008)(8936002)(64756008)(1076003)(66446008)(2906002)(6916009)(38100700002)(6506007)(316002)(33716001)(38070700005)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bAoOJXpRTJb5+Gjj1qusCLBW26Iu4rKTTMpM+IhLia2a13x+UQlsF1mVyyoz?= =?us-ascii?Q?2NZmLPhXpVsXnIXKbSwFKLlBmRe25eeL9fMwpDYcoc+EqhnVBzGV4n2c137x?= =?us-ascii?Q?1D3ZY6lYInUQB9eTJ4ePzIvy9J1UQ9EcPQWPlzoGKQqlCmLIk4LCc5vNx6FG?= =?us-ascii?Q?f/rUXr2WWaMk+pfL3awQopxO5/tYZZYeafm2q7HxxOZyuIAZ7ZVK9Hx1D/7e?= =?us-ascii?Q?j3Q1nS/NDrGrGFnmQvMNaWOycNWVqiZJP4x1rw6qf533wREJVF9dFPDhHWlF?= =?us-ascii?Q?4EWClZzJ3FIls6eT8/kPYST/8IeQKrmWgNFZbwhEIhyAwclNxs1MmpBwVcmS?= =?us-ascii?Q?XT2gCyjZfKe9bY3LIFJ8nlIqGmxTHDOyDWYuNJ4PXWOGxneypGr6jy1kquqd?= =?us-ascii?Q?ciTUpJHLQgwhdovJJBj89zU0e/ddRQfz3t+tqpviYWuaiO3uqddIR1SZRTxA?= =?us-ascii?Q?VOAJm2Kih1fAFmI6eT+bfZDiWPhKwCDfvu9qQlCiTA2sDmfeYLdm7IC+Jlac?= =?us-ascii?Q?1dop0jxeJcJBNLRJmN9UgdzKTDM4NNnpOeaDTgle+TVz3v70PFVqJ9/WsFlT?= =?us-ascii?Q?2wiHUgvNewgCXI3MPsByGynaDUbDXvjUJiazDXMk/l//Xq3xEyFTbGwCIixC?= =?us-ascii?Q?+vysWdmnwO2HGJvCIyhn/DVE372cu+KUU8gWRUEMQSk7Gpk5aMtNFX1bneAe?= =?us-ascii?Q?1wDHq6tg2C2N4/ijjNPA8dzegy2qv3/5M8HGA+NW9+j+d3YwGtZfsMLPhk59?= =?us-ascii?Q?6YaO6V3B9MXUf3bVeRu7hLBj80WSS44czIQSJywG0RxdE62VrHQDpDj/xLft?= =?us-ascii?Q?S+l7YwT+q/txlYxgP/tDTEwf2alUq6nDz6fQiJll8m1KLkR4P3jYCgseRhbD?= =?us-ascii?Q?Cqwleyu0S2wIkzErigxVOBfNVEF+dXybtJ4tSXQSJsPCTpDOHpvq9nRxpnHe?= =?us-ascii?Q?3gl/YIKj8NABoEOsG0kgztZhf8d6qRxG/zlBxx63GHAbqjTuzKHhRaXCIKFv?= =?us-ascii?Q?iDibuiea4K6OSSGD0eGQWEEsXWuCDsgwBxhbgs0WKlkuqmaD+4aKVJTlz9CI?= =?us-ascii?Q?3bDYte0Z4CWNZmMizLI30yI181bjDnGr3wmI1jnjZBWLKYaDwt8dBpivY0L3?= =?us-ascii?Q?UUcrw1ohQtlB0SaPRceAsbkXVQwYBI8IJYASNXIf4tarl+sN9GXdRRR54gcn?= =?us-ascii?Q?hkZa3CtPomLdeTYf9PfOEaKq8RTLaQv3NfEzswupJrJsgp94PDOoaxPzmrp4?= =?us-ascii?Q?cwTLqElfk3yram4Y2JzwzYHIkV1LHvt4bdt67RFbgE3CvScPNqor0j5qPtZz?= =?us-ascii?Q?M8bMNWMYTYmMu+uVWVBzXYjlkhEziY4o40gqARSjYZ1VSw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <15F91D2B6D6D8347964A0ABFC981D3D0@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 584e7388-36ab-4f80-c039-08d96d3b7d8b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 11:27:32.5265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1i9FSuD/tsqnvitqjxfp6ACFWfmYXuxgc6s3Z7cI8fGRWA+n4TFDr9eU6aLfVUcZodz03HjuXgXhF84uuO28SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3071 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 01, 2021 at 10:55:21AM +0200, Michael Walle wrote: > sata: sata@3200000 { > compatible =3D "fsl,ls1028a-ahci"; > - reg =3D <0x0 0x3200000 0x0 0x10000 /* ccsr sata base */ > - 0x7 0x100520 0x0 0x4>; /* ecc sata addr*/ > - reg-names =3D "sata-base", "ecc-addr"; > + reg =3D <0x0 0x3200000 0x0 0x10000>, > + <0x7 0x100520 0x0 0x4>; > + reg-names =3D "ahci", "sata-ecc"; Again, same problem. The drivers/ata/sata_ceva.c driver calls dev_read_resource_byname(dev, "ecc-addr") (but not for "sata-base", apparently). If you don't want to convert all occurrences of "ecc-addr" to "sata-ecc", then at least add a fallback call to dev_read_resource_byname.=