From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A30DC432BE for ; Wed, 1 Sep 2021 11:37:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF28761008 for ; Wed, 1 Sep 2021 11:37:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF28761008 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 88F3D82D93; Wed, 1 Sep 2021 13:37:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HDJ5hBpC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 357678349C; Wed, 1 Sep 2021 13:37:08 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A326C8200B for ; Wed, 1 Sep 2021 13:37:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id z2so1197190qvl.10 for ; Wed, 01 Sep 2021 04:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YKridOZRiMm/sh58g7Gv+VIt8tc7EkCGsTeUPdJgTwA=; b=HDJ5hBpCG6e52BC/grJe3zPtGLX8aKT+ecL4qq7kpncbWy3Rs7HmAdCYeNIPXAlRBu whbroXdiTo4BdqVpsaXxn9p5O1GurvJrKWsa8/dchyyOpk5dB4q9NZ4IMjHarPIIKfPm wKK7owhV2U2WHF7JXlgrkHYnBagD43Boj4ROw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YKridOZRiMm/sh58g7Gv+VIt8tc7EkCGsTeUPdJgTwA=; b=mcL/yiZNMoicV/sVKZMvE8335KXEWdjfAjHk2ADQ80JqW8knh0C26aRhEtSSPG9eYS 0mQ3A9+OHrTDb7ANI71V1ZAI7L+nQ4G3TnLstV7swoERbdB0ODcqykann7abO5Qrp/Z5 IUR1IKxsSfpsafphvhtk1lq0KHce2HCJnmWIJL3cGkqbEmp8f+Woay9sE/O+Z+AIkueH r0VS1/aM9uy67fpcldm5ePPD1ZSzNtcDpjowSXhO4EkZ1v0LSdDfWU545lN4IEbdI0OQ 2YOhYqakzEh3WHRhESRbzQ9LMMjqxTu1VS8QdILqzk3GwA4modY/8wHXPd6iwCNReXeu CtHg== X-Gm-Message-State: AOAM533KLw4X2sDc+Xka/BpAlhtr/SvfsYkZh/43xjbDerqGGC7z8r6l VGMg4je9IiJ5p8jIU0/FeBOuag== X-Google-Smtp-Source: ABdhPJwjS0UcGWDVTPqMS05Ze03SK5v2R2TNkkxknTTmBsRnKgT/ggE9fQ8xq88gwtP0UUffujsUxA== X-Received: by 2002:a0c:e70f:: with SMTP id d15mr33534711qvn.47.1630496222297; Wed, 01 Sep 2021 04:37:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-c0de-1187-e67f-31d5.res6.spectrum.com. [2603:6081:7b01:cbda:c0de:1187:e67f:31d5]) by smtp.gmail.com with ESMTPSA id s18sm12737654qtn.46.2021.09.01.04.37.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 04:37:01 -0700 (PDT) Date: Wed, 1 Sep 2021 07:36:59 -0400 From: Tom Rini To: Matthias Brugger Cc: Qu Wenruo , "Matwey V. Kornilov" , marek.behun@nic.cz, u-boot@lists.denx.de Subject: Re: [PATCH] btrfs: Use default subvolume as filesystem root Message-ID: <20210901113659.GX858@bill-the-cat> References: <20210801205216.22639-1-matwey.kornilov@gmail.com> <474eac73-5765-5bfe-acf0-03510f1ad04f@suse.com> <94e2a6c0-3aa6-9b4c-0459-07a7db14ee95@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QnQ2CFbrlI7sTMFq" Content-Disposition: inline In-Reply-To: <94e2a6c0-3aa6-9b4c-0459-07a7db14ee95@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --QnQ2CFbrlI7sTMFq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 01:28:30PM +0200, Matthias Brugger wrote: > Hi Tom, >=20 > On 02/08/2021 01:06, Qu Wenruo wrote: > >=20 > >=20 > > On 2021/8/2 =E4=B8=8A=E5=8D=884:52, Matwey V. Kornilov wrote: > >> BTRFS volume consists of a number of subvolumes which can be mounted s= eparately > >> from each other. The top-level subvolume always exists even if no subv= olumes > >> were created manually. A subvolume can be denoted as the default subvo= lume i.e. > >> the subvolume which is mounted by default. > >> > >> The default "default subvolume" is the top-level one, but this is far = =66rom the > >> common practices used in the wild. For instance, openSUSE provides an = OS > >> snapshot/rollback feature based on BTRFS. To achieve this, the actual = OS root > >> filesystem is located into a separate subvolume which is "default" but= not > >> "top-level". That means that the /boot/dtb/ directory is also located = inside > >> this default subvolume instead of top-level one. > >> > >> However, the existing btrfs u-boot driver always uses the top-level su= bvolume > >> as the filesystem root. This behaviour 1) is inconsistent with > >> > >> =C2=A0=C2=A0=C2=A0=C2=A0 mount /dev/sda1 /target > >> > >> command, which mount the default subvolume 2) leads to the issues when > >> /boot/dtb cannot be found properly (see the reference). > >=20 > > I also noticed the problem in the past, but forgot to fix it.... > >=20 > >> > >> This patch uses the default subvolume as the filesystem root to overco= me > >> mentioned issues. > >> > >> Reference: https://bugzilla.suse.com/show_bug.cgi?id=3D1185656 > >> Signed-off-by: Matwey V. Kornilov > >=20 > > Reviewed-by: Qu Wenruo > >=20 >=20 > I can see that this patch is marked in your patchwork queue as "Need Revi= ew / > ACK". Qu is one of our core btrfs developer who reviewed the patch. Apart= from > that we have it running on openSUSE on top of v2021.07 for some time with= out any > issues. Ah, yup. Qu is one of the people I do look for to have reviewed a btrfs patch before I apply it (and I throw things under Need Review / ACK as a note-to-self to make sure a patch does have one, when I can expect one, before applying, FWIW). > Would it be possible to merge this for v2021.10 or do you see any blocker= here? I think I had mentally filed it was feature not bugfix and was going to hold off, but since you're asking, yes, I can grab it for this release. Thanks! --=20 Tom --QnQ2CFbrlI7sTMFq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEvZdsACgkQFHw5/5Y0 tyyJ1AwAtsRv9mlwNpGxai1WYsR2zYbu1XL3Ms2ROQRfRaFaajK+OYFZyD4JqpS8 DwR5rrOx6iYrN/AiWiUlpqWRkYlx2Dc5ABFLAjPGCP4kVxOite/Q4q7j1hXLnACy JSWtS+buRakoS9PN6pn0UtwEwEgNtteLsA+9OTTfmqH7/2KFjBSI766lVlZ+QIM/ jabchVjeHcPZj35LJGnqQfFbB1fu7ZsyZFbW8gfYSgSmS0IBUoYF3KbQ939DMfL+ VOFKv0vtpq6kad7ClR06yFqsI4p9nSNBN7tUh2iEOmj5RogctwGLRC63rn39Yyvr IhDBFAMzW+dK6RKFKggjpRq2hUoo/XzJy9b/q4ld5W16jcWRTD3UXXPyVxJadp9M ARRaCfxKmKXAWXD3FowcPbjMAFvuZdaIXp3xMmrhjdwbP4WiDO/V6pHTaxx6JiPP l/DXXWMEiRrYloZuyE0IMDwiH/ouZ0N0ukB/+U5iMBhGwYoRmePTLHU5WlbZZUGG h0kCkAw9 =3jUX -----END PGP SIGNATURE----- --QnQ2CFbrlI7sTMFq--