From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11AE8C432BE for ; Wed, 1 Sep 2021 12:22:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4201F60BD3 for ; Wed, 1 Sep 2021 12:22:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4201F60BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 875118328E; Wed, 1 Sep 2021 14:21:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="o+iY9s0q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ED7348349D; Wed, 1 Sep 2021 14:21:55 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0625.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::625]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DC65682F4C for ; Wed, 1 Sep 2021 14:21:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G1c4lO9FL4hdfqXAQjMnT8m4oCxuK270hudqQl0L/3E+U+3jBNc7FM/7qCPHrxckrwDdfjm0YcaKUL1L3alDfHi8cUvd4TIuiQu3UXeHKS1Om1HZ8On0tch2mpMQb1f/lAePDkxuSKWQ3axJt2MW8nPEyWgKuxv4sTVL6TArV9MO6XS6N+3O7MqFV1Fzv/IeatbnBoYp6eWqX1o9ESZV0AioK4jmrp4v/sRObns+9Xq5oC4z9s0uHktuaoA37jmie3/yO/HI2mftogg3xBjajF2FeAvP8KkzBnigadnJbcl0dRWaahVsaI2B7d0ekbBZ5FpdYyf3im7wGUrX4lIz+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jU4jpk7LTOFeOtkKHPgGy1Bc+PmXukLjBO2dydo+ZGE=; b=IvrriY6YRHGNHITGE6gk9UuPAF/vfZfu9cpBJGnsd6/DBqIuRd1v+p4/9C5iwkIbrROtjFgts7aVo3h8lzMI2UakIru0CL1TWwuGhwCwnpwWXQZZhGhaRgqp3+wjZr+s6sa/jFfR8OohS6mOxGkcltm3NScoqJ4PkVw9pV9sUU/QnJxhKDu59+XimfBGydWDnQ6g9qwJC17OypDbsam4fs+iIFRBAZgd1FQP10p7ttyMmgW8bSbEyhloSd/ifj87AsqZAIkWOFhCCBQr6BIyMhmiN3cyAVQG9GtStedxCuCTuFx73R0mCza/VsEUxjMRjPLC6mXfMg9RHszEuUPenA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jU4jpk7LTOFeOtkKHPgGy1Bc+PmXukLjBO2dydo+ZGE=; b=o+iY9s0qo5Fqvn/FB9r1TOlDY4nyuB4+/2O7xqQVgp4cGCA/8SelesfBiEs8LkBme1APijyYNxwHd5Xfmt5o+xoxVFKJ+AzNQptrUw3WzOGGYQqWB+pFgI74g+6ca6xOlu5EmxFFGXCIB+L1LKGYPSB9sAwGYPkbCNvbRqkGzfo= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB6943.eurprd04.prod.outlook.com (2603:10a6:803:13a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Wed, 1 Sep 2021 12:21:50 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 12:21:50 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Thread-Topic: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Thread-Index: AQHXnw8zF5C1Uvh2g0iSq7vYJL/03quPCaoAgAAHuoCAAAEfAIAAArQAgAAEioA= Date: Wed, 1 Sep 2021 12:21:50 +0000 Message-ID: <20210901122149.bpufsq7gzo3n73mk@skbuf> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-9-michael@walle.cc> <20210901112414.u3dbcbtlbyanwhjn@skbuf> <713ec89615bb7fbe461b909390cc09c7@walle.cc> <20210901115554.2zlfcfc4m6ymxwfx@skbuf> <248b3bb606fa9a073a98adc0748656ad@walle.cc> In-Reply-To: <248b3bb606fa9a073a98adc0748656ad@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1c0e5f14-8071-43c3-ce64-08d96d43137c x-ms-traffictypediagnostic: VI1PR04MB6943: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y4JhsvlnFM5m0OWkL8P/ArhxTMiSBGDQM/eNqsk+X+reyksIxhpBcOwkhNOKNafSywYpf1Mcw38/5L2vhLuQ2mDhlS+75UcJ2nMYRBh1i4SQGkttU4tVhJPm6Hjj57MjD5G2uLSVpwTEll/nDKJ0CSJ3q/TGBVvB8n15MmxAoRmDdvQCoLkKQ8T7rAG3lqAbap2xcZdSvzIdQQ7c8pv7uVSuA/eCVFXMLnOqH5W57dpAVQvREHe0NAOdAFmImmMCg1oLYUtTsdVav94zhj19449jmcFtpfoBekJWNLPZ6IKtWE+hiC2BlKor3Bj7GlSLX0p+8I+HTjo6uuO185pQ0uH1Ad/W199Kt94kuiqagein3aAY5+LeZ3nnK158Wy9B5M3BCNJc5mcr7h48O/rsYgEr+kECLaX3MKggkqxOurpyGCMAo6a46TdGVZpLig+DzqLdkeKCG5owj3UHTl4hVyKAWheSycGG/ikf4HZ/vSkpLu7IwKpy9nK56D8MGQfmCezkpEKA2GHgNONDPNbZ2nzJoHHXy2GAA0AJUqYP+yzMeTv3jPSSJslyp3H4TimYLPY+uEQVOEBGAVc00/QKWDEA63WN+x44e5yLJaD+2n0dVvvtfO/TifAH3s9TwbxqXNdKA9gQ4oKMZKZk0XjJhdabx8sjrL2K1lsHmLokrLZVVILyI0zX974lF4ZJZMhOjJBTpAE27HW8Pbj92P+TXQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(8676002)(54906003)(83380400001)(8936002)(71200400001)(4326008)(478600001)(38100700002)(316002)(38070700005)(122000001)(1076003)(33716001)(6916009)(6506007)(66476007)(2906002)(26005)(44832011)(66556008)(6512007)(186003)(6486002)(66946007)(66446008)(64756008)(9686003)(76116006)(91956017)(86362001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0UBcVvgYi49SwYOC+JBhy8jVxo0JAV1Xan8FXQjQ5GUooF+DvxxDopEaoz19?= =?us-ascii?Q?nVgKQuVzI54frqQyrsJVoQhl/0L8WCvLXYI0xKVPZE3ZfD7zKzqtOps9bEU2?= =?us-ascii?Q?8ouRtTawUeqw8klEpMs1EEQxxV+gXYlBvWfl/nZeJ0FO0LE7slYVnefmV0pM?= =?us-ascii?Q?zU9wkkf7cBMm4+mBK2S8PTMJRdWYKEWnsVZXCaBdG/eRYRuhOyFUGN82VA8s?= =?us-ascii?Q?qx6nTUImWm1pm/axf9HIdbWa9TiAwRaVI2xIKw/98qQ9IvnujM0Itkb8wnOg?= =?us-ascii?Q?RGPcn8N0916vOwLNssDtemrpdqppaKgW7EfXjGtsGJhoAeQDVqd1E472AQYF?= =?us-ascii?Q?Ui0RcAWddG4tyBOkQL29keRPAiMMLNascJe3bgaE5wkvt4KLGyiKiUi0gfpT?= =?us-ascii?Q?UePdVOXUOfEIDztTX1Y0jtEMBHYrNyG5OY94LgaOBebKVE9lwXbRpxAh/MpA?= =?us-ascii?Q?+nGD3y//aVvnPYo0BujHynfty6txTISUSctcSWi9PUaZESLuCRZWhPmKxstx?= =?us-ascii?Q?MAT5vN7e6YawtFG+mHUE8x22vVNL2WjiYAiUEFh1JtW3ZXN/+vlHXKmdRZFm?= =?us-ascii?Q?y4UM5G9O44mKrrQHDL3DwLU37xIFKwO0xN4L9Sv8NMo+W21kLCii++4wTwsH?= =?us-ascii?Q?wiZ2Tjrwb1fdGK85we3a/3KHX3LV9QpK/eg+C3vp1ASLK/6z6WN/9n3jHDig?= =?us-ascii?Q?lNzr3vrrZuFd9ZJr5RSQcD20jk2QItrZULmxy0cUuxpcJQoEkdURdqC0tDuu?= =?us-ascii?Q?lAHGJzaxVBxozXsHEPzURdo4xVROhYpnb1WML2gK2GnbBjgKbzobAuvSqLhq?= =?us-ascii?Q?1q1dVaIj3a5T4awFYne+0ON4jxzAXxex/X+ZkUinvjkE4aH+Hn/ZfaqpgV1P?= =?us-ascii?Q?IeQOZzJbmIfLEoxBy+T5WxmZuxUiVLX0p/iXgUedo7kvPD8PIAYCVV4Mm6vf?= =?us-ascii?Q?+cDN2AWXkazbQoHogYVkTlV8i6Fq4JOEYyeXp6IR4OlInTmBrso81M/RM3Q/?= =?us-ascii?Q?Y5+WBwf8u9zo93JWkbd68B/yudV12KFTgJw54msT8cRNwN+fSr0aRCj2qFAK?= =?us-ascii?Q?pztABg1o0Ec/BmqEroPqgmNB/X2+cCqFNZuIq9Sow218w/lGf1Zg3RQ5LcW+?= =?us-ascii?Q?dWGopBUTdLcqg+yLeqw3tRLo3ci7A6dMPob7GWEmO2PMeBtSjeG3u5YTqk/b?= =?us-ascii?Q?kBnV0i2jGgOT2Zy66B7qI4FH8EWuNexiowHafwmtDaRiOd7f8orYAKaocXyp?= =?us-ascii?Q?s21TNLWTakU4xS3gkY3qLcACZlHi1pt4GOkeOeIuMYVnGvyMqCYucoyibo/F?= =?us-ascii?Q?oRBJXLoibsBAGqPuG2wHcH3+czvF9wsIHJpbdCbtiXHBfg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <3F8CC4904F396941B4050CAFC232F0C4@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0e5f14-8071-43c3-ce64-08d96d43137c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 12:21:50.6398 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vVRrRGSSOfWHtLoH1Z+R/3W6pEh9SBwtXZP5RdCXEo0O0EsD1yePJSLAqdRDrqYZgdqUBo01N+XDVu92JMpTUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6943 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 01, 2021 at 02:05:34PM +0200, Michael Walle wrote: > Am 2021-09-01 13:55, schrieb Vladimir Oltean: > > On Wed, Sep 01, 2021 at 01:51:53PM +0200, Michael Walle wrote: > > > Yes but that is on purpose. In the current u-boot device tree, it was > > > disabled, but the boards reenabled them again. So it didn't matter. > > >=20 > > > I want to have a specific sync point (that is the v5.14 tag) for the > > > .dtsi. At least where possible; for phy-mode and so on I needed to to > > > take additional patches which weren't picked up in linux yet, but > > > these just affect the sl28 board device trees. > >=20 > > Binary compatibility is one thing and I can understand it. > > Textual compatibility, down to label names, and where the device is > > being disabled from? Hmmmm, I'm having a hard time saying yes to that. >=20 > It's a step back, yes. But only until v5.16 (I don't think the changes > will make it during the merge window). I guess you are concerned because > of your vendor fork? Mh, well actually I don't understand your concert, > because your tree isn't compatible anyway if we change the labels. No, I don't care about "our vendor fork", it's been years since I've stopped using that. > We'd trade the clear information where the device tree is from for > something that - in my opinion - is not worth it. I mean the device > tree (source) is used just here in u-boot for these three boards and > all have the usb nodes enabled. My concern was actually much simpler: your v1 conversion of the label names was buggy (see the LS1028A-QDS build breakage). You deleted a bunch of comments which U-Boot had but Linux did not (luckily they did not provide a lot of useful information anyway). You introduced some comments which do not make sense for the U-Boot tree, because they were in Linux: the ICIDs in the iommu-map being fixed up by the bootloader (you can instead say that "we will fix these up for the operating system"). Again, not big issues, but if it would boil down to my common sense, I'd focus more on the binary compatibility (after all, there will still be U-Boot specifics, which will constitute textual differences, but Linux will gladly ignore them, because this is what binary compatibility is about), and if it is preferable to have status =3D 'disabled' in the dtsi, and a patch was already sent to Linux but not yet accepted, I would have kept U-Boot the way it was, and follow a model of "eventual consistency". If you still care more about textual consistency, I went through the patche= s once already, so it's not like changing things now will make things easier, or matter.=