From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCF2C432BE for ; Wed, 1 Sep 2021 12:57:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A95D60FC0 for ; Wed, 1 Sep 2021 12:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5A95D60FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F9C0834BE; Wed, 1 Sep 2021 14:57:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="ZIm9DaUe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4257A834CD; Wed, 1 Sep 2021 14:57:45 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::61d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0E5E6832A1 for ; Wed, 1 Sep 2021 14:57:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LH+K6uyaBeGz54Rc+c2rzBSwB79jkDcGymrdM40iiaSPXJm1edfe4xNGr/URWBm8FT4upwya/vJYeaYdRnVZtAbxwS/sZpC17wLIrwbCyyQziL1Y8VIb8wam73FjXz1iU5z3XYBwN86Ei0ikrtPIX6kyjKXiJxOLxORxpn7mbhgNZtbGtlynVr8VCTlj9T/NPL0a1LvanIpyfv1KHEbls1wRkg4rqHSlgX+Bh3Sz/G0Nse82io78NV/DPqnqjBWzGvTt32DtUHzE4KzmC+G7feJ2QrD2uljuDGnkTTYKklhi7IQBkq7AfJPgfz9wh93KIft+d9F7t+m2B3C8tw4gcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=syUVCwEcj4YnBzMtiPgnTWyXgSJqrnF/BH7RvfNvgQg=; b=XpCo4m+mZ+ycHd2LBTY79jz/B3o/cVighlnzDnZnymt5jGSeRtvZV+mfFPwSOpDQCrHyqI7IwSME/WdGnMpKcNg8IeXrNvL+Mb8Nw6h2QldjT8d6IgFdz5FBYI/KDxd1Q9fe0UsMaBuJY/ux/uUZs//yZrZxfZqGwmZeYgWFWvZPQU+Pqe3pcn9abSqwhMk2b4lBQ1obsjXAPt6rCFJMXFSDk/l+t0jPfVbiMw8QqypQv9t5kUVTUm8o3UfZAOVw85mmBgo3E8hNAShLS7g2teRA5n0akZTgyk6B67gbcgqrfe3wsyaqKeXMqyWFvwJA8VOKfYMAeoBtuLO40AF09w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=syUVCwEcj4YnBzMtiPgnTWyXgSJqrnF/BH7RvfNvgQg=; b=ZIm9DaUeZzNCuiP6VuRKP0d/4bwHmXTLwIC7+13MM3RNuHYYr27pdnRGnpV22iWFsLH+3LXFy4PILiiooemsGzAnW/4TLgfRt9/uQLCZPrNaq8FMrAD5+ZxFKA+5f5Emhdx7bOO5ApgiCj9fXREuHLHh0nwjQEDF/A7U5Ee4XH8= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0401MB2301.eurprd04.prod.outlook.com (2603:10a6:800:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Wed, 1 Sep 2021 12:57:39 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 12:57:39 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Thread-Topic: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Thread-Index: AQHXnw8zF5C1Uvh2g0iSq7vYJL/03quPCaoAgAAHuoCAAAEfAIAAArQAgAAEioCAAASYgIAABWoA Date: Wed, 1 Sep 2021 12:57:39 +0000 Message-ID: <20210901125738.3q57qgfptjznaouh@skbuf> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-9-michael@walle.cc> <20210901112414.u3dbcbtlbyanwhjn@skbuf> <713ec89615bb7fbe461b909390cc09c7@walle.cc> <20210901115554.2zlfcfc4m6ymxwfx@skbuf> <248b3bb606fa9a073a98adc0748656ad@walle.cc> <20210901122149.bpufsq7gzo3n73mk@skbuf> <164efeb6985726c9d9f18a4e231a942e@walle.cc> In-Reply-To: <164efeb6985726c9d9f18a4e231a942e@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d5eb1d4-d439-43a7-df72-08d96d481468 x-ms-traffictypediagnostic: VI1PR0401MB2301: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oH5ihwttEewK+dGSjFa2nFanT9mPe4n66S426pDci30BZvKt542CJVv6Niy4pJdIhgSTy3w3vpUPpBBV4cSX93JQQaVp0Hdi7s0d9n7W+ntkr6ZvlqBjdN7EWTLI+sKTNJ9smnUbGWbyH/+BzKuQtwPOjpRs8ma70ERvGyedPwjdpXdhOqsB4rkpn+kWl9jOsjhWu3W024EctVJgF3LwTT7EXBLsLE6SYTW5CMIfn9NnhLZ6Vtfcf+pDT2dU6fKW1IKAobwDXMOWbx06+SD6S2H2i55B9Vc0REMsvPQx1SISW+gjR6Q1LRPLd+l56iGDjtuDZuGEs68btIVs412NJf4PJ2zmzbMnYENZ7pexCUAVmprGljMoQ1LThuPirJhpSqM9rYsNgAnW2CdA67gRn267zB+GpFl5b/xtwia4oBiFV4g2ys+GnQbAgYBPfox7LFU/VJXnolj0lCqj0HlstD7FRDeVIK8knKxISjvZJZQ7hx4IgbMb2bqp8YjOoNcKxnXH+mjsxnVfulSTZku0OJevcZgYHjAznFglxTxKn/auSIUGnpcD+XYAMrItfRQAYpBAZeMWrYwmvEQmIkiNfOPHrVADTVx+t2GFSDKJtDXQoNJsryybPUUzQDiuUOrGieeNaWeTIA24oJCzXHE+F6CSUNA1A73hVsS9u0ATtIhs8eWKn9Pgi4layOj5tthFwQw/T8nXeuSox2HB2vrNQA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(366004)(38070700005)(2906002)(8676002)(5660300002)(508600001)(122000001)(1076003)(6506007)(4326008)(66556008)(66446008)(8936002)(64756008)(71200400001)(26005)(91956017)(186003)(76116006)(66946007)(9686003)(6512007)(38100700002)(6486002)(54906003)(83380400001)(33716001)(66476007)(316002)(44832011)(6916009)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WxQlz9/++k1ni3UALZMX8piWXZM+1bORtNZMXN8NdJ11ge7hVNreKCjfnbYb?= =?us-ascii?Q?UYgJPJ5MJooipauveDNDkCuzJeNpUGQIUtM7k7ThSTpGVqTIZGNYyDrBCLBO?= =?us-ascii?Q?hT+8s1JIl1kHB+oKUpK3EhvhmBAsoYCXhupioXr7J6VAX2FWN6c0xxZ1UaOV?= =?us-ascii?Q?8Ls/vhhzYt0GUom/lfT0M8QVBzsnjVLX7t5R3HCQbsg1A+iOUe/eq/vPyFU0?= =?us-ascii?Q?Pq7Z/f+PqRs474UFA6P8tNXTZfVf7HPxbchjwa59/hQAPNNyRV9uHFik0G1P?= =?us-ascii?Q?LWT6SSkTh509FX0G1V8PwZzgnABe7ZVthMI0OV3FLOSB++6KVyMrdAD3mIwS?= =?us-ascii?Q?zGkUzf+Bgm6opdNIsjPI+O/u1/hGv9CMc5BvYgTGyvkWtItnsTQHwXAevsc+?= =?us-ascii?Q?EhUU9b9lETPS1OvSMfrpZwuYTstyGVtaD8I9uQzSLHhH9EwcKbH5ZQtP8NhB?= =?us-ascii?Q?eBidqqI6yeb0nrvkAccYPVEgblozSAygTy4i9FsiBwR++DGfSaXy4Yyi0ZCZ?= =?us-ascii?Q?465Np66+/W3RUxJ+bzoGOgelnNn1Apf1NiA6ewDx2aLcAjl3ywRuw5wkgZzb?= =?us-ascii?Q?EIFA5q9AMPBtWyWVYerbP5xrakObLAR7jjnxf7WU1+ye0sH6gBSekKKAU2FG?= =?us-ascii?Q?PN1dxCgcXRIDsVTCWDnHJTvxeU5YGW/Xqy4T075VP2CEOLwOq0FAAGpPuUik?= =?us-ascii?Q?F7ycZJ5DltHWS9HBgLQiVvSVtYuzFrwxYfEMsAM1wrDMACjavf5vteYDaql3?= =?us-ascii?Q?aJr55axDuLwyDQFBwDcfnQ0ZGYtSnPBL2D9yPiWPFIgwS4V00vkloTLtBl2E?= =?us-ascii?Q?TBUua/nZL+vxgvo3nAOv93H/p7YAZfF38vuADbeEvsDXQdfypFLiRtzs6oIE?= =?us-ascii?Q?fCNpFDS54YhhvTvABPv1/3tww235BoydGboEvQ20vZBn//iFRY4elolkYpv6?= =?us-ascii?Q?eLmx8itHuCMxL+KoYNpr/koTva7QWq3yIoORXlW3wqw2o7yEBXQpgkVu6iDy?= =?us-ascii?Q?/MuGCs2+AepWVZo5HliOBPbDiI6crGK2z32UC5aCfAdC46DUbDkYRCHayLdT?= =?us-ascii?Q?P49bvrIBGSzVcjpgHcydbN04x/DmbolTEcIIPtkUewrTzfdGMysUIIAd/hs6?= =?us-ascii?Q?+TOGYMgTKZKu/GOxvzNVAC3RIc92KOayojFjsSc/YCzfQhEj3vYwV7U33XBZ?= =?us-ascii?Q?3XPvB+nDNWogMIl5OU0TLNj+JkfjmCVYSDAOpPz2fxRV+jTrklz7OaBbwgAo?= =?us-ascii?Q?8XR0yS1ZR55nDlhgG0f0zWDrEHEmHN+5/f4PytM2iBhETMCUP21InYuHKtSH?= =?us-ascii?Q?HNQE4gpqEdhN/OEXXNaUwIW1xcgwU2O5bsPC+ZKgcxMbmA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5eb1d4-d439-43a7-df72-08d96d481468 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 12:57:39.6146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ou2VWWwf5fLQyx+5XJ3sug/p8ytakvSshRCwebbCokap7WidARldvdjT6eFrNLBZQuDqSeHXw0Cx/c3mcI4YeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2301 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 01, 2021 at 02:38:15PM +0200, Michael Walle wrote: > Am 2021-09-01 14:21, schrieb Vladimir Oltean: > > On Wed, Sep 01, 2021 at 02:05:34PM +0200, Michael Walle wrote: > > > Am 2021-09-01 13:55, schrieb Vladimir Oltean: > > > > On Wed, Sep 01, 2021 at 01:51:53PM +0200, Michael Walle wrote: > > > > > Yes but that is on purpose. In the current u-boot device tree, it= was > > > > > disabled, but the boards reenabled them again. So it didn't matte= r. > > > > > > > > > > I want to have a specific sync point (that is the v5.14 tag) for = the > > > > > .dtsi. At least where possible; for phy-mode and so on I needed t= o to > > > > > take additional patches which weren't picked up in linux yet, but > > > > > these just affect the sl28 board device trees. > > > > > > > > Binary compatibility is one thing and I can understand it. > > > > Textual compatibility, down to label names, and where the device is > > > > being disabled from? Hmmmm, I'm having a hard time saying yes to th= at. > > >=20 > > > It's a step back, yes. But only until v5.16 (I don't think the change= s > > > will make it during the merge window). I guess you are concerned > > > because > > > of your vendor fork? Mh, well actually I don't understand your > > > concert, > > > because your tree isn't compatible anyway if we change the labels. > >=20 > > No, I don't care about "our vendor fork", it's been years since I've > > stopped using that. > >=20 > > > We'd trade the clear information where the device tree is from for > > > something that - in my opinion - is not worth it. I mean the device > > > tree (source) is used just here in u-boot for these three boards and > > > all have the usb nodes enabled. > >=20 > > My concern was actually much simpler: your v1 conversion of the label > > names was buggy (see the LS1028A-QDS build breakage). You deleted a > > bunch of comments which U-Boot had but Linux did not (luckily they did > > not provide a lot of useful information anyway). You introduced some > > comments which do not make sense for the U-Boot tree, because they were > > in Linux: the ICIDs in the iommu-map being fixed up by the bootloader > > (you can instead say that "we will fix these up for the operating > > system"). > > Again, not big issues, but if it would boil down to my common sense, > > I'd focus more on the binary compatibility (after all, there will still > > be U-Boot specifics, which will constitute textual differences, but > > Linux will gladly ignore them, because this is what binary compatibilit= y > > is about), and if it is preferable to have status =3D 'disabled' in the > > dtsi, and a patch was already sent to Linux but not yet accepted, I > > would have kept U-Boot the way it was, and follow a model of > > "eventual consistency". > >=20 > > If you still care more about textual consistency, I went through the > > patches > > once already, so it's not like changing things now will make things > > easier, > > or matter. >=20 > Ok, I see. But shouldn't be the goal to make things easy and just copy > the device tree to u-boot once in a while? Otherwise, we will eventually > end up in the same mess as it is right now. Because well if they are > different anyway, then "we can just add another small thing right here > and there". So if we "just add another small thing here and there", where that thing is a comment, or a 'status =3D "disabled"' structured differently but to the same result, does that land us in the "same mess" where half of the peripherals, and networking, would not work in Linux with the U-Boot provided DT? > So yes, if you mean that by textual consistency, I care about that. Okay. > And about the lost/wrong comments. We should "fix"/add/reword them in > linux, no? In the case of SMMU ICIDs, it is a matter of perspective (bootloader vs kernel). If the phrasing is generic enough to cover both perspectives, I've no problem. In this case, after the initial reaction, I might even be ok with the current phrasing of "/* fixed up by bootloader */". It is not very clarifying, but not outright wrong either. My larger point was that if we now swing in the opposite direction, and can't make a common-sense decision before making it in Linux first, and then waiting for the next merge window, that's.. strange? Anyway, quite a storm in a teacup.=