From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mLPvS-0003iL-Oh for mharc-grub-devel@gnu.org; Wed, 01 Sep 2021 09:05:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLPvR-0003Zy-DL for grub-devel@gnu.org; Wed, 01 Sep 2021 09:05:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLPvO-0003CE-Op for grub-devel@gnu.org; Wed, 01 Sep 2021 09:05:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630501505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4jPpr3/1qqLq4IOpSx3R9jwA60C0j1+l+0I6zOE7qf0=; b=S+ShhrMbkrG1U58ZAqWCI+uCi18ii9IrQpfyaVJEv1WlOWI21UPeOss+lctlmqD4LrUtfB /XC3hhkURdJYT7+Ti+5Hxh7EOti8kjxno31Mfpv3Z3CwsyVSHdtU1exu98hp6fpDaFnqCZ 71YN0BCjirn60N1NrnRaTqm1RfGzDd4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-JyTEQOdCOgWF7QIsZ3yGxQ-1; Wed, 01 Sep 2021 09:05:04 -0400 X-MC-Unique: JyTEQOdCOgWF7QIsZ3yGxQ-1 Received: by mail-ej1-f72.google.com with SMTP id bx10-20020a170906a1ca00b005c341820edeso1365370ejb.10 for ; Wed, 01 Sep 2021 06:05:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4jPpr3/1qqLq4IOpSx3R9jwA60C0j1+l+0I6zOE7qf0=; b=ky38PLLd143mNd1dplbTdn9bNWkR1GkUUYe7LrbhwBTecmMDbWDiwqskRzaoiCoLjy K9ZmbXiJPP74WFH4/ZqGPVq3SIoeXDp7j8Bu9FfHLkiqgTqPB61khNdxkMG8cEzzca9U 8Oflt+UVnZSPfaEnEOmoSPyyvVN3U74Q21esprdeKIGbCeH4Q4sg4fbc+tJ2QxfoNl0j kwA2D6ia1+RqlN0jsdR0c1LWOGk2Fh7NY0koamVbUVOr3nwANIVdnukbB0OvY3NtEqbq eORbC9HUWgu6EQcQKC/ZxPenJqcBaMRggsdv4Ck6HAAfZvsEs7BJC2zgk692w4iSXJcT 5KHA== X-Gm-Message-State: AOAM532pShIA9Da/D1R6EQphi8vGQqy0Sh9USqZ34f9PABuLswuZw1t9 PYR1ZXILZdzoFqAHpB8uJw1cJQwd93c+dg3/E1CX6vvMGFkXZQlirR1ga1Me1Yq4+LGvoH8fuZv 70/5hxLu7V2U= X-Received: by 2002:a05:6402:31b9:: with SMTP id dj25mr35020762edb.180.1630501503233; Wed, 01 Sep 2021 06:05:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyck5nCB/AWnwQkxosTQs4tOZt9yJEWxgah0K20Zw6eL7NdCkpXPj1E2Rr5WgEY/bSMZ2o/A== X-Received: by 2002:a05:6402:31b9:: with SMTP id dj25mr35020726edb.180.1630501502828; Wed, 01 Sep 2021 06:05:02 -0700 (PDT) Received: from omega.lan (ip4-46-39-172-19.cust.nbox.cz. [46.39.172.19]) by smtp.gmail.com with ESMTPSA id lb12sm10027541ejc.28.2021.09.01.06.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 06:05:02 -0700 (PDT) Date: Wed, 1 Sep 2021 15:05:00 +0200 From: Carlos Maiolino To: Daniel Kiper Cc: Erwan Velu , grub-devel@gnu.org, a.rougemont@criteo.com, Erwan Velu , daniel.kiper@oracle.com, alexander.burmashev@oracle.com, phcoder@gmail.com, javierm@redhat.com Subject: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock Message-ID: <20210901130500.3gxhwpfjn3ultvko@omega.lan> References: <20210825133152.1165682-1-e.velu@criteo.com> <20210826132616.dhhiwdowapcolrdr@omega.lan> <20210830114850.kemzuknbe4nwzkip@omega.lan> <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl> MIME-Version: 1.0 In-Reply-To: <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cmaiolino@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=cmaiolino@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2021 13:05:09 -0000 On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > > Good day list, > > > Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiolino@redhat.com> > > > a écrit : > > > > > > [..] > > > Thanks for spotting this! > > > > > > I'm adding the maintainers in CC. Carlos who commit the patch I'm > > > fixing, agreed on the content. > > > > I didn't test the patch itself yet, but I've reproduced the issue. I was quite > > sure I had tested this patch on a V4 fs, but looks like I miscalculated the > > sizing. Thanks again. I'll try to test the patch here asap. > > Did you test this patch? If yes may I add your Tested-by to it? Not yet, I may be able to test it today, I let you know. > > Daniel > -- Carlos