From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D717C432BE for ; Wed, 1 Sep 2021 16:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2CEA6069E for ; Wed, 1 Sep 2021 16:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343973AbhIAQD5 (ORCPT ); Wed, 1 Sep 2021 12:03:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55762 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343748AbhIAQDw (ORCPT ); Wed, 1 Sep 2021 12:03:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630512175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xMRtrXe3M1vVJaRkGQ5o+yZQJhadRFN9gcbbCnaAFSQ=; b=Wlmp9j2uGDTBXavcOtRbZjt5fn8MyjViZK/n85MyTor8+9DwQwwQDuy6IUM81zh7yBrCu0 iiudIGbJnCZcOQ7AXHJzG3wENL6UtqtgOGXYpEo6ibqHrS8EwDlUn72QLkIX7IGWCVxrSM gVGLukvXt8HUv2p6+5OgBfqZ97wbdTw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-_faMLM-vMfSyd6CWe7D1pA-1; Wed, 01 Sep 2021 12:02:50 -0400 X-MC-Unique: _faMLM-vMfSyd6CWe7D1pA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9978719611A2; Wed, 1 Sep 2021 16:02:49 +0000 (UTC) Received: from asgard.redhat.com (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46EB45E253; Wed, 1 Sep 2021 16:02:47 +0000 (UTC) Date: Wed, 1 Sep 2021 18:02:44 +0200 From: Eugene Syromiatnikov To: Cai Huoqing Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Message-ID: <20210901160244.GA5957@asgard.redhat.com> References: <20210813120803.101-1-caihuoqing@baidu.com> <20210813120803.101-2-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813120803.101-2-caihuoqing@baidu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > commit <47595e32869f> ("") > indicated the ipx network layer as obsolete in Jan 2018, > updated in the MAINTAINERS file > > now, after being exposed for 3 years to refactoring, so to > delete uapi/linux/ipx.h and net/ipx.h header files for good. > additionally, there is no module that depends on ipx.h except > a broken staging driver(r8188eu) > > Signed-off-by: Cai Huoqing This removal breaks audit[1] and potentially breaks strace[2][3], at least. [1] https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e140c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/net.c#L34 [3] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/sockaddr.c#L30