All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: testusb: Fix for showing the connection speed
@ 2021-08-31 17:47 faizel.kb
  2021-09-01  5:49 ` Felipe Balbi
  2021-09-01  5:56 ` Greg KH
  0 siblings, 2 replies; 8+ messages in thread
From: faizel.kb @ 2021-08-31 17:47 UTC (permalink / raw)
  To: gregkh; +Cc: linux-usb, faizel.kb

'testusb' application which uses 'usbtest' driver reports 'unknown speed'
from the function 'find_testdev'. The variable 'entry->speed' was not
updated from  the application. The IOCTL mentioned in the FIXME comment can
only report whether the connection is low speed or not. Speed is read using
the IOCTL USBDEVFS_GET_SPEED which reports the proper speed grade.  The
call is implemented in the function 'handle_testdev' where the file
descriptor was availble locally. Sample output is given below where 'high
speed' is printed as the connected speed.

sudo ./testusb -a
high speed      /dev/bus/usb/001/011    0
/dev/bus/usb/001/011 test 0,    0.000015 secs
/dev/bus/usb/001/011 test 1,    0.194208 secs
/dev/bus/usb/001/011 test 2,    0.077289 secs
/dev/bus/usb/001/011 test 3,    0.170604 secs
/dev/bus/usb/001/011 test 4,    0.108335 secs
/dev/bus/usb/001/011 test 5,    2.788076 secs
/dev/bus/usb/001/011 test 6,    2.594610 secs
/dev/bus/usb/001/011 test 7,    2.905459 secs
/dev/bus/usb/001/011 test 8,    2.795193 secs
/dev/bus/usb/001/011 test 9,    8.372651 secs
/dev/bus/usb/001/011 test 10,    6.919731 secs
/dev/bus/usb/001/011 test 11,   16.372687 secs
/dev/bus/usb/001/011 test 12,   16.375233 secs
/dev/bus/usb/001/011 test 13,    2.977457 secs
/dev/bus/usb/001/011 test 14 --> 22 (Invalid argument)
/dev/bus/usb/001/011 test 17,    0.148826 secs
/dev/bus/usb/001/011 test 18,    0.068718 secs
/dev/bus/usb/001/011 test 19,    0.125992 secs
/dev/bus/usb/001/011 test 20,    0.127477 secs
/dev/bus/usb/001/011 test 21 --> 22 (Invalid argument)
/dev/bus/usb/001/011 test 24,    4.133763 secs
/dev/bus/usb/001/011 test 27,    2.140066 secs
/dev/bus/usb/001/011 test 28,    2.120713 secs
/dev/bus/usb/001/011 test 29,    0.507762 secs

Signed-off-by: faizel.kb <faizel.kb@dicortech.com>
---
 tools/usb/testusb.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
index ee8208b2f946..69c3ead25313 100644
--- a/tools/usb/testusb.c
+++ b/tools/usb/testusb.c
@@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
 	}
 
 	entry->ifnum = ifnum;
-
-	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
-
-	fprintf(stderr, "%s speed\t%s\t%u\n",
-		speed(entry->speed), entry->name, entry->ifnum);
-
 	entry->next = testdevs;
 	testdevs = entry;
 	return 0;
@@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
 		return 0;
 	}
 
+	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
+	if (status < 0)
+		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
+	else
+		dev->speed = status;
+	fprintf(stderr, "%s speed\t%s\t%u\n",
+			speed(dev->speed), dev->name, dev->ifnum);
+
 restart:
 	for (i = 0; i < TEST_CASES; i++) {
 		if (dev->test != -1 && dev->test != i)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-08-31 17:47 [PATCH] usb: testusb: Fix for showing the connection speed faizel.kb
@ 2021-09-01  5:49 ` Felipe Balbi
  2021-09-01  5:56 ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Felipe Balbi @ 2021-09-01  5:49 UTC (permalink / raw)
  To: faizel.kb; +Cc: gregkh, linux-usb


"faizel.kb" <faizel.kb@dicortech.com> writes:

> 'testusb' application which uses 'usbtest' driver reports 'unknown speed'
> from the function 'find_testdev'. The variable 'entry->speed' was not
> updated from  the application. The IOCTL mentioned in the FIXME comment can
> only report whether the connection is low speed or not. Speed is read using
> the IOCTL USBDEVFS_GET_SPEED which reports the proper speed grade.  The
> call is implemented in the function 'handle_testdev' where the file
> descriptor was availble locally. Sample output is given below where 'high
> speed' is printed as the connected speed.
>
> sudo ./testusb -a
> high speed      /dev/bus/usb/001/011    0
> /dev/bus/usb/001/011 test 0,    0.000015 secs
> /dev/bus/usb/001/011 test 1,    0.194208 secs
> /dev/bus/usb/001/011 test 2,    0.077289 secs
> /dev/bus/usb/001/011 test 3,    0.170604 secs
> /dev/bus/usb/001/011 test 4,    0.108335 secs
> /dev/bus/usb/001/011 test 5,    2.788076 secs
> /dev/bus/usb/001/011 test 6,    2.594610 secs
> /dev/bus/usb/001/011 test 7,    2.905459 secs
> /dev/bus/usb/001/011 test 8,    2.795193 secs
> /dev/bus/usb/001/011 test 9,    8.372651 secs
> /dev/bus/usb/001/011 test 10,    6.919731 secs
> /dev/bus/usb/001/011 test 11,   16.372687 secs
> /dev/bus/usb/001/011 test 12,   16.375233 secs
> /dev/bus/usb/001/011 test 13,    2.977457 secs
> /dev/bus/usb/001/011 test 14 --> 22 (Invalid argument)
> /dev/bus/usb/001/011 test 17,    0.148826 secs
> /dev/bus/usb/001/011 test 18,    0.068718 secs
> /dev/bus/usb/001/011 test 19,    0.125992 secs
> /dev/bus/usb/001/011 test 20,    0.127477 secs
> /dev/bus/usb/001/011 test 21 --> 22 (Invalid argument)
> /dev/bus/usb/001/011 test 24,    4.133763 secs
> /dev/bus/usb/001/011 test 27,    2.140066 secs
> /dev/bus/usb/001/011 test 28,    2.120713 secs
> /dev/bus/usb/001/011 test 29,    0.507762 secs
>
> Signed-off-by: faizel.kb <faizel.kb@dicortech.com>

Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-08-31 17:47 [PATCH] usb: testusb: Fix for showing the connection speed faizel.kb
  2021-09-01  5:49 ` Felipe Balbi
@ 2021-09-01  5:56 ` Greg KH
  2021-09-01 18:13   ` Faizel K B
  1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-09-01  5:56 UTC (permalink / raw)
  To: faizel.kb; +Cc: linux-usb

On Tue, Aug 31, 2021 at 11:17:42PM +0530, faizel.kb wrote:
> 'testusb' application which uses 'usbtest' driver reports 'unknown speed'
> from the function 'find_testdev'. The variable 'entry->speed' was not
> updated from  the application. The IOCTL mentioned in the FIXME comment can
> only report whether the connection is low speed or not. Speed is read using
> the IOCTL USBDEVFS_GET_SPEED which reports the proper speed grade.  The
> call is implemented in the function 'handle_testdev' where the file
> descriptor was availble locally. Sample output is given below where 'high
> speed' is printed as the connected speed.
> 
> sudo ./testusb -a
> high speed      /dev/bus/usb/001/011    0
> /dev/bus/usb/001/011 test 0,    0.000015 secs
> /dev/bus/usb/001/011 test 1,    0.194208 secs
> /dev/bus/usb/001/011 test 2,    0.077289 secs
> /dev/bus/usb/001/011 test 3,    0.170604 secs
> /dev/bus/usb/001/011 test 4,    0.108335 secs
> /dev/bus/usb/001/011 test 5,    2.788076 secs
> /dev/bus/usb/001/011 test 6,    2.594610 secs
> /dev/bus/usb/001/011 test 7,    2.905459 secs
> /dev/bus/usb/001/011 test 8,    2.795193 secs
> /dev/bus/usb/001/011 test 9,    8.372651 secs
> /dev/bus/usb/001/011 test 10,    6.919731 secs
> /dev/bus/usb/001/011 test 11,   16.372687 secs
> /dev/bus/usb/001/011 test 12,   16.375233 secs
> /dev/bus/usb/001/011 test 13,    2.977457 secs
> /dev/bus/usb/001/011 test 14 --> 22 (Invalid argument)
> /dev/bus/usb/001/011 test 17,    0.148826 secs
> /dev/bus/usb/001/011 test 18,    0.068718 secs
> /dev/bus/usb/001/011 test 19,    0.125992 secs
> /dev/bus/usb/001/011 test 20,    0.127477 secs
> /dev/bus/usb/001/011 test 21 --> 22 (Invalid argument)
> /dev/bus/usb/001/011 test 24,    4.133763 secs
> /dev/bus/usb/001/011 test 27,    2.140066 secs
> /dev/bus/usb/001/011 test 28,    2.120713 secs
> /dev/bus/usb/001/011 test 29,    0.507762 secs
> 
> Signed-off-by: faizel.kb <faizel.kb@dicortech.com>
> ---
>  tools/usb/testusb.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> index ee8208b2f946..69c3ead25313 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
> @@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
>  	}
>  
>  	entry->ifnum = ifnum;
> -
> -	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
> -
> -	fprintf(stderr, "%s speed\t%s\t%u\n",
> -		speed(entry->speed), entry->name, entry->ifnum);
> -
>  	entry->next = testdevs;
>  	testdevs = entry;
>  	return 0;
> @@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
>  		return 0;
>  	}
>  
> +	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
> +	if (status < 0)
> +		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
> +	else
> +		dev->speed = status;
> +	fprintf(stderr, "%s speed\t%s\t%u\n",
> +			speed(dev->speed), dev->name, dev->ifnum);
> +
>  restart:
>  	for (i = 0; i < TEST_CASES; i++) {
>  		if (dev->test != -1 && dev->test != i)
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-09-01  5:56 ` Greg KH
@ 2021-09-01 18:13   ` Faizel K B
  2021-09-01 18:24     ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Faizel K B @ 2021-09-01 18:13 UTC (permalink / raw)
  To: gregkh; +Cc: linux-usb, Faizel K B

Signed-off-by: Faizel K B <faizel.kb@dicortech.com>
---
 tools/usb/testusb.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
index ee8208b2f946..69c3ead25313 100644
--- a/tools/usb/testusb.c
+++ b/tools/usb/testusb.c
@@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
 	}
 
 	entry->ifnum = ifnum;
-
-	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
-
-	fprintf(stderr, "%s speed\t%s\t%u\n",
-		speed(entry->speed), entry->name, entry->ifnum);
-
 	entry->next = testdevs;
 	testdevs = entry;
 	return 0;
@@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
 		return 0;
 	}
 
+	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
+	if (status < 0)
+		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
+	else
+		dev->speed = status;
+	fprintf(stderr, "%s speed\t%s\t%u\n",
+			speed(dev->speed), dev->name, dev->ifnum);
+
 restart:
 	for (i = 0; i < TEST_CASES; i++) {
 		if (dev->test != -1 && dev->test != i)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-09-01 18:13   ` Faizel K B
@ 2021-09-01 18:24     ` Greg KH
  2021-09-02  8:33       ` Faizel K B
  0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-09-01 18:24 UTC (permalink / raw)
  To: Faizel K B; +Cc: linux-usb

On Wed, Sep 01, 2021 at 11:43:51PM +0530, Faizel K B wrote:
> Signed-off-by: Faizel K B <faizel.kb@dicortech.com>
> ---
>  tools/usb/testusb.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> index ee8208b2f946..69c3ead25313 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
> @@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
>  	}
>  
>  	entry->ifnum = ifnum;
> -
> -	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
> -
> -	fprintf(stderr, "%s speed\t%s\t%u\n",
> -		speed(entry->speed), entry->name, entry->ifnum);
> -
>  	entry->next = testdevs;
>  	testdevs = entry;
>  	return 0;
> @@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
>  		return 0;
>  	}
>  
> +	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
> +	if (status < 0)
> +		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
> +	else
> +		dev->speed = status;
> +	fprintf(stderr, "%s speed\t%s\t%u\n",
> +			speed(dev->speed), dev->name, dev->ifnum);
> +
>  restart:
>  	for (i = 0; i < TEST_CASES; i++) {
>  		if (dev->test != -1 && dev->test != i)
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-09-01 18:24     ` Greg KH
@ 2021-09-02  8:33       ` Faizel K B
  2021-09-02  8:42         ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Faizel K B @ 2021-09-02  8:33 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-usb

On Wed, Sep 01, 2021 at 08:24:08PM +0200, Greg KH wrote:
> On Wed, Sep 01, 2021 at 11:43:51PM +0530, Faizel K B wrote:
> > Signed-off-by: Faizel K B <faizel.kb@dicortech.com>
> > ---
> >  tools/usb/testusb.c | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> > index ee8208b2f946..69c3ead25313 100644
> > --- a/tools/usb/testusb.c
> > +++ b/tools/usb/testusb.c
> > @@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
> >  	}
> >  
> >  	entry->ifnum = ifnum;
> > -
> > -	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
> > -
> > -	fprintf(stderr, "%s speed\t%s\t%u\n",
> > -		speed(entry->speed), entry->name, entry->ifnum);
> > -
> >  	entry->next = testdevs;
> >  	testdevs = entry;
> >  	return 0;
> > @@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
> >  		return 0;
> >  	}
> >  
> > +	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
> > +	if (status < 0)
> > +		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
> > +	else
> > +		dev->speed = status;
> > +	fprintf(stderr, "%s speed\t%s\t%u\n",
> > +			speed(dev->speed), dev->name, dev->ifnum);
> > +
> >  restart:
> >  	for (i = 0; i < TEST_CASES; i++) {
> >  		if (dev->test != -1 && dev->test != i)
> > -- 
> > 2.25.1
> > 
> 
> Hi,
> 
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
> 
> You are receiving this message because of the following common error(s)
> as indicated below:
> 
> - You did not specify a description of why the patch is needed, or
>   possibly, any description at all, in the email body.  Please read the
>   section entitled "The canonical patch format" in the kernel file,
>   Documentation/SubmittingPatches for what is needed in order to
>   properly describe the change.
> 
> - This looks like a new version of a previously submitted patch, but you
>   did not list below the --- line any changes from the previous version.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/SubmittingPatches for what needs to be done
>   here to properly describe this.
> 
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
> 
> thanks,
> 
> greg k-h's patch email bot
Is it expected to be a separate patch (version 2)? Since the change is
only in the updated 'real name' for the 'from' field and 'Signed Off' field
in response with the previous message from the bot.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-09-02  8:33       ` Faizel K B
@ 2021-09-02  8:42         ` Greg KH
  2021-09-02  8:58           ` Faizel K B
  0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-09-02  8:42 UTC (permalink / raw)
  To: Faizel K B; +Cc: linux-usb

On Thu, Sep 02, 2021 at 02:03:15PM +0530, Faizel K B wrote:
> On Wed, Sep 01, 2021 at 08:24:08PM +0200, Greg KH wrote:
> > On Wed, Sep 01, 2021 at 11:43:51PM +0530, Faizel K B wrote:
> > > Signed-off-by: Faizel K B <faizel.kb@dicortech.com>
> > > ---
> > >  tools/usb/testusb.c | 14 ++++++++------
> > >  1 file changed, 8 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> > > index ee8208b2f946..69c3ead25313 100644
> > > --- a/tools/usb/testusb.c
> > > +++ b/tools/usb/testusb.c
> > > @@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
> > >  	}
> > >  
> > >  	entry->ifnum = ifnum;
> > > -
> > > -	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
> > > -
> > > -	fprintf(stderr, "%s speed\t%s\t%u\n",
> > > -		speed(entry->speed), entry->name, entry->ifnum);
> > > -
> > >  	entry->next = testdevs;
> > >  	testdevs = entry;
> > >  	return 0;
> > > @@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
> > >  		return 0;
> > >  	}
> > >  
> > > +	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
> > > +	if (status < 0)
> > > +		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
> > > +	else
> > > +		dev->speed = status;
> > > +	fprintf(stderr, "%s speed\t%s\t%u\n",
> > > +			speed(dev->speed), dev->name, dev->ifnum);
> > > +
> > >  restart:
> > >  	for (i = 0; i < TEST_CASES; i++) {
> > >  		if (dev->test != -1 && dev->test != i)
> > > -- 
> > > 2.25.1
> > > 
> > 
> > Hi,
> > 
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created.  Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> > 
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> > 
> > - You did not specify a description of why the patch is needed, or
> >   possibly, any description at all, in the email body.  Please read the
> >   section entitled "The canonical patch format" in the kernel file,
> >   Documentation/SubmittingPatches for what is needed in order to
> >   properly describe the change.
> > 
> > - This looks like a new version of a previously submitted patch, but you
> >   did not list below the --- line any changes from the previous version.
> >   Please read the section entitled "The canonical patch format" in the
> >   kernel file, Documentation/SubmittingPatches for what needs to be done
> >   here to properly describe this.
> > 
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> > 
> > thanks,
> > 
> > greg k-h's patch email bot
> Is it expected to be a separate patch (version 2)? Since the change is
> only in the updated 'real name' for the 'from' field and 'Signed Off' field
> in response with the previous message from the bot.

Yes, of course, how else would we know this is a newer patch?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] usb: testusb: Fix for showing the connection speed
  2021-09-02  8:42         ` Greg KH
@ 2021-09-02  8:58           ` Faizel K B
  0 siblings, 0 replies; 8+ messages in thread
From: Faizel K B @ 2021-09-02  8:58 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-usb

On Thu, Sep 02, 2021 at 10:42:52AM +0200, Greg KH wrote:
> On Thu, Sep 02, 2021 at 02:03:15PM +0530, Faizel K B wrote:
> > On Wed, Sep 01, 2021 at 08:24:08PM +0200, Greg KH wrote:
> > > On Wed, Sep 01, 2021 at 11:43:51PM +0530, Faizel K B wrote:
> > > > Signed-off-by: Faizel K B <faizel.kb@dicortech.com>
> > > > ---
> > > >  tools/usb/testusb.c | 14 ++++++++------
> > > >  1 file changed, 8 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> > > > index ee8208b2f946..69c3ead25313 100644
> > > > --- a/tools/usb/testusb.c
> > > > +++ b/tools/usb/testusb.c
> > > > @@ -265,12 +265,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)
> > > >  	}
> > > >  
> > > >  	entry->ifnum = ifnum;
> > > > -
> > > > -	/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
> > > > -
> > > > -	fprintf(stderr, "%s speed\t%s\t%u\n",
> > > > -		speed(entry->speed), entry->name, entry->ifnum);
> > > > -
> > > >  	entry->next = testdevs;
> > > >  	testdevs = entry;
> > > >  	return 0;
> > > > @@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
> > > >  		return 0;
> > > >  	}
> > > >  
> > > > +	status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
> > > > +	if (status < 0)
> > > > +		fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
> > > > +	else
> > > > +		dev->speed = status;
> > > > +	fprintf(stderr, "%s speed\t%s\t%u\n",
> > > > +			speed(dev->speed), dev->name, dev->ifnum);
> > > > +
> > > >  restart:
> > > >  	for (i = 0; i < TEST_CASES; i++) {
> > > >  		if (dev->test != -1 && dev->test != i)
> > > > -- 
> > > > 2.25.1
> > > > 
> > > 
> > > Hi,
> > > 
> > > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > > a patch that has triggered this response.  He used to manually respond
> > > to these common problems, but in order to save his sanity (he kept
> > > writing the same thing over and over, yet to different people), I was
> > > created.  Hopefully you will not take offence and will fix the problem
> > > in your patch and resubmit it so that it can be accepted into the Linux
> > > kernel tree.
> > > 
> > > You are receiving this message because of the following common error(s)
> > > as indicated below:
> > > 
> > > - You did not specify a description of why the patch is needed, or
> > >   possibly, any description at all, in the email body.  Please read the
> > >   section entitled "The canonical patch format" in the kernel file,
> > >   Documentation/SubmittingPatches for what is needed in order to
> > >   properly describe the change.
> > > 
> > > - This looks like a new version of a previously submitted patch, but you
> > >   did not list below the --- line any changes from the previous version.
> > >   Please read the section entitled "The canonical patch format" in the
> > >   kernel file, Documentation/SubmittingPatches for what needs to be done
> > >   here to properly describe this.
> > > 
> > > If you wish to discuss this problem further, or you have questions about
> > > how to resolve this issue, please feel free to respond to this email and
> > > Greg will reply once he has dug out from the pending patches received
> > > from other developers.
> > > 
> > > thanks,
> > > 
> > > greg k-h's patch email bot
> > Is it expected to be a separate patch (version 2)? Since the change is
> > only in the updated 'real name' for the 'from' field and 'Signed Off' field
> > in response with the previous message from the bot.
> 
> Yes, of course, how else would we know this is a newer patch?
> 
> thanks,
> 
> greg k-h

Ok. Will send it as new version.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-02  8:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 17:47 [PATCH] usb: testusb: Fix for showing the connection speed faizel.kb
2021-09-01  5:49 ` Felipe Balbi
2021-09-01  5:56 ` Greg KH
2021-09-01 18:13   ` Faizel K B
2021-09-01 18:24     ` Greg KH
2021-09-02  8:33       ` Faizel K B
2021-09-02  8:42         ` Greg KH
2021-09-02  8:58           ` Faizel K B

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.